Skip to contentSkip to conversation

Staging: comedi: fix semicolon coding style issue in ni_660x.c

PATCH In review Dhanunjaya Naidu Ravada 2 participants 2 messages Oct 16, 2013 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 Staging: comedi: fix semicolon coding style issue in ni_660x.c

From: Dhanunjaya <[email protected]>

This is a patch to the ni_660x.c file that fixes up a semicolon warning found by the checkpatch.pl tool.

---
 drivers/staging/comedi/drivers/ni_660x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/ni_660x.c +2 -2
index 3607336..95bb432 100644
@@ -28,7 +28,7 @@
  *
  * Encoders work.  PulseGeneration (both single pulse and pulse train)
  * works.  Buffered commands work for input but not output.
- * 
+ *
  * References:
  * DAQ 660x Register-Level Programmer Manual  (NI 370505A-01)
  * DAQ 6601/6602 User Manual (NI 322137B-01)
@@ -1232,7 +1232,7 @@ static int ni_660x_auto_attach(struct comedi_device *dev,
 			s->type = COMEDI_SUBD_COUNTER;
 			s->subdev_flags =
 			    SDF_READABLE | SDF_WRITABLE | SDF_LSAMPL |
-			    SDF_CMD_READ /* | SDF_CMD_WRITE */ ;
+			    SDF_CMD_READ; /* | SDF_CMD_WRITE */
 			s->n_chan = 3;
 			s->maxdata = 0xffffffff;
 			s->insn_read = ni_660x_GPCT_rinsn;
Signature · 1 line
1.8.1.2
maintainer
#1 lore raw
Quoted 1 line · Dhanunjaya Naidu Ravada

From: Dhanunjaya <[email protected]>

Again, doesn't match the signed-off-by: or From: line on your email :(

Quoted 2 lines

This is a patch to the ni_660x.c file that fixes up a semicolon warning found by the checkpatch.pl tool.

No it isn't, it also does something else in this file.

Quoted 11 lines
---
 drivers/staging/comedi/drivers/ni_660x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/ni_660x.c +0 -0
index 3607336..95bb432 100644

drivers/staging/comedi/drivers/ni_660x.c line 31

Quoted 5 lines
drivers/staging/comedi/drivers/ni_660x.c +1 -1
@@ -28,7 +28,7 @@
  *
  * Encoders work.  PulseGeneration (both single pulse and pulse train)
  * works.  Buffered commands work for input but not output.
- * 
+ *

That doesn't look like a semicolon fix.

drivers/staging/comedi/drivers/ni_660x.c static int ni_660x_auto_attach(struct comedi_device *dev, · line 1235

Quoted 9 lines
drivers/staging/comedi/drivers/ni_660x.c +1 -1
  * References:
  * DAQ 660x Register-Level Programmer Manual  (NI 370505A-01)
  * DAQ 6601/6602 User Manual (NI 322137B-01)
@@ -1232,7 +1232,7 @@ static int ni_660x_auto_attach(struct comedi_device *dev,
 			s->type = COMEDI_SUBD_COUNTER;
 			s->subdev_flags =
 			    SDF_READABLE | SDF_WRITABLE | SDF_LSAMPL |
-			    SDF_CMD_READ /* | SDF_CMD_WRITE */ ;
+			    SDF_CMD_READ; /* | SDF_CMD_WRITE */

Nope, please leave the original code, it's correct.

greg k-h