drm/i915: fix open-coded DIV_ROUND_UP
Subsystems (2)
PATCH 1/1 drm/i915: fix open-coded DIV_ROUND_UP
From: Paulo Zanoni <[email protected]>
Use the nice Kernel macro, it makes the code much more readable.
Signed-off-by Paulo Zanoni <[email protected]>
--- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/intel_fbdev.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +1 -1
@@ -261,7 +261,7 @@ i915_gem_dumb_create(struct drm_file *file, struct drm_mode_create_dumb *args) {/* have to work out size/pitch and return them */ - args->pitch =ALIGN (args->width * ((args->bpp +7 ) /8 ),64 ); + args->pitch =ALIGN (args->width *DIV_ROUND_UP (args->bpp,8 ),64 ); args->size = args->pitch * args->height;return i915_gem_create (file, dev, args->size, &args->handle);
drivers/gpu/drm/i915/intel_fbdev.c +2 -2
@@ -78,8 +78,8 @@ static int intelfb_create(struct drm_fb_helper *helper, mode_cmd.width = sizes->surface_width; mode_cmd.height = sizes->surface_height; - mode_cmd.pitches[0 ] =ALIGN (mode_cmd.width * ((sizes->surface_bpp +7 ) / -8 ),64 ); + mode_cmd.pitches[0 ] =ALIGN (mode_cmd.width * +DIV_ROUND_UP (sizes->surface_bpp,8 ),64 ); mode_cmd.pixel_format =drm_mode_legacy_fb_format (sizes->surface_bpp, sizes->surface_depth);
Signature · 1 line
1.8.4.rc3
Quoted 5 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
Use the nice Kernel macro, it makes the code much more readable.
Signed-off-by Paulo Zanoni <[email protected]>
Reviewed-by Jani Nikula <[email protected]>
Quoted 40 lines
--- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/intel_fbdev.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_gem.c +1
-1@@ -261,7 +261,7 @@ i915_gem_dumb_create(struct drm_file *file, struct drm_mode_create_dumb *args) {/* have to work out size/pitch and return them */ - args->pitch =ALIGN (args->width * ((args->bpp +7 ) /8 ),64 ); + args->pitch =ALIGN (args->width *DIV_ROUND_UP (args->bpp,8 ),64 ); args->size = args->pitch * args->height;return i915_gem_create (file, dev, args->size, &args->handle);drivers/gpu/drm/i915/intel_fbdev.c +2
-2@@ -78,8 +78,8 @@ static int intelfb_create(struct drm_fb_helper *helper, mode_cmd.width = sizes->surface_width; mode_cmd.height = sizes->surface_height; - mode_cmd.pitches[0 ] =ALIGN (mode_cmd.width * ((sizes->surface_bpp +7 ) / -8 ),64 ); + mode_cmd.pitches[0 ] =ALIGN (mode_cmd.width * +DIV_ROUND_UP (sizes->surface_bpp,8 ),64 ); mode_cmd.pixel_format =drm_mode_legacy_fb_format (sizes->surface_bpp, sizes->surface_depth);Signature · 6 lines
1.8.4.rc3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Daniel Vetter
AppliedQuoted 8 lines · Jani Nikula
Quoted 5 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
Use the nice Kernel macro, it makes the code much more readable.
Signed-off-by Paulo Zanoni <[email protected]>Reviewed-by Jani Nikula <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch