Skip to contentSkip to conversation

set_elem: fix access after free in case of parsing errors

PATCH New Pablo Neira Ayuso 1 participant 1 message Oct 21, 2013 netfilter

lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 set_elem: fix access after free in case of parsing errors

If this fails to parse a set element, stop the processing.

---
 src/set_elem.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
src/set_elem.c +3 -1
index 5bb82f6..5ef46f2 100644
@@ -298,8 +298,10 @@ static int nft_set_elems_parse2(struct nft_set *s, const struct nlattr *nest)
 			break;
 		}
         }
-	if (ret < 0)
+	if (ret < 0) {
 		xfree(e);
+		return -1;
+	}
 
 	/* Add this new element to this set */
 	list_add_tail(&e->head, &s->element_list);
Signature · 1 line
1.7.10.4