drm/i915: Avoid accessing the stolen address when it is unavailable
Subsystems (2)
In our platform, we hit the the stolen region initialization failure case, such as below log:
[drm:i915_stolen_to_physical] *ERROR* conflict detected with stolen region: [0x7b000000]
And it causes the dev_priv->mm.stolen_base is NULL, in this case, we should avoid accessing it any more.
Here is possible call trace:intel_enable_gt_powersave -- >valleyview_enable_rps -- >valleyview_setup_pctx
--- drivers/gpu/drm/i915/intel_pm.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/intel_pm.c +3 -0
@@ -3735,6 +3735,9 @@ static void valleyview_setup_pctx(struct drm_device *dev)u32 pcbr;int pctx_size =24 *1024 ; +if (!dev_priv->mm.stolen_base) +return ; + pcbr =I915_READ (VLV_PCBR );if (pcbr) {/* BIOS set it up already, grab the pre-alloc'd space */
Signature · 1 line
1.7.9.5
Quoted 5 lines · Chuansheng Liu
In our platform, we hit the the stolen region initialization failure case, such as below log:
[drm:i915_stolen_to_physical] *ERROR* conflict detected with stolen region: [0x7b000000]
Quoted 7 lines
And it causes the
dev_priv->mm.stolen_baseis NULL, in this case, we should avoid accessing it any more.Here is possible call trace:
intel_enable_gt_powersave-- >valleyview_enable_rps-- >valleyview_setup_pctx
The two create_stolen routines are no-ops in that case so all that happens instead is that we read VLV_PCBR. However, really if i915_gem_object_create_stolen_for_preallocated() fails we should abort loading the driver as it means we have a hardware conflict and undefined behaviour.
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Quoted 14 lines · Chris Wilson
Quoted 5 lines · Chuansheng Liu
In our platform, we hit the the stolen region initialization failure case, such as below log:
[drm:i915_stolen_to_physical] *ERROR* conflict detected with stolen region: [0x7b000000]Quoted 7 lines
And it causes the
dev_priv->mm.stolen_baseis NULL, in this case, we should avoid accessing it any more.Here is possible call trace:
intel_enable_gt_powersave-- >valleyview_enable_rps-- >valleyview_setup_pctx
Quoted 9 lines
The two
create_stolenroutines are no-ops in that case so all that happens instead is that we readVLV_PCBR. However, really ifi915_gem_object_create_stolen_for_preallocated()fails we should abort loading the driver as it means we have a hardware conflict and undefined behaviour.
-ChrisSignature · 1 line
Chris Wilson, Intel Open Source Technology Centre
I agree. We should start treating these things as errors since no RPS/RC6 is essentially not what anyone wants.
For another immediate solution it seems you can demote the DRM_ERROR to DRM_DEBUG_DRIVER, and add a check in valleyview_enable_rps for the pctx value.
Signature · 1 line
Ben Widawsky, Intel Open Source Technology Center
Hello Chris and Ben,
Quoted 12 lines
-----Original Message-----
From: Ben Widawsky [mailto:[email protected]]
Sent: Friday, October 25, 2013 4:57 AM
To: Chris Wilson; Liu, Chuansheng; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Li, Fei
Subject: Re: [Intel-gfx] drm/i915: Avoid accessing the stolen address when it is unavailableQuoted 2 lines · Chris Wilson
Quoted 1 line · Chuansheng Liu
Quoted 19 lines
Quoted 3 lines
Quoted 3 lines
In our platform, we hit the the stolen region initialization failure case, such as below log:
[drm:i915_stolen_to_physical] *ERROR* conflict detected with stolenregion: [
0x7b000000]Quoted 2 lines
Quoted 2 lines
And it causes the
dev_priv->mm.stolen_baseis NULL, in this case, weshould
Quoted 12 lines
Quoted 6 lines
avoid accessing it any more.
Here is possible call trace:
intel_enable_gt_powersave-- >valleyview_enable_rps-- >valleyview_setup_pctxThe two
create_stolenroutines are no-ops in that case so all that happens instead is that we readVLV_PCBR. However, really ifi915_gem_object_create_stolen_for_preallocated()fails we should abort loading the driver as it means we have a hardware conflict and undefined behaviour.
In case of dev_priv->mm.stolen_base == NULL, and the valleyview_setup_pctx() is called at the first time, it will call i915_gem_object_create_stolen_for_preallocated(), which should should return NULL always due to (!drm_mm_initialized(&dev_priv->mm.stolen)).
After that, every time specially when doing pm operation, the above scenario will be called again and again.
Here this patch is to save some time for PM operation, we do not need to read VLV_PCBR and pcbr_offset calculation in case of stolen_base == NULL.
Is it making sense? Thanks.
Quoted 6 lines
I agree. We should start treating these things as errors since no RPS/RC6 is essentially not what anyone wants.
DRM_DEBUG_DRIVER, and add a check invalleyview_enable_rpsfor the pctx value.
The pctx is already checked in valleyview_disable_rps(). Do we need more checking in case of pctx == NULL?
Quoted 37 lines · Chuansheng
Hello Chris and Ben,
Quoted 12 lines
-----Original Message-----
From: Ben Widawsky [mailto:[email protected]]
Sent: Friday, October 25, 2013 4:57 AM
To: Chris Wilson; Liu, Chuansheng; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Li, Fei
Subject: Re: [Intel-gfx] drm/i915: Avoid accessing the stolen address when it is unavailableQuoted 2 lines · Chris Wilson
Quoted 1 line · Chuansheng Liu
Quoted 19 lines
Quoted 3 lines
Quoted 3 lines
In our platform, we hit the the stolen region initialization failure case, such as below log:
[drm:i915_stolen_to_physical] *ERROR* conflict detected with stolenregion: [
0x7b000000]Quoted 2 lines
Quoted 2 lines
And it causes the
dev_priv->mm.stolen_baseis NULL, in this case, weshould
Quoted 12 lines
Quoted 6 lines
avoid accessing it any more.
Here is possible call trace:
intel_enable_gt_powersave-- >valleyview_enable_rps-- >valleyview_setup_pctxThe two
create_stolenroutines are no-ops in that case so all that happens instead is that we readVLV_PCBR. However, really ifi915_gem_object_create_stolen_for_preallocated()fails we should abort loading the driver as it means we have a hardware conflict and undefined behaviour.In case of
dev_priv->mm.stolen_base== NULL, and thevalleyview_setup_pctx()is called at the first time, it will calli915_gem_object_create_stolen_for_preallocated(), which should should return NULL always due to (!drm_mm_initialized(&dev_priv->mm.stolen)).
Quoted 7 lines
After that, every time specially when doing pm operation, the above scenario will be called again and again.
Here this patch is to save some time for PM operation, we do not need to read
VLV_PCBRandpcbr_offsetcalculation in case ofstolen_base== NULL.Is it making sense? Thanks.
I see. No, it is a pointless optimisation that leaks knowledge about internals of another subsystem to paper over a kernel bug. -Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre