drm: allow DRM_IOCTL_VERSION on render-nodes
Subsystems (2)
PATCH 1/1 drm: allow DRM_IOCTL_VERSION on render-nodes
DRM_IOCTL_VERSION is a reliable way to get the driver-name and version information. It's not related to the interface-version (SET_VERSION ioctl) so we can safely enable it on render-nodes.
Note that gbm uses udev-BUSID to load the correct mesa driver. However, the VERSION ioctl should be the more reliable way to do this (in case we add new DRM-bus drivers which have no BUSID or similar).
--- drivers/gpu/drm/drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_drv.c +1 -1
@@ -61,7 +61,7 @@ static int drm_version(struct drm_device *dev, void *data,/** Ioctl table */ static const struct drm_ioctl_desc drm_ioctls[] = { -DRM_IOCTL_DEF (DRM_IOCTL_VERSION , drm_version,DRM_UNLOCKED ), +DRM_IOCTL_DEF (DRM_IOCTL_VERSION , drm_version,DRM_UNLOCKED |DRM_RENDER_ALLOW ),DRM_IOCTL_DEF (DRM_IOCTL_GET_UNIQUE , drm_getunique,0 ),DRM_IOCTL_DEF (DRM_IOCTL_GET_MAGIC , drm_getmagic,0 ),DRM_IOCTL_DEF (DRM_IOCTL_IRQ_BUSID , drm_irq_by_busid,DRM_MASTER |DRM_ROOT_ONLY ),
Signature · 1 line
1.8.4.1
Quoted 9 lines · David Herrmann
DRM_IOCTL_VERSIONis a reliable way to get the driver-name and version information. It's not related to the interface-version (SET_VERSIONioctl) so we can safely enable it on render-nodes.Note that gbm uses udev-BUSID to load the correct mesa driver. However, the VERSION ioctl should be the more reliable way to do this (in case we add new DRM-bus drivers which have no BUSID or similar).
Signed-off-by David Herrmann <[email protected]>
Quoted 24 lines
--- drivers/gpu/drm/drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_drv.c +1
-1@@ -61,7 +61,7 @@ static int drm_version(struct drm_device *dev, void *data,/** Ioctl table */ static const struct drm_ioctl_desc drm_ioctls[] = { -DRM_IOCTL_DEF (DRM_IOCTL_VERSION , drm_version,DRM_UNLOCKED ), +DRM_IOCTL_DEF (DRM_IOCTL_VERSION , drm_version,DRM_UNLOCKED |DRM_RENDER_ALLOW ),DRM_IOCTL_DEF (DRM_IOCTL_GET_UNIQUE , drm_getunique,0 ),DRM_IOCTL_DEF (DRM_IOCTL_GET_MAGIC , drm_getmagic,0 ),DRM_IOCTL_DEF (DRM_IOCTL_IRQ_BUSID , drm_irq_by_busid,DRM_MASTER |DRM_ROOT_ONLY ),Signature · 6 lines
1.8.4.1 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Hi Dave
That one should go into 3.13. I'd like to keep drm.rnodes=0 for one more release. OpenCL is reported to be working with this (thanks to Tom), OpenGL isn't working, yet as it relies on flink names. Patches are available to make OpenGL work on rnodes with mesa.
Cheers
David
Quoted 41 lines · Daniel Vetter
Quoted 9 lines · David Herrmann
DRM_IOCTL_VERSIONis a reliable way to get the driver-name and version information. It's not related to the interface-version (SET_VERSIONioctl) so we can safely enable it on render-nodes.Note that gbm uses udev-BUSID to load the correct mesa driver. However, the VERSION ioctl should be the more reliable way to do this (in case we add new DRM-bus drivers which have no BUSID or similar).
Signed-off-by David Herrmann <[email protected]>Reviewed-by Daniel Vetter <[email protected]>Quoted 20 lines
--- drivers/gpu/drm/drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_drv.c +1
-2@@ -61,7 +61,7 @@ static int drm_version(struct drm_device *dev, void *data,/** Ioctl table */ static const struct drm_ioctl_desc drm_ioctls[] = { -DRM_IOCTL_DEF (DRM_IOCTL_VERSION , drm_version,DRM_UNLOCKED ), +DRM_IOCTL_DEF (DRM_IOCTL_VERSION , drm_version,DRM_UNLOCKED |DRM_RENDER_ALLOW ),DRM_IOCTL_DEF (DRM_IOCTL_GET_UNIQUE , drm_getunique,0 ),DRM_IOCTL_DEF (DRM_IOCTL_GET_MAGIC , drm_getmagic,0 ),DRM_IOCTL_DEF (DRM_IOCTL_IRQ_BUSID , drm_irq_by_busid,DRM_MASTER |DRM_ROOT_ONLY ), --1.8.4.1
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch