gnome: set UNKNOWN_CONFIGURE_WHITELIST
PATCH 1/5 gnome: set UNKNOWN_CONFIGURE_WHITELIST
This class passes --disable-introspection to everything that inherits it but not all GNOME modules support introspection, so add that option to the unknown-configure-options sanity test whitelist.
--- meta/classes/gnome.bbclass | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
meta/classes/gnome.bbclass +3 -1
@@ -1,3 +1,5 @@ inherit gnomebase gtk-icon-cache gconf mime -EXTRA_OECONF += "--enable-introspection=no" +EXTRA_OECONF += "--disable-introspection" + +UNKNOWN_CONFIGURE_WHITELIST += "--disable-introspection"
Signature · 1 line
1.7.10.4
PATCH 2/5 xorg-lib-common: set UNKNOWN_CONFIGURE_WHITELIST
This include adds configure options globally but not all X libraries support them, so to avoid unknown-configure-option warnings add them to the whitelist.
--- meta/recipes-graphics/xorg-lib/xorg-lib-common.inc | 3 +++ 1 file changed, 3 insertions(+)
meta/recipes-graphics/xorg-lib/xorg-lib-common.inc +3 -0
@@ -17,6 +17,9 @@ EXTRA_OECONF = "--disable-specs --without-groff --without-ps2pdf --without-fop - EXTRA_OECONF_append_libc-glibc = " --disable-malloc0returnsnull" EXTRA_OECONF_append_libc-uclibc = " --enable-malloc0returnsnull" +UNKNOWN_CONFIGURE_WHITELIST += "--enable-malloc0returnsnull --disable-malloc0returnsnull \ + --disable-specs --without-groff --without-ps2pdf --without-fop --without-xmlto" + python () { whitelist = [ "pixman", "libpciaccess" ] if not d.getVar('BPN', True) in whitelist and not oe.utils.contains ('DISTRO_FEATURES', 'x11', True, False, d):
Signature · 1 line
1.7.10.4
PATCH 3/5 xorg-proto-common: set UNKNOWN_CONFIGURE_WHITELIST
In reply to Ross BurtonThis include adds configure options globally but not all X libraries support them, so to avoid unknown-configure-option warnings add them to the whitelist.
--- meta/recipes-graphics/xorg-proto/xorg-proto-common.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-graphics/xorg-proto/xorg-proto-common.inc +3 -1
@@ -14,7 +14,9 @@ S = "${WORKDIR}/${XORG_PN}-${PV}" DEPENDS = "util-macros" inherit autotools pkgconfig -EXTRA_OECONF = "--with-fop=no --without-xmlto" +EXTRA_OECONF = "--without-fop --without-xmlto" + +UNKNOWN_CONFIGURE_WHITELIST += "--without-fop --without-xmlto" # ${PN} is empty so we need to tweak -dev and -dbg package dependencies RDEPENDS_${PN}-dev = ""
Signature · 1 line
1.7.10.4
Re: [PATCH 3/5] xorg-proto-common: set UNKNOWN_CONFIGURE_WHITELIST
Quoted 4 lines · Ross Burton
This include adds configure options globally but not all X libraries support them, so to avoid unknown-configure-option warnings add them to the whitelist.
Signed-off-by Ross Burton <[email protected]>
Does not match with the commit log.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
PATCH 4/5 gnome-common: inhert gnomebase not gnome
In reply to Ross BurtonThis recipe doesn't need any of the helpers that come with gnome (GConf, icons, MIME, etc), so just inherit gnomebase.
--- meta/recipes-gnome/gnome/gnome-common_3.7.4.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-gnome/gnome/gnome-common_3.7.4.bb +1 -1
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" SECTION = "x11/gnome" PR = "r0" -inherit gnome allarch +inherit gnomebase allarch GNOME_COMPRESS_TYPE = "xz"
Signature · 1 line
1.7.10.4
PATCH 5/5 libgcrypt: remove --without-pth
In reply to Ross BurtonThis isn't recognised by configure, and the random number daemon that requires Pth isn't enabled.
--- meta/recipes-support/libgcrypt/libgcrypt.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/libgcrypt/libgcrypt.inc +1 -1
@@ -15,7 +15,7 @@ SRC_URI = "ftp://ftp.gnupg.org/gcrypt/libgcrypt/libgcrypt-${PV}.tar.gz \ inherit autotools binconfig pkgconfig -EXTRA_OECONF = "--without-pth --disable-asm --with-capabilities" +EXTRA_OECONF = "--disable-asm --with-capabilities" # libgcrypt.pc is added locally and thus installed here do_install_append() {
Signature · 1 line
1.7.10.4
Re: [PATCH 5/5] libgcrypt: remove --without-pth
Quoted 13 lines · Ross Burton
This isn't recognised by configure, and the random number daemon that requires Pth isn't enabled.
Signed-off-by Ross Burton <[email protected]>--- meta/recipes-support/libgcrypt/libgcrypt.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-support/libgcrypt/libgcrypt.inc +0
-0
meta/recipes-support/libgcrypt/libgcrypt.inc SRC_URI = "ftp://ftp.gnupg.org/gcrypt/libgcrypt/libgcrypt-${PV}.tar.gz \ · line 18
Quoted 5 lines
meta/recipes-support/libgcrypt/libgcrypt.inc +1
-1@@ -15,7 +15,7 @@ SRC_URI = "ftp://ftp.gnupg.org/gcrypt/libgcrypt/libgcrypt-${PV}.tar.gz \ inherit autotools binconfig pkgconfig -EXTRA_OECONF = "--without-pth --disable-asm --with-capabilities" +EXTRA_OECONF = "--disable-asm --with-capabilities"
should it now depend on pth as well for deterministic builds.
Quoted 10 lines
meta/recipes-support/libgcrypt/libgcrypt.inc +0
-1# libgcrypt.pc is added locally and thus installed here do_install_append() { --1.7.10.4
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [PATCH 5/5] libgcrypt: remove --without-pth
Quoted 1 line · Khem Raj
should it now depend on pth as well for deterministic builds.
No, because the random daemon (the only piece that needs Pth) is disabled by default.
Ross
Quoted 5 lines · Ross Burton
This class passes --disable-introspection to everything that inherits it but not all GNOME modules support introspection, so add that option to the unknown-configure-options sanity test whitelist.
Signed-off-by Ross Burton <[email protected]>
I understand the change but it does not match with the commit log.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Quoted 8 lines · Otavio Salvador
Quoted 5 lines · Ross Burton
This class passes --disable-introspection to everything that inherits it but not all GNOME modules support introspection, so add that option to the unknown-configure-options sanity test whitelist.
Signed-off-by Ross Burton <[email protected]>I understand the change but it does not match with the commit log.
How so?
-EXTRA_OECONF += "--enable-introspection=no"
+EXTRA_OECONF += "--disable-introspection"
This is a semantically identical change as far as autoconf is concerned, that makes the whitelist clearer.
+UNKNOWN_CONFIGURE_WHITELIST += "--disable-introspection"
This is the unknown configure options whitelist.
Ross
Quoted 15 lines · Ross
Quoted 8 lines · Otavio Salvador
Quoted 5 lines · Ross Burton
This class passes --disable-introspection to everything that inherits it but not all GNOME modules support introspection, so add that option to the unknown-configure-options sanity test whitelist.
Signed-off-by Ross Burton <[email protected]>I understand the change but it does not match with the commit log.
How so?
meta/classes/gnome.bbclass +1
-1-EXTRA_OECONF += "--enable-introspection=no" +EXTRA_OECONF += "--disable-introspection"
Quoted 2 lines
This is a semantically identical change as far as autoconf is concerned, that makes the whitelist clearer.
For autoconf it is but for a human it is not. Please add this to the commit log.
Quoted 5 lines
+UNKNOWN_CONFIGURE_WHITELIST += "--disable-introspection"
This is the unknown configure options whitelist.
Ross
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750