pc: disable pci-info
PATCH 1/1 pc: disable pci-info
The BIOS that we ship in 1.7 does not use pci info from host and so far isn't going to use it.
Taking in account problems it caused see 9604f70fdf and to avoid future incompatibility issues, it's safest to disable that interface by default for all machine types including 1.7 as it was never exposed/used by guest. And properly remove/cleanup it during 1.8 development cycle.
--- hw/i386/pc_piix.c | 3 ++- hw/i386/pc_q35.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)
hw/i386/pc_piix.c +2 -1
@@ -58,7 +58,8 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 };static const int ide_irq[MAX_IDE_BUS ] = {14 ,15 };static bool has_pvpanic; -static bool has_pci_info = true; +/* TODO: remove unused "etc/pci-info" */ +static bool has_pci_info;/* PC hardware initialisation */ static void pc_init1(QEMUMachineInitArgs *args,
hw/i386/pc_q35.c +2 -1
@@ -48,7 +48,8 @@#define MAX_SATA_PORTS 6static bool has_pvpanic; -static bool has_pci_info = true; +/* TODO: remove unused "etc/pci-info" */ +static bool has_pci_info;/* PC hardware initialisation */ static void pc_q35_init (QEMUMachineInitArgs *args)
Signature · 1 line
1.7.1
Quoted 7 lines · Igor Mammedov
The BIOS that we ship in 1.7 does not use pci info from host and so far isn't going to use it.
Taking in account problems it caused see9604f70fdfand to avoid future incompatibility issues, it's safest to disable that interface by default for all machine types including 1.7 as it was never exposed/used by guest. And properly remove/cleanup it during 1.8 development cycle.
cheers,
Gerd
Quoted 9 lines · Igor Mammedov
The BIOS that we ship in 1.7 does not use pci info from host and so far isn't going to use it.
Taking in account problems it caused see9604f70fdfand to avoid future incompatibility issues, it's safest to disable that interface by default for all machine types including 1.7 as it was never exposed/used by guest. And properly remove/cleanup it during 1.8 development cycle.Signed-off-by Igor Mammedov <[email protected]>
Quoted 35 lines
--- hw/i386/pc_piix.c | 3 ++- hw/i386/pc_q35.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)hw/i386/pc_piix.c +2
-1@@ -58,7 +58,8 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 };static const int ide_irq[MAX_IDE_BUS ] = {14 ,15 };static bool has_pvpanic; -static bool has_pci_info = true; +/* TODO: remove unused "etc/pci-info" */ +static bool has_pci_info;/* PC hardware initialisation */ static void pc_init1(QEMUMachineInitArgs *args,hw/i386/pc_q35.c +2
-1@@ -48,7 +48,8 @@#define MAX_SATA_PORTS 6static bool has_pvpanic; -static bool has_pci_info = true; +/* TODO: remove unused "etc/pci-info" */ +static bool has_pci_info;/* PC hardware initialisation */ static void pc_q35_init (QEMUMachineInitArgs *args)Signature · 1 line
1.7.1
Quoted 9 lines · Igor Mammedov
The BIOS that we ship in 1.7 does not use pci info from host and so far isn't going to use it.
Taking in account problems it caused see9604f70fdfand to avoid future incompatibility issues, it's safest to disable that interface by default for all machine types including 1.7 as it was never exposed/used by guest. And properly remove/cleanup it during 1.8 development cycle.Signed-off-by Igor Mammedov <[email protected]>
Signature · 1 line
Eduardo
Quoted 7 lines · On Tue, 29 Oct 2013 15:35:07 +0100 Igor Mammedov <[email protected]> wrote:
The BIOS that we ship in 1.7 does not use pci info from host and so far isn't going to use it.
Taking in account problems it caused see9604f70fdfand to avoid future incompatibility issues, it's safest to disable that interface by default for all machine types including 1.7 as it was never exposed/used by guest. And properly remove/cleanup it during 1.8 development cycle.
ping,
we want it for 1.7 to avoid compatibility issues.
Quoted 11 lines · Igor Mammedov
Quoted 7 lines · On Tue, 29 Oct 2013 15:35:07 +0100 Igor Mammedov <[email protected]> wrote:
The BIOS that we ship in 1.7 does not use pci info from host and so far isn't going to use it.
Taking in account problems it caused see9604f70fdfand to avoid future incompatibility issues, it's safest to disable that interface by default for all machine types including 1.7 as it was never exposed/used by guest. And properly remove/cleanup it during 1.8 development cycle.
Quoted 2 lines
ping,
we want it for 1.7 to avoid compatibility issues.
Yes we do.
Can you rebase and resubmit please?