nfs: fix inverted test for delegation in nfs4_reclaim_open_state
Subsystems (2)
PATCH 1/1 nfs: fix inverted test for delegation in nfs4_reclaim_open_state
commit 6686390bab6a0e0 (NFS: remove incorrect "Lock reclaim failed!" warning.) added a test for a delegation before checking to see if any reclaimed locks failed. The test however is backward and is only doing that check when a delegation is held instead of when one isn't.
Cc NeilBrown <[email protected]>
Signed-off-by Jeff Layton <[email protected]>
--- fs/nfs/nfs4state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/nfs4state.c +1 -1
@@ -1476,7 +1476,7 @@ restart:if (status >=0 ) { status =nfs4_reclaim_locks (state, ops);if (status >=0 ) { -if (test_bit (NFS_DELEGATED_STATE , &state->flags) !=0 ) { +if (!test_bit (NFS_DELEGATED_STATE , &state->flags)) {spin_lock (&state->state_lock);list_for_each_entry (lock, &state->lock_states, ls_locks) {if (!test_bit (NFS_LOCK_INITIALIZED , &lock->ls_flags))
Signature · 1 line
1.8.3.1