Skip to contentSkip to conversation

qxl: avoid an oops in the deferred io code.

PATCH New Dave Airlie 1 participant 1 message Nov 4, 2013

Subsystems (3)
lore
Share & tools
lore

Dave Airlie

author maintainer
#0 lore raw

PATCH 1/1 qxl: avoid an oops in the deferred io code.

From: Dave Airlie <[email protected]>

If we are using deferred io due to plymouth or X.org fbdev driver we will oops in memcpy due to this pointless multiply here,

removing it fixes fbdev to start and not oops.

---
 drivers/gpu/drm/qxl/qxl_fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/qxl/qxl_fb.c +1 -1
index 88722f2..f437b30 100644
@@ -108,7 +108,7 @@ static void qxl_fb_dirty_flush(struct fb_info *info)
 	u32 x1, x2, y1, y2;
 
 	/* TODO: hard coding 32 bpp */
-	int stride = qfbdev->qfb.base.pitches[0] * 4;
+	int stride = qfbdev->qfb.base.pitches[0];
 
 	x1 = qfbdev->dirty.x1;
 	x2 = qfbdev->dirty.x2;
Signature · 1 line
1.8.3.1