lib/oe/sstatesig: Ensure packagegroups don't continually rebuild
packagegroups are allarch and shouldn't change depending on the target or machine selected. In general they should have good stable namespaces for their dependencies. As such we can exclude them from rebuilding when dependency checksums change.
---
meta/lib/oe/sstatesig.py +7 -0
@@ -11,6 +11,9 @@ def sstate_rundepfilter(siggen, fn, recipename, task, dep, depname, dataCache): def isKernel(fn): inherits = " ".join(dataCache.inherits[fn]) return inherits.find("module-base.bbclass") != -1 or inherits.find("linux-kernel-base.bbclass") != -1 + def isPackageGroup(fn): + inherits = " ".join(dataCache.inherits[fn]) + return "packagegroup.bbclass" in inherits # Always include our own inter-task dependencies if recipename == depname:
@@ -27,6 +30,10 @@ def sstate_rundepfilter(siggen, fn, recipename, task, dep, depname, dataCache): # Only target packages beyond here + # packagegroups are assumed to have well behaved names which don't change between architecures/tunes + if isPackageGroup(fn): + return False + # Drop native/cross/nativesdk dependencies from target recipes if isNative(depname) or isCross(depname) or isNativeSDK(depname): return False
Quoted 6 lines · Richard Purdie
packagegroups are allarch and shouldn't change depending on the target or machine selected. In general they should have good stable namespaces for their dependencies. As such we can exclude them from rebuilding when dependency checksums change.
Signed-off-by Richard Purdie <[email protected]>
What about machine-base and core-boot? this may change depending on machine.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Quoted 10 lines · Otavio Salvador
Quoted 6 lines · Richard Purdie
packagegroups are allarch and shouldn't change depending on the target or machine selected. In general they should have good stable namespaces for their dependencies. As such we can exclude them from rebuilding when dependency checksums change.
Signed-off-by Richard Purdie <[email protected]>What about machine-base and core-boot? this may change depending on machine.
Those already get marked as machine specific. I'd not expect dependencies to be changing package names there for example so I'm not sure this is an issue.
Cheers,
Richard
Quoted 8 lines · Richard Purdie
Quoted 7 lines · Otavio Salvador
Quoted 5 lines · Richard Purdie
packagegroups are allarch and shouldn't change depending on the target or machine selected. In general they should have good stable namespaces for their dependencies. As such we can exclude them from rebuilding when dependency checksums change.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Richard Purdie <[email protected]>What about machine-base and core-boot? this may change depending on machine.
Those already get marked as machine specific. I'd not expect dependencies to be changing package names there for example so I'm not sure this is an issue.
In:
+ def isPackageGroup(fn):
+ inherits = " ".join(dataCache.inherits[fn])
+ return "packagegroup.bbclass" in inherits
We must check PACKAGE_ARCH, no?
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Quoted 24 lines · Otavio Salvador
Quoted 8 lines · Richard Purdie
Quoted 7 lines · Otavio Salvador
Quoted 5 lines · Richard Purdie
packagegroups are allarch and shouldn't change depending on the target or machine selected. In general they should have good stable namespaces for their dependencies. As such we can exclude them from rebuilding when dependency checksums change.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Richard Purdie <[email protected]>What about machine-base and core-boot? this may change depending on machine.
Those already get marked as machine specific. I'd not expect dependencies to be changing package names there for example so I'm not sure this is an issue.
In:
meta/lib/oe/sstatesig.py +3
-0+ def isPackageGroup(fn): + inherits = " ".join(dataCache.inherits[fn]) + return "packagegroup.bbclass" in inherits
Quoted 1 line
We must check
PACKAGE_ARCH, no?
No. The fact they're marked as MACHINE_ARCH ensures they change when they need to, we don't need sstate to do that as well.
Cheers,
Richard
Quoted 21 lines · Richard Purdie
Quoted 20 lines · Otavio Salvador
Quoted 8 lines · Richard Purdie
Quoted 7 lines · Otavio Salvador
Quoted 5 lines · Richard Purdie
packagegroups are allarch and shouldn't change depending on the target or machine selected. In general they should have good stable namespaces for their dependencies. As such we can exclude them from rebuilding when dependency checksums change.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Richard Purdie <[email protected]>What about machine-base and core-boot? this may change depending on machine.
Those already get marked as machine specific. I'd not expect dependencies to be changing package names there for example so I'm not sure this is an issue.
In:
Quoted 8 lines
Quoted 5 lines
meta/lib/oe/sstatesig.py +3
-0+ def isPackageGroup(fn): + inherits = " ".join(dataCache.inherits[fn]) + return "packagegroup.bbclass" in inheritsWe must check
PACKAGE_ARCH, no?No. The fact they're marked as
MACHINE_ARCHensures they change when they need to, we don't need sstate to do that as well.
Fine :)
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750