Skip to contentSkip to conversation

PCI: mvebu: staticize mvebu_pcie_align_resource

PATCH In review Jisheng Zhang 2 participants 2 messages Nov 7, 2013 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: mvebu: staticize mvebu_pcie_align_resource

This patch fixes the following sparse warning:
drivers/pci/host/pci-mvebu.c:676:17: warning: symbol 'mvebu_pcie_align_resource' was not declared. Should it be static?

---
 drivers/pci/host/pci-mvebu.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/pci/host/pci-mvebu.c +5 -5
index 729d5a1..bf4ff23 100644
@@ -673,11 +673,11 @@ static struct pci_bus *mvebu_pcie_scan_bus(int nr, struct pci_sys_data *sys)
 	return bus;
 }
 
-resource_size_t mvebu_pcie_align_resource(struct pci_dev *dev,
-					  const struct resource *res,
-					  resource_size_t start,
-					  resource_size_t size,
-					  resource_size_t align)
+static resource_size_t mvebu_pcie_align_resource(struct pci_dev *dev,
+						 const struct resource *res,
+						 resource_size_t start,
+						 resource_size_t size,
+						 resource_size_t align)
 {
 	if (dev->bus->number != 0)
 		return start;
Signature · 1 line
1.8.4.2
#1 lore raw

Dear Jisheng Zhang,

Quoted 5 lines · Jisheng Zhang

This patch fixes the following sparse warning:
drivers/pci/host/pci-mvebu.c:676:17: warning: symbol 'mvebu_pcie_align_resource' was not declared. Should it be static?

Thanks, but a similar patch was already merged:

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/pci/host/pci-mvebu.c?id=f5072dfbac053200c8865c4fb15e4f020b7b5d1d

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com