Adding the nfs4_use_min_auth module parameter
Subsystems (2)
PATCH 1/1 Adding the nfs4_use_min_auth module parameter
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookup
--- fs/nfs/nfs4_fs.h | 1 + fs/nfs/nfs4client.c | 8 ++++++-- fs/nfs/nfs4proc.c | 4 +++- fs/nfs/super.c | 6 +++++- 4 files changed, 15 insertions(+), 4 deletions(-)
fs/nfs/nfs4_fs.h +1 -0
@@ -438,6 +438,7 @@ extern bool nfs4_disable_idmapping;extern unsigned short max_session_slots;extern unsigned short send_implementation_id;extern bool recover_lost_locks; +extern bool nfs4_use_min_auth;#define NFS4_CLIENT_ID_UNIQ_LEN (64)extern char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ];
fs/nfs/nfs4client.c +6 -2
@@ -355,6 +355,7 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,char buf[INET6_ADDRSTRLEN +1 ];struct nfs_client *old;int error; +rpc_authflavor_t flavor =RPC_AUTH_GSS_KRB5I ;if (clp->cl_cons_state ==NFS_CS_READY ) {/* the client is initialised already */
@@ -368,8 +369,11 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,if (clp->cl_minorversion !=0 )__set_bit (NFS_CS_INFINITE_SLOTS , &clp->cl_flags);__set_bit (NFS_CS_DISCRTRY , &clp->cl_flags); - error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_GSS_KRB5I ); -if (error == -EINVAL ) + +if (nfs4_use_min_auth) + flavor =RPC_AUTH_UNIX ; + error =nfs_create_rpc_client (clp, timeparms, flavor); +if (error == -EINVAL && flavor !=RPC_AUTH_UNIX ) error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_UNIX );if (error <0 ) goto error;
fs/nfs/nfs4proc.c +3 -1
@@ -2864,7 +2864,9 @@ static int nfs4_find_root_sec(struct nfs_server *server, struct nfs_fh *fhandle,int status = -EPERM ;size_t i; -for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { +if (nfs4_use_min_auth) + status =nfs4_lookup_root_sec (server, fhandle, info,RPC_AUTH_UNIX ); +else for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { status =nfs4_lookup_root_sec (server, fhandle, info, flav_array[i]);if (status == -NFS4ERR_WRONGSEC || status == -EACCES )continue ;
fs/nfs/super.c +5 -1
@@ -2791,6 +2791,7 @@ unsigned short max_session_slots = NFS4_DEF_SLOT_TABLE_SIZE;unsigned short send_implementation_id =1 ;char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ] ="" ;bool recover_lost_locks = false; +bool nfs4_use_min_auth = false;EXPORT_SYMBOL_GPL (nfs_callback_set_tcpport);EXPORT_SYMBOL_GPL (nfs_callback_tcpport);
@@ -2800,6 +2801,7 @@ EXPORT_SYMBOL_GPL(max_session_slots);EXPORT_SYMBOL_GPL (send_implementation_id);EXPORT_SYMBOL_GPL (nfs4_client_id_uniquifier);EXPORT_SYMBOL_GPL (recover_lost_locks); +EXPORT_SYMBOL_GPL (nfs4_use_min_auth);#define NFS_CALLBACK_MAXPORTNR (65535U)
@@ -2842,5 +2844,7 @@ MODULE_PARM_DESC(recover_lost_locks,"If the server reports that a lock might be lost, " "try to recover it risking data corruption."); - +module_param (nfs4_use_min_auth, bool,0644 ); +MODULE_PARM_DESC (nfs4_use_min_auth, +"Use mimnal auth in SETCLIENTID operation" );#endif /* CONFIG_NFS_V4 */
Signature · 1 line
1.7.1
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookup
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout? Have we completely given up on fixing the upcall?
Quoted 97 lines
Signed-off-by Steve Dickson <[email protected]>---
fs/nfs/nfs4_fs.h | 1 + fs/nfs/nfs4client.c | 8 ++++++-- fs/nfs/nfs4proc.c | 4 +++- fs/nfs/super.c | 6 +++++- 4 files changed, 15 insertions(+), 4 deletions(-)fs/nfs/nfs4_fs.h +1
-0@@ -438,6 +438,7 @@ extern bool nfs4_disable_idmapping;extern unsigned short max_session_slots;extern unsigned short send_implementation_id;extern bool recover_lost_locks; +extern bool nfs4_use_min_auth;#define NFS4_CLIENT_ID_UNIQ_LEN (64)extern char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ];fs/nfs/nfs4client.c +6
-2@@ -355,6 +355,7 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,char buf[INET6_ADDRSTRLEN +1 ];struct nfs_client *old;int error; +rpc_authflavor_t flavor =RPC_AUTH_GSS_KRB5I ;if (clp->cl_cons_state ==NFS_CS_READY ) {/* the client is initialised already */ @@ -368,8 +369,11 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,if (clp->cl_minorversion !=0 )__set_bit (NFS_CS_INFINITE_SLOTS , &clp->cl_flags);__set_bit (NFS_CS_DISCRTRY , &clp->cl_flags); - error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_GSS_KRB5I ); -if (error == -EINVAL ) + +if (nfs4_use_min_auth) + flavor =RPC_AUTH_UNIX ; + error =nfs_create_rpc_client (clp, timeparms, flavor); +if (error == -EINVAL && flavor !=RPC_AUTH_UNIX ) error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_UNIX );if (error <0 ) goto error;fs/nfs/nfs4proc.c +3
-1@@ -2864,7 +2864,9 @@ static int nfs4_find_root_sec(struct nfs_server *server, struct nfs_fh *fhandle,int status = -EPERM ;size_t i; -for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { +if (nfs4_use_min_auth) + status =nfs4_lookup_root_sec (server, fhandle, info,RPC_AUTH_UNIX ); +else for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { status =nfs4_lookup_root_sec (server, fhandle, info, flav_array[i]);if (status == -NFS4ERR_WRONGSEC || status == -EACCES )continue ;fs/nfs/super.c +5
-1@@ -2791,6 +2791,7 @@ unsigned short max_session_slots = NFS4_DEF_SLOT_TABLE_SIZE;unsigned short send_implementation_id =1 ;char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ] ="" ;bool recover_lost_locks = false; +bool nfs4_use_min_auth = false;EXPORT_SYMBOL_GPL (nfs_callback_set_tcpport);EXPORT_SYMBOL_GPL (nfs_callback_tcpport);@@ -2800,6 +2801,7 @@ EXPORT_SYMBOL_GPL(max_session_slots);EXPORT_SYMBOL_GPL (send_implementation_id);EXPORT_SYMBOL_GPL (nfs4_client_id_uniquifier);EXPORT_SYMBOL_GPL (recover_lost_locks); +EXPORT_SYMBOL_GPL (nfs4_use_min_auth);#define NFS_CALLBACK_MAXPORTNR (65535U)@@ -2842,5 +2844,7 @@ MODULE_PARM_DESC(recover_lost_locks,"If the server reports that a lock might be lost, " "try to recover it risking data corruption."); - +module_param (nfs4_use_min_auth, bool,0644 ); +MODULE_PARM_DESC (nfs4_use_min_auth, +"Use mimnal auth in SETCLIENTID operation" );#endif /* CONFIG_NFS_V4 */ Signature · 6 lines
1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 11 lines · On Thu, 7 Nov 2013 11:25:19 -0800 Chuck Lever <[email protected]> wrote:
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupThe patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout? Have we completely given up on fixing the upcall?
That would be my preferred solution too. The whole problem is that this upcall takes too damned long to time out.
But...how can it be fixed?
Due to the way that rpc_pipefs interface works, there's no way that I can see to make that fail immediately if no one is listening on the pipe. You could reduce the timeout I guess but that's sort of a half-assed solution.
IMO, we're long past due for a new upcall that uses a different design altogether. Maybe something based on call_usermodehelper that doesn't require a running daemon?
Signature · 1 line
Jeff Layton <[email protected]>
Quoted 20 lines · Jeff Layton
Quoted 11 lines · On Thu, 7 Nov 2013 11:25:19 -0800 Chuck Lever <[email protected]> wrote:
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupThe patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout? Have we completely given up on fixing the upcall?
That would be my preferred solution too. The whole problem is that this upcall takes too damned long to time out.
But...how can it be fixed?
Quoted 8 lines
Due to the way that
rpc_pipefsinterface works, there's no way that I can see to make that fail immediately if no one is listening on the pipe. You could reduce the timeout I guess but that's sort of a half-assed solution.IMO, we're long past due for a new upcall that uses a different design altogether. Maybe something based on
call_usermodehelperthat doesn't require a running daemon?
Bingo! I think it would be huge for all these upcalls to work like the idmapping does on the client (aka via call_usermodehelper)... but which the likes of Kerberos it may not be possible...
steved.
Quoted 1 line
Quoted 28 lines · On Thu, 07 Nov 2013 16:40:18 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Jeff Layton
Quoted 11 lines · On Thu, 7 Nov 2013 11:25:19 -0800 Chuck Lever <[email protected]> wrote:
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupThe patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout? Have we completely given up on fixing the upcall?
That would be my preferred solution too. The whole problem is that this upcall takes too damned long to time out.
But...how can it be fixed?
Due to the way that
rpc_pipefsinterface works, there's no way that I can see to make that fail immediately if no one is listening on the pipe. You could reduce the timeout I guess but that's sort of a half-assed solution.
Quoted 7 lines
Quoted 3 lines
IMO, we're long past due for a new upcall that uses a different design altogether. Maybe something based on
call_usermodehelperthat doesn't require a running daemon?Bingo! I think it would be huge for all these upcalls to work like the idmapping does on the client (aka via
call_usermodehelper)... but which the likes of Kerberos it may not be possible...
No, it's possible.
We don't currently handle multi-stage GSSAPI negotiation across the kernel/userland boundary anyway, so there's no problem with state preservation across upcalls or anything.
The tricky part is how to handle the downcall. call_usermodehelper doesn't have a way to pass anything but a return code back to the kernel, so you'd need to send the context handle and such via another mechanism.
Hmm...and containers too. The UMH infrastructure is not container-aware, whereas rpc_pipefs is. I guess you could make the program use setns(), but you have to come up with some way to pass a fd to it.
Either way, not a trivial task. It'd be best to get everyone on board with the design before trying to do the work.
Signature · 1 line
Jeff Layton <[email protected]>
Hey mrchuck...
Quoted 11 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupThe patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO.. Also running a security daemon for non-secure mounts just seems wrong to me.
Quoted 1 line
Have we completely given up on fixing the upcall?
Back when we were looking on to introduce gss-proxy into the client, it was decided the upcall on the client was not going to change. I'm just going with that!
steved.
Quoted 106 lines
Quoted 99 lines
Signed-off-by Steve Dickson <[email protected]>---
fs/nfs/nfs4_fs.h | 1 + fs/nfs/nfs4client.c | 8 ++++++-- fs/nfs/nfs4proc.c | 4 +++- fs/nfs/super.c | 6 +++++- 4 files changed, 15 insertions(+), 4 deletions(-)fs/nfs/nfs4_fs.h +1
-0@@ -438,6 +438,7 @@ extern bool nfs4_disable_idmapping;extern unsigned short max_session_slots;extern unsigned short send_implementation_id;extern bool recover_lost_locks; +extern bool nfs4_use_min_auth;#define NFS4_CLIENT_ID_UNIQ_LEN (64)extern char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ];fs/nfs/nfs4client.c +6
-2@@ -355,6 +355,7 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,char buf[INET6_ADDRSTRLEN +1 ];struct nfs_client *old;int error; +rpc_authflavor_t flavor =RPC_AUTH_GSS_KRB5I ;if (clp->cl_cons_state ==NFS_CS_READY ) {/* the client is initialised already */ @@ -368,8 +369,11 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,if (clp->cl_minorversion !=0 )__set_bit (NFS_CS_INFINITE_SLOTS , &clp->cl_flags);__set_bit (NFS_CS_DISCRTRY , &clp->cl_flags); - error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_GSS_KRB5I ); -if (error == -EINVAL ) + +if (nfs4_use_min_auth) + flavor =RPC_AUTH_UNIX ; + error =nfs_create_rpc_client (clp, timeparms, flavor); +if (error == -EINVAL && flavor !=RPC_AUTH_UNIX ) error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_UNIX );if (error <0 ) goto error;fs/nfs/nfs4proc.c +3
-1@@ -2864,7 +2864,9 @@ static int nfs4_find_root_sec(struct nfs_server *server, struct nfs_fh *fhandle,int status = -EPERM ;size_t i; -for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { +if (nfs4_use_min_auth) + status =nfs4_lookup_root_sec (server, fhandle, info,RPC_AUTH_UNIX ); +else for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { status =nfs4_lookup_root_sec (server, fhandle, info, flav_array[i]);if (status == -NFS4ERR_WRONGSEC || status == -EACCES )continue ;fs/nfs/super.c +5
-1@@ -2791,6 +2791,7 @@ unsigned short max_session_slots = NFS4_DEF_SLOT_TABLE_SIZE;unsigned short send_implementation_id =1 ;char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ] ="" ;bool recover_lost_locks = false; +bool nfs4_use_min_auth = false;EXPORT_SYMBOL_GPL (nfs_callback_set_tcpport);EXPORT_SYMBOL_GPL (nfs_callback_tcpport);@@ -2800,6 +2801,7 @@ EXPORT_SYMBOL_GPL(max_session_slots);EXPORT_SYMBOL_GPL (send_implementation_id);EXPORT_SYMBOL_GPL (nfs4_client_id_uniquifier);EXPORT_SYMBOL_GPL (recover_lost_locks); +EXPORT_SYMBOL_GPL (nfs4_use_min_auth);#define NFS_CALLBACK_MAXPORTNR (65535U)@@ -2842,5 +2844,7 @@ MODULE_PARM_DESC(recover_lost_locks,"If the server reports that a lock might be lost, " "try to recover it risking data corruption."); - +module_param (nfs4_use_min_auth, bool,0644 ); +MODULE_PARM_DESC (nfs4_use_min_auth, +"Use mimnal auth in SETCLIENTID operation" );#endif /* CONFIG_NFS_V4 */ Signature · 6 lines
1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookup
Quoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
Quoted 2 lines
Also running
a security daemon for non-secure mounts just seems wrong to me.
It seems wrong to me to keep auth_rpcgss loaded if no mounts use Kerberos security. What's the difference between that and running gssd all the time?
The new SETCLIENTID architecture would be transparent if our security infrastructure was reliable. We really need to address the upcall issue. We've been working around it for a very long time.
Quoted 5 lines
Quoted 2 lines
Have we completely given up on fixing the upcall?
Back when we were looking on to introduce gss-proxy into the client, it was decided the upcall on the client was not going to change. I'm just going with that!
I don't remember that discussion. Or if it occurred, I didn't realize at the time that it was referring to fixing bugs. Do you have a link to the thread?
Quoted 109 lines
steved.
Quoted 95 lines
Quoted 95 lines
Signed-off-by Steve Dickson <[email protected]>---
fs/nfs/nfs4_fs.h | 1 + fs/nfs/nfs4client.c | 8 ++++++-- fs/nfs/nfs4proc.c | 4 +++- fs/nfs/super.c | 6 +++++- 4 files changed, 15 insertions(+), 4 deletions(-)fs/nfs/nfs4_fs.h +1
-0@@ -438,6 +438,7 @@ extern bool nfs4_disable_idmapping;extern unsigned short max_session_slots;extern unsigned short send_implementation_id;extern bool recover_lost_locks; +extern bool nfs4_use_min_auth;#define NFS4_CLIENT_ID_UNIQ_LEN (64)extern char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ];fs/nfs/nfs4client.c +6
-2@@ -355,6 +355,7 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,char buf[INET6_ADDRSTRLEN +1 ];struct nfs_client *old;int error; +rpc_authflavor_t flavor =RPC_AUTH_GSS_KRB5I ;if (clp->cl_cons_state ==NFS_CS_READY ) {/* the client is initialised already */ @@ -368,8 +369,11 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,if (clp->cl_minorversion !=0 )__set_bit (NFS_CS_INFINITE_SLOTS , &clp->cl_flags);__set_bit (NFS_CS_DISCRTRY , &clp->cl_flags); - error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_GSS_KRB5I ); -if (error == -EINVAL ) + +if (nfs4_use_min_auth) + flavor =RPC_AUTH_UNIX ; + error =nfs_create_rpc_client (clp, timeparms, flavor); +if (error == -EINVAL && flavor !=RPC_AUTH_UNIX ) error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_UNIX );if (error <0 ) goto error;fs/nfs/nfs4proc.c +3
-1@@ -2864,7 +2864,9 @@ static int nfs4_find_root_sec(struct nfs_server *server, struct nfs_fh *fhandle,int status = -EPERM ;size_t i; -for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { +if (nfs4_use_min_auth) + status =nfs4_lookup_root_sec (server, fhandle, info,RPC_AUTH_UNIX ); +else for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { status =nfs4_lookup_root_sec (server, fhandle, info, flav_array[i]);if (status == -NFS4ERR_WRONGSEC || status == -EACCES )continue ;fs/nfs/super.c +5
-1@@ -2791,6 +2791,7 @@ unsigned short max_session_slots = NFS4_DEF_SLOT_TABLE_SIZE;unsigned short send_implementation_id =1 ;char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ] ="" ;bool recover_lost_locks = false; +bool nfs4_use_min_auth = false;EXPORT_SYMBOL_GPL (nfs_callback_set_tcpport);EXPORT_SYMBOL_GPL (nfs_callback_tcpport);@@ -2800,6 +2801,7 @@ EXPORT_SYMBOL_GPL(max_session_slots);EXPORT_SYMBOL_GPL (send_implementation_id);EXPORT_SYMBOL_GPL (nfs4_client_id_uniquifier);EXPORT_SYMBOL_GPL (recover_lost_locks); +EXPORT_SYMBOL_GPL (nfs4_use_min_auth);#define NFS_CALLBACK_MAXPORTNR (65535U)@@ -2842,5 +2844,7 @@ MODULE_PARM_DESC(recover_lost_locks,"If the server reports that a lock might be lost, " "try to recover it risking data corruption."); - +module_param (nfs4_use_min_auth, bool,0644 ); +MODULE_PARM_DESC (nfs4_use_min_auth, +"Use mimnal auth in SETCLIENTID operation" );#endif /* CONFIG_NFS_V4 */ Signature · 1 line
1.7.1Quoted 11 lines
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 20 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
Quoted 7 lines
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 6 lines
Quoted 3 lines
Also running
a security daemon for non-secure mounts just seems wrong to me.It seems wrong to me to keep
auth_rpcgssloaded if no mounts use Kerberos security. What's the difference between that and running gssd all the time?
You can say thing about %99 of all the modules load in a Fedora kernel today. lsmod | wc -l show there is 107 modules load on a f19 system. Do you think all those modules are used? Of course not, but they are not spewing 25 log messages per mount or sucking up CPU cycles unnecessarily.
Quoted 4 lines
The new SETCLIENTID architecture would be transparent if our security infrastructure was reliable. We really need to address the upcall issue. We've been working around it for a very long time.
But its not transparent at this point. So we need a way to disable it until it comes transparent. That is what this module parameter does.
Quoted 10 lines
Quoted 6 lines
Quoted 3 lines
Have we completely given up on fixing the upcall?
Back when we were looking on to introduce gss-proxy into the client, it was decided the upcall on the client was not going to change. I'm just going with that!
I don't remember that discussion. Or if it occurred, I didn't realize at the time that it was referring to fixing bugs. Do you have a link to the thread?
It was when we were discussing how to use gss-proxy. If I remember correctly it was a verbal discussion...
steved.
Quoted 122 lines
Quoted 111 lines
steved.
Quoted 95 lines
Quoted 95 lines
Signed-off-by Steve Dickson <[email protected]>---
fs/nfs/nfs4_fs.h | 1 + fs/nfs/nfs4client.c | 8 ++++++-- fs/nfs/nfs4proc.c | 4 +++- fs/nfs/super.c | 6 +++++- 4 files changed, 15 insertions(+), 4 deletions(-)fs/nfs/nfs4_fs.h +1
-0@@ -438,6 +438,7 @@ extern bool nfs4_disable_idmapping;extern unsigned short max_session_slots;extern unsigned short send_implementation_id;extern bool recover_lost_locks; +extern bool nfs4_use_min_auth;#define NFS4_CLIENT_ID_UNIQ_LEN (64)extern char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ];fs/nfs/nfs4client.c +6
-2@@ -355,6 +355,7 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,char buf[INET6_ADDRSTRLEN +1 ];struct nfs_client *old;int error; +rpc_authflavor_t flavor =RPC_AUTH_GSS_KRB5I ;if (clp->cl_cons_state ==NFS_CS_READY ) {/* the client is initialised already */ @@ -368,8 +369,11 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,if (clp->cl_minorversion !=0 )__set_bit (NFS_CS_INFINITE_SLOTS , &clp->cl_flags);__set_bit (NFS_CS_DISCRTRY , &clp->cl_flags); - error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_GSS_KRB5I ); -if (error == -EINVAL ) + +if (nfs4_use_min_auth) + flavor =RPC_AUTH_UNIX ; + error =nfs_create_rpc_client (clp, timeparms, flavor); +if (error == -EINVAL && flavor !=RPC_AUTH_UNIX ) error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_UNIX );if (error <0 ) goto error;fs/nfs/nfs4proc.c +3
-1@@ -2864,7 +2864,9 @@ static int nfs4_find_root_sec(struct nfs_server *server, struct nfs_fh *fhandle,int status = -EPERM ;size_t i; -for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { +if (nfs4_use_min_auth) + status =nfs4_lookup_root_sec (server, fhandle, info,RPC_AUTH_UNIX ); +else for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { status =nfs4_lookup_root_sec (server, fhandle, info, flav_array[i]);if (status == -NFS4ERR_WRONGSEC || status == -EACCES )continue ;fs/nfs/super.c +5
-1@@ -2791,6 +2791,7 @@ unsigned short max_session_slots = NFS4_DEF_SLOT_TABLE_SIZE;unsigned short send_implementation_id =1 ;char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ] ="" ;bool recover_lost_locks = false; +bool nfs4_use_min_auth = false;EXPORT_SYMBOL_GPL (nfs_callback_set_tcpport);EXPORT_SYMBOL_GPL (nfs_callback_tcpport);@@ -2800,6 +2801,7 @@ EXPORT_SYMBOL_GPL(max_session_slots);EXPORT_SYMBOL_GPL (send_implementation_id);EXPORT_SYMBOL_GPL (nfs4_client_id_uniquifier);EXPORT_SYMBOL_GPL (recover_lost_locks); +EXPORT_SYMBOL_GPL (nfs4_use_min_auth);#define NFS_CALLBACK_MAXPORTNR (65535U)@@ -2842,5 +2844,7 @@ MODULE_PARM_DESC(recover_lost_locks,"If the server reports that a lock might be lost, " "try to recover it risking data corruption."); - +module_param (nfs4_use_min_auth, bool,0644 ); +MODULE_PARM_DESC (nfs4_use_min_auth, +"Use mimnal auth in SETCLIENTID operation" );#endif /* CONFIG_NFS_V4 */ Signature · 1 line
1.7.1Quoted 11 lines
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
Chuck Lever
chuck[dot]lever[at]oracle[dot]comQuoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to AUTH_SYS if it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.
Quoted 11 lines
Quoted 6 lines
Quoted 3 lines
Also running
a security daemon for non-secure mounts just seems wrong to me.It seems wrong to me to keep
auth_rpcgssloaded if no mounts use Kerberos security. What's the difference between that and running gssd all the time?You can say thing about %99 of all the modules load in a Fedora kernel today. lsmod | wc -l show there is 107 modules load on a f19 system. Do you think all those modules are used? Of course not, but they are not spewing 25 log messages per mount or sucking up CPU cycles unnecessarily.
rpc.gssd spends most of its time sleeping, unless there is nfs mount or "real" gssapi activity. CPU cycles shouldn't be an issue. The RSS for the process on my 64-bit box is ~2k so I wouldn't even be concerned about memory usage. For comparison, we don't worry much about running rpc.statd these days and it's of similar size and duty cycle.
The log messages are another matter. rpc.gssd is just too chatty by default. That's fixable, but it would mean that we'd need to tell people to run it in verbose mode when tracking down problems instead of assuming that all of those messages would go to the logs. That seems like a reasonable thing to do anyway. Most people don't care about rpc.gssd log messages once they have kerberized NFS working.
Quoted 148 lines
Quoted 4 lines
The new SETCLIENTID architecture would be transparent if our security infrastructure was reliable. We really need to address the upcall issue. We've been working around it for a very long time.
But its not transparent at this point. So we need a way to disable it until it comes transparent. That is what this module parameter does.
Quoted 10 lines
Quoted 6 lines
Quoted 3 lines
Have we completely given up on fixing the upcall?
Back when we were looking on to introduce gss-proxy into the client, it was decided the upcall on the client was not going to change. I'm just going with that!
I don't remember that discussion. Or if it occurred, I didn't realize at the time that it was referring to fixing bugs. Do you have a link to the thread?
It was when we were discussing how to use gss-proxy. If I remember correctly it was a verbal discussion...
steved.
Quoted 111 lines
Quoted 111 lines
steved.
Quoted 106 lines
Quoted 99 lines
Signed-off-by Steve Dickson <[email protected]>---
fs/nfs/nfs4_fs.h | 1 + fs/nfs/nfs4client.c | 8 ++++++-- fs/nfs/nfs4proc.c | 4 +++- fs/nfs/super.c | 6 +++++- 4 files changed, 15 insertions(+), 4 deletions(-)fs/nfs/nfs4_fs.h +1
-0@@ -438,6 +438,7 @@ extern bool nfs4_disable_idmapping;extern unsigned short max_session_slots;extern unsigned short send_implementation_id;extern bool recover_lost_locks; +extern bool nfs4_use_min_auth;#define NFS4_CLIENT_ID_UNIQ_LEN (64)extern char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ];fs/nfs/nfs4client.c +6
-2@@ -355,6 +355,7 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,char buf[INET6_ADDRSTRLEN +1 ];struct nfs_client *old;int error; +rpc_authflavor_t flavor =RPC_AUTH_GSS_KRB5I ;if (clp->cl_cons_state ==NFS_CS_READY ) {/* the client is initialised already */ @@ -368,8 +369,11 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,if (clp->cl_minorversion !=0 )__set_bit (NFS_CS_INFINITE_SLOTS , &clp->cl_flags);__set_bit (NFS_CS_DISCRTRY , &clp->cl_flags); - error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_GSS_KRB5I ); -if (error == -EINVAL ) + +if (nfs4_use_min_auth) + flavor =RPC_AUTH_UNIX ; + error =nfs_create_rpc_client (clp, timeparms, flavor); +if (error == -EINVAL && flavor !=RPC_AUTH_UNIX ) error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_UNIX );if (error <0 ) goto error;fs/nfs/nfs4proc.c +3
-1@@ -2864,7 +2864,9 @@ static int nfs4_find_root_sec(struct nfs_server *server, struct nfs_fh *fhandle,int status = -EPERM ;size_t i; -for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { +if (nfs4_use_min_auth) + status =nfs4_lookup_root_sec (server, fhandle, info,RPC_AUTH_UNIX ); +else for (i =0 ; i <ARRAY_SIZE (flav_array); i++) { status =nfs4_lookup_root_sec (server, fhandle, info, flav_array[i]);if (status == -NFS4ERR_WRONGSEC || status == -EACCES )continue ;fs/nfs/super.c +5
-1@@ -2791,6 +2791,7 @@ unsigned short max_session_slots = NFS4_DEF_SLOT_TABLE_SIZE;unsigned short send_implementation_id =1 ;char nfs4_client_id_uniquifier[NFS4_CLIENT_ID_UNIQ_LEN ] ="" ;bool recover_lost_locks = false; +bool nfs4_use_min_auth = false;EXPORT_SYMBOL_GPL (nfs_callback_set_tcpport);EXPORT_SYMBOL_GPL (nfs_callback_tcpport);@@ -2800,6 +2801,7 @@ EXPORT_SYMBOL_GPL(max_session_slots);EXPORT_SYMBOL_GPL (send_implementation_id);EXPORT_SYMBOL_GPL (nfs4_client_id_uniquifier);EXPORT_SYMBOL_GPL (recover_lost_locks); +EXPORT_SYMBOL_GPL (nfs4_use_min_auth);#define NFS_CALLBACK_MAXPORTNR (65535U)@@ -2842,5 +2844,7 @@ MODULE_PARM_DESC(recover_lost_locks,"If the server reports that a lock might be lost, " "try to recover it risking data corruption."); - +module_param (nfs4_use_min_auth, bool,0644 ); +MODULE_PARM_DESC (nfs4_use_min_auth, +"Use mimnal auth in SETCLIENTID operation" );#endif /* CONFIG_NFS_V4 */ Signature · 6 lines
1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html--
Chuck Lever
chuck[dot]lever[at]oracle[dot]comQuoted 11 lines
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 1 line
Jeff Layton <[email protected]>
Quoted 38 lines · Jeff Layton
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.
What server makes krb5i available today in state setup and pseudoroot lookups?
Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Also running
a security daemon for non-secure mounts just seems wrong to me.Quoted 7 lines
Quoted 2 lines
It seems wrong to me to keep
auth_rpcgssloaded if no mounts use Kerberos security. What's the difference between that and running gssd all the time?You can say thing about %99 of all the modules load in a Fedora kernel today. lsmod | wc -l show there is 107 modules load on a f19 system. Do you think all those modules are used? Of course not, but they are not spewing 25 log messages per mount or sucking up CPU cycles unnecessarily.
Quoted 5 lines
rpc.gssd spends most of its time sleeping, unless there is nfs mount or "real" gssapi activity. CPU cycles shouldn't be an issue. The RSS for the process on my 64-bit box is ~2k so I wouldn't even be concerned about memory usage. For comparison, we don't worry much about running rpc.statd these days and it's of similar size and duty cycle.
rpc.statd is needed by the V3 protocol to support file locking which is a bit more needed that a rpc.gssd to do unsecured mounts.
Quoted 7 lines
The log messages are another matter. rpc.gssd is just too chatty by default. That's fixable, but it would mean that we'd need to tell people to run it in verbose mode when tracking down problems instead of assuming that all of those messages would go to the logs. That seems like a reasonable thing to do anyway. Most people don't care about rpc.gssd log messages once they have kerberized NFS working.
So we should remove error and warning messages that in the pass help us debug very difficult code so we can run rpc.gssd just for normal unsecured mounts?
My apologies... but that makes absolutely no sense to me.
Let talk about scalability... Does anybody have idea what this needless upcall will cost on a client that does a very large number of mounts all at once?
Please let me reiterate my point. The new securing of SETCLIENTIDs and pseudoroot lookups is good! I have no problem with the actual technology. What I'm having a problem with is I can not manage this new technology.
Could you image the push back there would be if, back in the day when secure mounts became available, we required *everyone* to use secure mounts. The only way you could use NFS was through a secure mount.
That's basically what we are doing today! We are requiring every mount to try a secure flavor that fails %100 time because there is no server support for this technology.
Again its not the technology, its the management of the technology that this new module parameter address. All I'm looking for is switch that enables or disables this new technology...
steved.
Quoted 41 lines · On Fri, 08 Nov 2013 10:00:02 -0500 Steve Dickson <[email protected]> wrote:
Quoted 38 lines · Jeff Layton
Quoted 34 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 20 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
Quoted 7 lines
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 7 lines
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.What server makes krb5i available today in state setup and pseudoroot lookups?
That I don't know...sorry...
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Quoted 7 lines
Quoted 4 lines
Also running
a security daemon for non-secure mounts just seems wrong to me.It seems wrong to me to keep
auth_rpcgssloaded if no mounts use Kerberos security. What's the difference between that and running gssd all the time?You can say thing about %99 of all the modules load in a Fedora kernel today. lsmod | wc -l show there is 107 modules load on a f19 system. Do you think all those modules are used? Of course not, but they are not spewing 25 log messages per mount or sucking up CPU cycles unnecessarily.
Quoted 8 lines
Quoted 5 lines
rpc.gssd spends most of its time sleeping, unless there is nfs mount or "real" gssapi activity. CPU cycles shouldn't be an issue. The RSS for the process on my 64-bit box is ~2k so I wouldn't even be concerned about memory usage. For comparison, we don't worry much about running rpc.statd these days and it's of similar size and duty cycle.
rpc.statd is needed by the V3 protocol to support file locking which is a bit more needed that a rpc.gssd to do unsecured mounts.
Right, but we've defaulted to v4 for *years* now. Most people run statd and don't actually use it. No one seems to get bent out of shape about that though.
Quoted 8 lines
Quoted 7 lines
The log messages are another matter. rpc.gssd is just too chatty by default. That's fixable, but it would mean that we'd need to tell people to run it in verbose mode when tracking down problems instead of assuming that all of those messages would go to the logs. That seems like a reasonable thing to do anyway. Most people don't care about rpc.gssd log messages once they have kerberized NFS working.
Quoted 4 lines
So we should remove error and warning messages that in the pass help us debug very difficult code so we can run rpc.gssd just for normal unsecured mounts?
Yes. Because in the case where you don't have a keytab or a credcache, failure is expected. There's no need to log messages due to those sorts of problems. Once you have it working correctly, there's just no need to keep logging that junk. Most of those log messages should only be enabled when rpc.gssd is run with -v(vvv). Admins can (and often do) run rpc.gssd in foreground with those flags while they sort through the setup.
Quoted 6 lines
My apologies... but that makes absolutely no sense to me.
Let talk about scalability... Does anybody have idea what this needless upcall will cost on a client that does a very large number of mounts all at once?
Virtually nothing -- a couple of pipe reads/writes.
Quoted 10 lines
Please let me reiterate my point. The new securing of SETCLIENTIDs and pseudoroot lookups is good! I have no problem with the actual technology. What I'm having a problem with is I can not manage this new technology.
Could you image the push back there would be if, back in the day when secure mounts became available, we required *everyone* to use secure mounts. The only way you could use NFS was through a secure mount.
Quoted 9 lines
That's basically what we are doing today! We are requiring every mount to try a secure flavor that fails %100 time because there is no server support for this technology.
Again its not the technology, its the management of the technology that this new module parameter address. All I'm looking for is switch that enables or disables this new technology...
No one is requiring anyone to do anything. IMO, running rpc.gssd by default is simply a reasonable workaround for this long delay in mounting until we have a real solution for this problem.
I'd like to see us transition to a more sensible upcall in the future that doesn't require this timeout, but we're not there yet. Once we have that, we won't need to run rpc.gssd at all anymore.
FWIW, I'm perfectly happy do the work on such an upcall. I think call_usermodehelper (or maybe keys API) makes a lot of sense for this. The only real problem I can see with doing this today is the damnable namespaces. The nfs client is currently net-namespacified, but running something like call_usermodehelper sort of requires that you switch the mnt namespace too.
Signature · 1 line
Jeff Layton <[email protected]>
Quoted 49 lines · Jeff Layton
Quoted 46 lines · On Fri, 08 Nov 2013 10:00:02 -0500 Steve Dickson <[email protected]> wrote:
Quoted 43 lines · Jeff Layton
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.
Quoted 4 lines
Quoted 2 lines
What server makes krb5i available today in state setup and pseudoroot lookups?
That I don't know...sorry...
Then what is the justification to take all these extra steps there they going to fail %100 of the time??
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Also running
a security daemon for non-secure mounts just seems wrong to me.Quoted 7 lines
Quoted 2 lines
It seems wrong to me to keep
auth_rpcgssloaded if no mounts use Kerberos security. What's the difference between that and running gssd all the time?You can say thing about %99 of all the modules load in a Fedora kernel today. lsmod | wc -l show there is 107 modules load on a f19 system. Do you think all those modules are used? Of course not, but they are not spewing 25 log messages per mount or sucking up CPU cycles unnecessarily.
rpc.gssd spends most of its time sleeping, unless there is nfs mount or "real" gssapi activity. CPU cycles shouldn't be an issue. The RSS for the process on my 64-bit box is ~2k so I wouldn't even be concerned about memory usage. For comparison, we don't worry much about running rpc.statd these days and it's of similar size and duty cycle.
Quoted 7 lines
Quoted 3 lines
rpc.statd is needed by the V3 protocol to support file locking which is a bit more needed that a rpc.gssd to do unsecured mounts.
Right, but we've defaulted to v4 for *years* now. Most people run statd and don't actually use it. No one seems to get bent out of shape about that though.
So you using that justify another needless daemon?
Quoted 14 lines
Quoted 9 lines
Quoted 8 lines
The log messages are another matter. rpc.gssd is just too chatty by default. That's fixable, but it would mean that we'd need to tell people to run it in verbose mode when tracking down problems instead of assuming that all of those messages would go to the logs. That seems like a reasonable thing to do anyway. Most people don't care about rpc.gssd log messages once they have kerberized NFS working.
Quoted 4 lines
So we should remove error and warning messages that in the pass help us debug very difficult code so we can run rpc.gssd just for normal unsecured mounts?
Quoted 7 lines
Yes. Because in the case where you don't have a keytab or a credcache, failure is expected. There's no need to log messages due to those sorts of problems. Once you have it working correctly, there's just no need to keep logging that junk. Most of those log messages should only be enabled when rpc.gssd is run with -v(vvv). Admins can (and often do) run rpc.gssd in foreground with those flags while they sort through the setup.
When there is no keytab or credcache there should be to start rpc.gssd. Non-secure mount should not depend on the existence of a user level daemon... When has ever been the case a NFS mount was dependent on user level daemon?
Quoted 9 lines
Quoted 7 lines
My apologies... but that makes absolutely no sense to me.
Let talk about scalability... Does anybody have idea what this needless upcall will cost on a client that does a very large number of mounts all at once?
Virtually nothing -- a couple of pipe reads/writes.
Until rpc.gssd dies and everything comes to a halt... ;-)
Quoted 21 lines
Quoted 11 lines
Please let me reiterate my point. The new securing of SETCLIENTIDs and pseudoroot lookups is good! I have no problem with the actual technology. What I'm having a problem with is I can not manage this new technology.
Could you image the push back there would be if, back in the day when secure mounts became available, we required *everyone* to use secure mounts. The only way you could use NFS was through a secure mount.
Quoted 9 lines
That's basically what we are doing today! We are requiring every mount to try a secure flavor that fails %100 time because there is no server support for this technology.
Again its not the technology, its the management of the technology that this new module parameter address. All I'm looking for is switch that enables or disables this new technology...
Quoted 3 lines
No one is requiring anyone to do anything. IMO, running rpc.gssd by default is simply a reasonable workaround for this long delay in mounting until we have a real solution for this problem.
The client code is hard code to try security flavor on every mount. There is no way around it. That is I mean by requiring all mounts to use security flavor.
Quoted 4 lines
I'd like to see us transition to a more sensible upcall in the future that doesn't require this timeout, but we're not there yet. Once we have that, we won't need to run rpc.gssd at all anymore.
So we all agree, this code needs work... So why not have a way to disable the trying of security flavor until its ready for prime time??? We done that in the past??
Or may this... Disable it until there is server support! What is wrong with that???
steved.
Quoted 8 lines
FWIW, I'm perfectly happy do the work on such an upcall. I think
call_usermodehelper(or maybe keys API) makes a lot of sense for this. The only real problem I can see with doing this today is the damnable namespaces. The nfs client is currently net-namespacified, but running something likecall_usermodehelpersort of requires that you switch the mnt namespace too.
Quoted 52 lines · Steve Dickson
Quoted 49 lines · Jeff Layton
Quoted 46 lines · On Fri, 08 Nov 2013 10:00:02 -0500 Steve Dickson <[email protected]> wrote:
Quoted 43 lines · Jeff Layton
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
What server makes krb5i available today in state setup and pseudoroot lookups?
That I don't know...sorry...
Then what is the justification to take all these extra steps there they going to fail %100 of the time??
Any server can support krb5 for state setup and pseudoroot operations if it's configured. This isn't a problem.
--b.
Quoted 56 lines · J. Bruce Fields
Quoted 55 lines · Steve Dickson
Quoted 52 lines · Jeff Layton
Quoted 48 lines · On Fri, 08 Nov 2013 10:00:02 -0500 Steve Dickson <[email protected]> wrote:
Quoted 38 lines · Jeff Layton
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.What server makes krb5i available today in state setup and pseudoroot lookups?
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
That I don't know...sorry...
Then what is the justification to take all these extra steps there they going to fail %100 of the time??
Any server can support krb5 for state setup and pseudoroot operations if it's configured. This isn't a problem.
Would is this done on a Linux server? Is there a wiki?
steved.
Quoted 3 lines
--b.
Quoted 59 lines · Steve Dickson
Quoted 56 lines · J. Bruce Fields
Quoted 55 lines · Steve Dickson
Quoted 52 lines · Jeff Layton
Quoted 48 lines · On Fri, 08 Nov 2013 10:00:02 -0500 Steve Dickson <[email protected]> wrote:
Quoted 38 lines · Jeff Layton
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.What server makes krb5i available today in state setup and pseudoroot lookups?
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
That I don't know...sorry...
Then what is the justification to take all these extra steps there they going to fail %100 of the time??
Any server can support krb5 for state setup and pseudoroot operations if it's configured. This isn't a problem.
Would is this done on a Linux server? Is there a wiki?
It's allowed by default, there should be nothing to configure beyond the usual krb5 setup.
--b.
Quoted 64 lines · J. Bruce Fields
Quoted 63 lines · Steve Dickson
Quoted 60 lines · J. Bruce Fields
Quoted 58 lines · Steve Dickson
Quoted 49 lines · Jeff Layton
Quoted 46 lines · On Fri, 08 Nov 2013 10:00:02 -0500 Steve Dickson <[email protected]> wrote:
Quoted 43 lines · Jeff Layton
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.Quoted 4 lines
Quoted 2 lines
What server makes krb5i available today in state setup and pseudoroot lookups?
That I don't know...sorry...
Then what is the justification to take all these extra steps there they going to fail %100 of the time??
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines
Any server can support krb5 for state setup and pseudoroot operations if it's configured. This isn't a problem.
Would is this done on a Linux server? Is there a wiki?
It's allowed by default, there should be nothing to configure beyond the usual krb5 setup.
Great! So you are saying when rpc.gssd is up and Kerberos is correctly configured on both the server and client the state setup and pseudoroot become secured?
And this is the case with other non-Linux servers?
steved.
Quoted 69 lines · Steve Dickson
Quoted 66 lines · J. Bruce Fields
Quoted 65 lines · Steve Dickson
Quoted 62 lines · J. Bruce Fields
Quoted 52 lines · Steve Dickson
Quoted 49 lines · Jeff Layton
Quoted 46 lines · On Fri, 08 Nov 2013 10:00:02 -0500 Steve Dickson <[email protected]> wrote:
Quoted 43 lines · Jeff Layton
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
What server makes krb5i available today in state setup and pseudoroot lookups?
That I don't know...sorry...
Then what is the justification to take all these extra steps there they going to fail %100 of the time??
Any server can support krb5 for state setup and pseudoroot operations if it's configured. This isn't a problem.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Would is this done on a Linux server? Is there a wiki?
It's allowed by default, there should be nothing to configure beyond the usual krb5 setup.
Great! So you are saying when rpc.gssd is up and Kerberos is correctly configured on both the server and client the state setup and pseudoroot become secured?
Yes.
There's one possible exception: I think mountd currently may not allow krb5 on the pseudoroot if it's not allowed on some export?
We could fix that if it's a problem here. (I don't think it is, because a client mounting with auth_sys will fall back on auth_sys in this case, and a client mounting with sec=krb5 is going to fail eventually anyway.)
The server will allow state setup regardless.
Quoted 1 line
And this is the case with other non-Linux servers?
Yes, the client's always used krb5 for all that setup at least in the case where the first mount uses sec=krb5. And we test that at connectathon/bakeathon, and it's probably one of the first things anyone writing new gss support for a server would try.
--b.
Quoted 80 lines · J. Bruce Fields
Quoted 69 lines · Steve Dickson
Quoted 66 lines · J. Bruce Fields
Quoted 65 lines · Steve Dickson
Quoted 62 lines · J. Bruce Fields
Quoted 52 lines · Steve Dickson
Quoted 49 lines · Jeff Layton
Quoted 46 lines · On Fri, 08 Nov 2013 10:00:02 -0500 Steve Dickson <[email protected]> wrote:
Quoted 43 lines · Jeff Layton
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
On Nov 7, 2013, at 11:09 AM, Steve Dickson <[email protected]> wrote:
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work
around the 15 second GSSD upcall timeout?Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
What server makes krb5i available today in state setup and pseudoroot lookups?
That I don't know...sorry...
Then what is the justification to take all these extra steps there they going to fail %100 of the time??
Any server can support krb5 for state setup and pseudoroot operations if it's configured. This isn't a problem.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Would is this done on a Linux server? Is there a wiki?
It's allowed by default, there should be nothing to configure beyond the usual krb5 setup.
Great! So you are saying when rpc.gssd is up and Kerberos is correctly configured on both the server and client the state setup and pseudoroot become secured?
Yes.
Quoted 8 lines
There's one possible exception: I think mountd currently may not allow krb5 on the pseudoroot if it's not allowed on some export?
We could fix that if it's a problem here. (I don't think it is, because a client mounting with
auth_syswill fall back onauth_sysin this case, and a client mounting with sec=krb5 is going to fail eventually anyway.)The server will allow state setup regardless.
This is good to know... Thanks!
Quoted 7 lines
Quoted 2 lines
And this is the case with other non-Linux servers?
Yes, the client's always used krb5 for all that setup at least in the case where the first mount uses sec=krb5. And we test that at connectathon/bakeathon, and it's probably one of the first things anyone writing new gss support for a server would try.
It would be good to get all this documented... If its not already...
steved.
Quoted 3 lines
--b.
Quoted 74 lines · J. Bruce Fields
Quoted 73 lines · Steve Dickson
Quoted 70 lines · J. Bruce Fields
Quoted 59 lines · Steve Dickson
Quoted 56 lines · J. Bruce Fields
Quoted 55 lines · Steve Dickson
Quoted 52 lines · Jeff Layton
Quoted 48 lines · On Fri, 08 Nov 2013 10:00:02 -0500 Steve Dickson <[email protected]> wrote:
Quoted 38 lines · Jeff Layton
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
On Nov 7, 2013, at 11:09 AM, Steve Dickson <[email protected]> wrote:
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work
around the 15 second GSSD upcall timeout?Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.What server makes krb5i available today in state setup and pseudoroot lookups?
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
That I don't know...sorry...
Then what is the justification to take all these extra steps there they going to fail %100 of the time??
Any server can support krb5 for state setup and pseudoroot operations if it's configured. This isn't a problem.
Would is this done on a Linux server? Is there a wiki?
It's allowed by default, there should be nothing to configure beyond the usual krb5 setup.
Quoted 8 lines
Quoted 3 lines
Great! So you are saying when rpc.gssd is up and Kerberos is correctly configured on both the server and client the state setup and pseudoroot become secured?
Yes.
There's one possible exception: I think mountd currently may not allow krb5 on the pseudoroot if it's not allowed on some export?
See earlier e-mail: pseudo-fs access is done using the mount's specified security flavor, not by the lease management security flavor.
Quoted 5 lines
We could fix that if it's a problem here. (I don't think it is, because a client mounting with
auth_syswill fall back onauth_sysin this case, and a client mounting with sec=krb5 is going to fail eventually anyway.)The server will allow state setup regardless.
Correct.
Quoted 6 lines
Quoted 1 line
And this is the case with other non-Linux servers?
Yes, the client's always used krb5 for all that setup at least in the case where the first mount uses sec=krb5. And we test that at connectathon/bakeathon, and it's probably one of the first things anyone writing new gss support for a server would try.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 56 lines · J. Bruce Fields
Quoted 55 lines · Steve Dickson
Quoted 52 lines · Jeff Layton
Quoted 48 lines · On Fri, 08 Nov 2013 10:00:02 -0500 Steve Dickson <[email protected]> wrote:
Quoted 38 lines · Jeff Layton
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.What server makes krb5i available today in state setup and pseudoroot lookups?
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
That I don't know...sorry...
Then what is the justification to take all these extra steps there they going to fail %100 of the time??
Any server can support krb5 for state setup and pseudoroot operations if it's configured. This isn't a problem.
I let this pass earlier, but...
The krb5i setting is _ONLY_ for lease management, not for data access. Traversing the pseudo-fs counts as data access. Our client is supposed to use the security flavor specified on the mount command line for the pseudo-fs. (That's why the pseudo-fs security policy is the union of all the real exports on the server, right?)
If no flavor is specified by the client administrator, we have SECINFO_NONAME for negotiating the pseudo-fs security flavor in NFSv4.1, and some roughly equivalent heuristics for this in NFSv4.0, which doesn't have the SECINFO_NONAME operation. Since 3.11, I believe, our client should be using these mechanisms instead of just plowing ahead with AUTH_SYS.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 5 lines · Chuck Lever
I let this pass earlier, but...
The krb5i setting is _ONLY_ for lease management, not for data access. Traversing the pseudo-fs counts as data access. Our client is supposed to use the security flavor specified on the mount command line for the pseudo-fs. (That's why the pseudo-fs security policy is the union of all the real exports on the server, right?)
If no flavor is specified by the client administrator, we have
SECINFO_NONAMEfor negotiating the pseudo-fs security flavor in NFSv4.1, and some roughly equivalent heuristics for this in NFSv4.0, which doesn't have theSECINFO_NONAMEoperation. Since 3.11, I believe, our client should be using these mechanisms instead of just plowing ahead withAUTH_SYS.
That makes sense.
(By the way: if a mount is done with krb5*, are we guaranteed the entire export path is looked up with security at least as strong, or is it possible we trust cached lookups possibly originally obtained with weaker security?)
--b.
Quoted 56 lines · J. Bruce Fields
Quoted 55 lines · Steve Dickson
Quoted 52 lines · Jeff Layton
Quoted 48 lines · On Fri, 08 Nov 2013 10:00:02 -0500 Steve Dickson <[email protected]> wrote:
Quoted 38 lines · Jeff Layton
Quoted 28 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 6 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.What server makes krb5i available today in state setup and pseudoroot lookups?
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
That I don't know...sorry...
Then what is the justification to take all these extra steps there they going to fail %100 of the time??
Any server can support krb5 for state setup and pseudoroot operations if it's configured. This isn't a problem.
Thank you for point this out... That does change things... IMHO...
steved.
Quoted 7 lines
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 3 lines · On Fri, 8 Nov 2013 10:12:32 -0500 Jeff Layton <[email protected]> wrote:
Right, but we've defaulted to v4 for *years* now. Most people run statd and don't actually use it. No one seems to get bent out of shape about that though.
Given that statd can be started on demand by mount.nfs, this sounds like a configuration error.
NeilBrown
Quoted 1 line · Steve Dickson
What server makes krb5i available today in state setup and pseudoroot lookups?
Linux nfsd, among others…
The real issue I see here is what Trond was mentioning earlier - the order of multiple mounts of the same server matters, i.e.:
1) mount sec=krb5i server:/foo /mnt1
2) mount sec=sys server:/foo /mnt2
This leads to the state operations to server using krb5i, but:
1) mount sec=sys server:/foo /mnt2
2) mount sec=krb5i server:/foo /mnt1
this leads to the state operations to server using AUTH_SYS. yuck.
I don’t think we can just upgrade the state connection from AUTH_SYS to krb5i when this happens, that is why we try krb5i first, then fall back to AUTH_SYS.
-dros
Quoted 14 lines · Weston Andros Adamson
Quoted 1 line · Steve Dickson
What server makes krb5i available today in state setup and pseudoroot lookups?
Linux nfsd, among others…
The real issue I see here is what Trond was mentioning earlier - the order of multiple mounts of the same server matters, i.e.:
1) mount sec=krb5i server:/foo /mnt1
2) mount sec=sys server:/foo /mnt2This leads to the state operations to server using krb5i, but:
Quoted 7 lines
1) mount sec=sys server:/foo /mnt2
2) mount sec=krb5i server:/foo /mnt1this leads to the state operations to server using
AUTH_SYS. yuck.I don’t think we can just upgrade the state connection from
AUTH_SYSto krb5i when this happens, that is why we try krb5i first, then fall back toAUTH_SYS.
Excellent explanation! Thanks you! But... ;-) This assumes the admin is actually trying to krb5i which means he/she has set up a functioning Kerberos environment. But we can't assume every client has a valid Kerberos environment, which is what the code is doing today!
steved.
Quoted 7 lines · Jeff Layton
Quoted 4 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.
I'm also still a little confused about the security model. We discussed it before but I can't remember if it was really resolved.
It makes sense to me as long as we insist on krb5i whenever we find a keytab.
But my understanding was that with the current implementation it's possible we could find a keytab, attempt the krb5i connection, and *then* fallback silently on auth_sys if krb5i fails. Is that right?
In that case I don't see the point of the krb5i any more: any attacker that can spoof rpc replies can force the fallback to auth_sys.
--b.
Quoted 20 lines · J. Bruce Fields
Quoted 7 lines · Jeff Layton
Quoted 4 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.I'm also still a little confused about the security model. We discussed it before but I can't remember if it was really resolved.
It makes sense to me as long as we insist on krb5i whenever we find a keytab.
Quoted 6 lines
But my understanding was that with the current implementation it's possible we could find a keytab, attempt the krb5i connection, and *then* fallback silently on
auth_sysif krb5i fails. Is that right?In that case I don't see the point of the krb5i any more: any attacker that can spoof rpc replies can force the fallback to
auth_sys.
The point is to use a consistent security flavor for lease management to avoid NFS4ERR_CLID_INUSE. This really isn't about thwarting a MiTM attack on lease management.
The fallback mechanism can be fixed, somewhat. I've got a patch to have gssd return ENOKEY if it can't find a machine credential. Then the kernel will use AUTH_SYS.
The issue though is what to do in the other cases. Can gssd distinguish between the case where the server has no Kerberos principal, and the case where gssd simply failed to establish a GSS context? Or should we simply use the "sec=" setting in this case and call it a day?
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 29 lines · Chuck Lever
Quoted 25 lines · J. Bruce Fields
Quoted 8 lines · Jeff Layton
Quoted 5 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.I'm also still a little confused about the security model. We discussed it before but I can't remember if it was really resolved.
It makes sense to me as long as we insist on krb5i whenever we find a keytab.
But my understanding was that with the current implementation it's possible we could find a keytab, attempt the krb5i connection, and *then* fallback silently on
auth_sysif krb5i fails. Is that right?
Quoted 7 lines
Quoted 3 lines
In that case I don't see the point of the krb5i any more: any attacker that can spoof rpc replies can force the fallback to
auth_sys.The point is to use a consistent security flavor for lease management to avoid
NFS4ERR_CLID_INUSE. This really isn't about thwarting a MiTM attack on lease management.
OK, but then you still do want to ensure you thwart that attack in the case krb5 is explicitly asked for.
So for example does a krb5 mount fail if a previous non-krb5 mount fell back on auth_sys for clientid establishment?
Quoted 3 lines
The fallback mechanism can be fixed, somewhat. I've got a patch to have gssd return ENOKEY if it can't find a machine credential. Then the kernel will use
AUTH_SYS.
To get that right you'd then need to fail on errors *other* than ENOKEY. Since old gssd doesn't return ENOKEY that would mean failing all auth_sys mounts on kernel upgrade, wouldn't it?
Quoted 4 lines
The issue though is what to do in the other cases. Can gssd distinguish between the case where the server has no Kerberos principal, and the case where gssd simply failed to establish a GSS context?
I don't know. I suppose the client should get some kind of no-such-principal error and use that.
Quoted 2 lines
Or should we simply use the "sec=" setting in this case and call it a day?
I think falling back works as long as we still are strict in the case the mount explicitly requests some security and don't just use whatever's already established in that case.
And if we do that then I don't think the ENOKEY/no-such-principal cases are worth sorting out.
OK, sorry for the noise.
--b.
Quoted 60 lines · J. Bruce Fields
Quoted 29 lines · Chuck Lever
Quoted 25 lines · J. Bruce Fields
Quoted 8 lines · Jeff Layton
Quoted 5 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.I'm also still a little confused about the security model. We discussed it before but I can't remember if it was really resolved.
It makes sense to me as long as we insist on krb5i whenever we find a keytab.
But my understanding was that with the current implementation it's possible we could find a keytab, attempt the krb5i connection, and *then* fallback silently on
auth_sysif krb5i fails. Is that right?Quoted 7 lines
Quoted 3 lines
In that case I don't see the point of the krb5i any more: any attacker that can spoof rpc replies can force the fallback to
auth_sys.The point is to use a consistent security flavor for lease management to avoid
NFS4ERR_CLID_INUSE. This really isn't about thwarting a MiTM attack on lease management.OK, but then you still do want to ensure you thwart that attack in the case krb5 is explicitly asked for.
So for example does a krb5 mount fail if a previous non-krb5 mount fell back on
auth_sysfor clientid establishment?Quoted 3 lines
The fallback mechanism can be fixed, somewhat. I've got a patch to have gssd return ENOKEY if it can't find a machine credential. Then the kernel will use
AUTH_SYS.To get that right you'd then need to fail on errors *other* than ENOKEY. Since old gssd doesn't return ENOKEY that would mean failing all
auth_sysmounts on kernel upgrade, wouldn't it?Quoted 4 lines
The issue though is what to do in the other cases. Can gssd distinguish between the case where the server has no Kerberos principal, and the case where gssd simply failed to establish a GSS context?
I don't know. I suppose the client should get some kind of no-such-principal error and use that.
Quoted 6 lines
Quoted 2 lines
Or should we simply use the "sec=" setting in this case and call it a day?
I think falling back works as long as we still are strict in the case the mount explicitly requests some security and don't just use whatever's already established in that case.
Agreed. That is what we want to strive for.
So: use the fallback mechanism only if Kerberos was _not_ specified via the mount options, I think?
Quoted 10 lines
And if we do that then I don't think the ENOKEY/no-such-principal cases are worth sorting out.
OK, sorry for the noise.
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 66 lines · Chuck Lever
Quoted 63 lines · J. Bruce Fields
Quoted 29 lines · Chuck Lever
Quoted 25 lines · J. Bruce Fields
Quoted 8 lines · Jeff Layton
Quoted 5 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.I'm also still a little confused about the security model. We discussed it before but I can't remember if it was really resolved.
It makes sense to me as long as we insist on krb5i whenever we find a keytab.
But my understanding was that with the current implementation it's possible we could find a keytab, attempt the krb5i connection, and *then* fallback silently on
auth_sysif krb5i fails. Is that right?Quoted 7 lines
Quoted 3 lines
In that case I don't see the point of the krb5i any more: any attacker that can spoof rpc replies can force the fallback to
auth_sys.The point is to use a consistent security flavor for lease management to avoid
NFS4ERR_CLID_INUSE. This really isn't about thwarting a MiTM attack on lease management.OK, but then you still do want to ensure you thwart that attack in the case krb5 is explicitly asked for.
So for example does a krb5 mount fail if a previous non-krb5 mount fell back on
auth_sysfor clientid establishment?Quoted 3 lines
The fallback mechanism can be fixed, somewhat. I've got a patch to have gssd return ENOKEY if it can't find a machine credential. Then the kernel will use
AUTH_SYS.To get that right you'd then need to fail on errors *other* than ENOKEY. Since old gssd doesn't return ENOKEY that would mean failing all
auth_sysmounts on kernel upgrade, wouldn't it?Quoted 4 lines
The issue though is what to do in the other cases. Can gssd distinguish between the case where the server has no Kerberos principal, and the case where gssd simply failed to establish a GSS context?
I don't know. I suppose the client should get some kind of no-such-principal error and use that.
Quoted 2 lines
Or should we simply use the "sec=" setting in this case and call it a day?
Quoted 10 lines
Quoted 3 lines
I think falling back works as long as we still are strict in the case the mount explicitly requests some security and don't just use whatever's already established in that case.
Agreed. That is what we want to strive for.
So: use the fallback mechanism only if Kerberos was _not_ specified via the mount options, I think?
Quoted 2 lines
And if we do that then I don't think the ENOKEY/no-such-principal cases are worth sorting out.
The fly in this ointment is allowing clients with no keytab to mount with sec=krb5.
We can use ENOKEY to allow lease management with AUTH_SYS but data access using Kerberos and a user's credential.
Otherwise, a user has to login as root, kinit as themselves, and then mount. That makes automounter configurations a little dodgy.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 5 lines · Chuck Lever
The fly in this ointment is allowing clients with no keytab to mount with sec=krb5.
We can use ENOKEY to allow lease management with
AUTH_SYSbut data access using Kerberos and a user's credential.
So "mount -osec=krb5*" means "use krb5* or stronger for everything", unless you have no keytab in which case it means "use krb5* for all file access but allow auth_sys for lease maintenance". Huh. I guess that works.
--b.
Quoted 3 lines
Otherwise, a user has to login as root, kinit as themselves, and then mount. That makes automounter configurations a little dodgy.
Quoted 27 lines · Chuck Lever
Quoted 24 lines · J. Bruce Fields
Quoted 7 lines · Jeff Layton
Quoted 4 lines · On Fri, 08 Nov 2013 07:41:32 -0500 Steve Dickson <[email protected]> wrote:
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Quoted 5 lines
I don't think that's really the case. The idea was to have the client attempt to use krb5i if it's available, and then to fall back to
AUTH_SYSif it isn't. This would be *absolutely* no big deal if the GSSAPI upcall succeeded or failed immediately instead of requiring this timeout when the daemon isn't running.I'm also still a little confused about the security model. We discussed it before but I can't remember if it was really resolved.
It makes sense to me as long as we insist on krb5i whenever we find a keytab.
But my understanding was that with the current implementation it's possible we could find a keytab, attempt the krb5i connection, and *then* fallback silently on
auth_sysif krb5i fails. Is that right?
Quoted 6 lines
Quoted 2 lines
In that case I don't see the point of the krb5i any more: any attacker that can spoof rpc replies can force the fallback to
auth_sys.The point is to use a consistent security flavor for lease management to avoid
NFS4ERR_CLID_INUSE. This really isn't about thwarting a MiTM attack on lease management.
Again, its not the technology I'm arguing because its good stuff... I would just like a way to manage it.
Quoted 3 lines
The fallback mechanism can be fixed, somewhat. I've got a patch to have gssd return ENOKEY if it can't find a machine credential. Then the kernel will use
AUTH_SYS.
We should not have to start a daemon to do a normal NFS client mount. That is just not a good thing... IMHO...
Quoted 5 lines
The issue though is what to do in the other cases. Can gssd distinguish between the case where the server has no Kerberos principal, and the case where gssd simply failed to establish a GSS context? Or should we simply use the "sec=" setting in this case and call it a day?
Good questions.... IDK... I see this is another justification for use to have away to manage this code until these questions are answered.
steved.
Quoted 7 lines
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 28 lines · Steve Dickson
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 5 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Before, we were "forcing" admins to use AUTH_SYS on some mounts even though they had chosen to use sec=krb5 on some mounts. How is that a good thing?
Now, we are "forcing" admins to use security, but only when it is available. In other words, our default now is to be more secure rather than insecure. Why is that a bad thing?
The IETF has now reached consensus to require security in every new protocol it specifies. They want to enable security and not give ways to turn it off. They are even considering re-specifying existing widely deployed protocols to increase their security.
"it's not necessary" is no longer an excuse not to use security. Read the minutes of Wednesday's IAB technical plenary if you doubt me (yes, someone actually said that during the open mic, and there was some applause).
Earlier Trond noted that NFSv4 REQUIRES implementations to support RPCSEC GSS. That requirement has been there since RFC 3010. There is a reason for that.
The only reason you are arguing to disable security here is because it is a mild annoyance. And instead of addressing the annoyance, you want to allow users to disable security.
I'd like a solution that chooses to use security when its available, rather than blindly sticking with an insecure default. I'd like a solution that makes that choice automatically without adding yet another obscure setting to our panoply of obscure settings. It should "just work."
We are "this close" to getting that. Let's not take a step backwards.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Hey,
Quoted 31 lines · Chuck Lever
Quoted 28 lines · Steve Dickson
Quoted 25 lines · Chuck Lever
Quoted 12 lines · Steve Dickson
Hey mrchuck...
Quoted 9 lines · Chuck Lever
Hi Steve-
Quoted 4 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupQuoted 4 lines
Quoted 2 lines
The patch description doesn't say, but is this change to work around the 15 second GSSD upcall timeout?
Yes. A 15 second delay on every mount due to security that nobody is requesting is just not good.. IMHO..
One thing we haven't discussed is reducing the upcall timeout to 5 seconds or less, as a form of immediate relief. 15 seconds is arbitrary, and is onerous even when you expect the mount to work (ie why would it be good for any properly configured environment to take 15 seconds to establish a GSS context?).
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
In other words, there are still cases where users wait 15 seconds unnecessarily, and not because of the use of krb5i for lease management. Aren't those of concern?
No. I think the concern here, at least my concern, is the lack of management. We are forcing admins to use krb5i in lease management when its not necessary and there is no way to turn it off.
Before, we were "forcing" admins to use
AUTH_SYSon some mounts even though they had chosen to use sec=krb5 on some mounts. How is that a good thing?
It was not, but it was a small window of where AUTH_SYS was used then krb5* took over... I think that was better than a 15 sec delay.
Quoted 3 lines
Now, we are "forcing" admins to use security, but only when it is available.
In other words, our default now is to be more secure rather than insecure. Why is that a bad thing?
Again its not... But if the technology is not there to make it a seamless transition then we should wait until the transition is seamless before we force things on admins... IMHO..
Quoted 5 lines
The IETF has now reached consensus to require security in every new protocol it specifies. They want to enable security and not give ways to turn it off. They are even considering re-specifying existing widely deployed protocols to increase their security.
I'll refer to my previous comments... When it becomes seamless... its good to go...
Remember when SELinux first came out? How it caused everything to fail, especially on the server side? The first they did was to give us a way to turn in off. How many times did you use setenforce 0 ? ;-) Heck, I think I'm the reason they came up with that command! 8-)
Quoted 4 lines
"it's not necessary" is no longer an excuse not to use security. Read the minutes of Wednesday's IAB technical plenary if you doubt me (yes, someone actually said that during t he open mic, and there was some applause).
Dictating or taking away choice on how people can configure their environment is not a good thing IMHO... One size security does not fit all...
Quoted 3 lines
Earlier Trond noted that NFSv4 REQUIRES implementations to support RPCSEC GSS. That requirement has been there since RFC 3010. There is a reason for that.
Yes it is a requirement, which was a good thing, but admins had a *choice* on whether they wanted to use it... I disagree with taking that choice away.
Quoted 2 lines
The only reason you are arguing to disable security here is because it is a mild annoyance.
Mild? You are saying a 15 second delay on every mount is mild? :-) Boy I would hate to see you though disruptive was... ;-)
Quoted 1 line
And instead of addressing the annoyance, you want to allow users to disable security.
Yes, I want to give admins the same choice they the have always had.. On or off. and that is bad?
Quoted 5 lines
I'd like a solution that chooses to use security when its available, rather than blindly sticking with an insecure default. I'd like a solution that makes that choice automatically without adding yet another obscure setting to our panoply of obscure settings. It should "just work."
If it did "just work" fine.. but it does not. Why not give a bridge to people until we get things to "just work"?
Quoted 2 lines
We are "this close" to getting that. Let's not take a step backwards.
But we are not there yet... So sometimes you have to take one step backwards to take two step forwards as the old saying goes...
steved.
Quoted 5 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookup
That looks very ad-hoc. Quite frankly, you can do the exact same thing already by simply blacklisting the rpcsec_gss_krb5 and/or auth_rpcgss modules.
I think we should rather looks at adding a new mount option for specifying the security flavour to use when establishing basic NFSv4.x state, and then perhaps specifying the _default_ for that mount option using a module parameter.
Cheers
Trond
Signature · 6 lines
Trond Myklebust Linux NFS client maintainer NetApp [email protected] www.netapp.com
Hey,
Quoted 10 lines · Trond
Quoted 5 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookupThat looks very ad-hoc. Quite frankly, you can do the exact same thing already by simply blacklisting the
rpcsec_gss_krb5and/orauth_rpcgssmodules.
I tried to keep a very small foot print... I'm not sure why that looks ad-hoc to you...
If we blacklist those module(s) then we are disabling secure mounts altogether...
Quoted 5 lines
I think we should rather looks at adding a new mount option for specifying the security flavour to use when establishing basic NFSv4.x state, and then perhaps specifying the _default_ for that mount option using a module parameter.
The problem is everything is hard code in these two areas so having a mount option would not work...
The fact that -o sec=sys does not turn off the use of AUTH_GSS_KRB5x is simple wrong... IMHO... Not having way to override this behavior is not a good thing... again... IMHO...
Finally, Are there any servers out there today that support this type of behavior? Requiring secure state establishment or secure pseudoroot lookups.
Bruce, can we configure the Linux server to require this type security behavior? Can any server out there require these type of security behavior?
If the answer is no, then we really need a way to disable this type of behavior....
steved.
Quoted 10 lines · Steve Dickson
Hey,
Quoted 7 lines · Trond
Quoted 5 lines · Steve Dickson
This new module parameter makes the v4 client
use the minimal authentication flavor (AUTH_UNIX)
when establishing NFSV4 state and doing the
pseudoroot lookup
Quoted 8 lines
Quoted 3 lines
That looks very ad-hoc. Quite frankly, you can do the exact same thing already by simply blacklisting the
rpcsec_gss_krb5and/orauth_rpcgssmodules.I tried to keep a very small foot print... I'm not sure why that looks ad-hoc to you...
If we blacklist those module(s) then we are disabling secure mounts altogether...
What's the difference? If you use secure mounts, you really do want the NFSv4 state to be secure too.
Quoted 6 lines
Quoted 4 lines
I think we should rather looks at adding a new mount option for specifying the security flavour to use when establishing basic NFSv4.x state, and then perhaps specifying the _default_ for that mount option using a module parameter.
The problem is everything is hard code in these two areas so having a mount option would not work...
We can change that code.
Quoted 2 lines
The fact that -o sec=sys does not turn off the use of
AUTH_GSS_KRB5xis simple wrong... IMHO...
I beg to differ. The problem previously was that it _did_ set the policy for the state management, and that meant that if you has 2 mounts on the same server with different security flavours, then then client behaviour depended on the order of the mounts. Get the order wrong, and you get anything from outright errors (CLID_IN_USE) to insecure behaviour.
Quoted 7 lines
Not having way to override this behavior
is not a good thing... again... IMHO...Finally, Are there any servers out there today that support this type of behavior? Requiring secure state establishment or secure pseudoroot lookups.
Quoted 5 lines
Bruce, can we configure the Linux server to require this type security behavior? Can any server out there require these type of security behavior?
If the answer is no, then we really need a way to disable this type of behavior....
I don't disagree with the goal, I disagree with the method.
Signature · 6 lines
Trond Myklebust Linux NFS client maintainer NetApp [email protected] www.netapp.com
Quoted 4 lines · Trond
Quoted 2 lines
If we blacklist those module(s) then we are disabling secure mounts
Quoted 1 line
altogether...
What's the difference? If you use secure mounts, you really do want the NFSv4 state to be secure too.
Maybe I'm missing something via my testing.. It seems only the establishment of the state is insecure not the actual transactions using that state. So there is a window... but...
Again, what servers, today, support this type of secure state establishment? Having this type of security in the client I think is good... but if the client is not talking with any servers that support this type of security, why not have a way to turn it off?
Quoted 9 lines
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
I think we should rather looks at adding a new mount option for specifying the security flavour to use when establishing basic NFSv4.x state, and then perhaps specifying the _default_ for that mount option using a module parameter.
The problem is everything is hard code in these two areas so having a mount option would not work...
We can change that code.
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
The fact that -o sec=sys does not turn off the use of
AUTH_GSS_KRB5xis simple wrong... IMHO...I beg to differ. The problem previously was that it _did_ set the policy for the state management, and that meant that if you has 2 mounts on the same server with different security flavours, then then client behaviour depended on the order of the mounts. Get the order wrong, and you get anything from outright errors (
CLID_IN_USE) to insecure behaviour.
I see your point... but requiring all mounts to use some form of security I don't think is the answer either...
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Not having way to override this behavior
is not a good thing... again... IMHO...Finally, Are there any servers out there today that support this type of behavior? Requiring secure state establishment or secure pseudoroot lookups.
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
Bruce, can we configure the Linux server to require this type security behavior? Can any server out there require these type of security behavior?
If the answer is no, then we really need a way to disable this type of behavior....
I don't disagree with the goal, I disagree with the method.
I don't understand what you mean here... I did I say something right??? 8-)
steved.
Quoted 6 lines · Steve Dickson
Quoted 4 lines · Trond
Quoted 2 lines
If we blacklist those module(s) then we are disabling secure mounts
Quoted 1 line
altogether...
What's the difference? If you use secure mounts, you really do want the NFSv4 state to be secure too.
Quoted 8 lines
Maybe I'm missing something via my testing.. It seems only the establishment of the state is insecure not the actual transactions using that state. So there is a window... but...
Again, what servers, today, support this type of secure state establishment? Having this type of security in the client I think is good... but if the client is not talking with any servers that support this type of security, why not have a way to turn it off?
I don't understand. Servers are _required_ to support RPCSEC_GSS with krb5 by both RFC3530 and RFC5661. AUTH_SYS is, in fact, the optional flavour.
The problem here is that sometimes kerberos isn't configured by the admin, who then expects that it shouldn't be necessary to run rpc.gssd or rpc.svcgssd. It is necessary because we first try the mandatory-to-implement and secure RPCSEC_GSS/krb5i flavour before falling back to the less secure AUTH_SYS...
Quoted 10 lines
Quoted 10 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
I think we should rather looks at adding a new mount option for specifying the security flavour to use when establishing basic NFSv4.x state, and then perhaps specifying the _default_ for that mount option using a module parameter.
The problem is everything is hard code in these two areas so having a mount option would not work...
We can change that code.
Quoted 2 lines
Quoted 2 lines
The fact that -o sec=sys does not turn off the use of
AUTH_GSS_KRB5xis simple wrong... IMHO...
Quoted 7 lines
Quoted 5 lines
I beg to differ. The problem previously was that it _did_ set the policy for the state management, and that meant that if you has 2 mounts on the same server with different security flavours, then then client behaviour depended on the order of the mounts. Get the order wrong, and you get anything from outright errors (
CLID_IN_USE) to insecure behaviour.I see your point... but requiring all mounts to use some form of security I don't think is the answer either...
I'm saying that we may need a way to specify the security flavour to be used by the client's state manager when establishing the NFSv4 lease, and that would need to be done on a per-server basis.
Signature · 6 lines
Trond Myklebust Linux NFS client maintainer NetApp [email protected] www.netapp.com
Quoted 7 lines · Trond
Quoted 4 lines
Again, what servers, today, support this type of secure state establishment?
Quoted 3 lines
Having this type of security in the client I think is good... but if the client is not talking with any servers that support this type of security, why not have a way to turn it off?
I don't understand. Servers are _required_ to support
RPCSEC_GSSwith krb5 by both RFC3530 and RFC5661.AUTH_SYSis, in fact, the optional flavour.
Agreed... 100% of the NFSv4 server have to support RPCSEC_GSS. its mandated by the spec(s).
Quoted 6 lines
The problem here is that sometimes kerberos isn't configured by the admin, who then expects that it shouldn't be necessary to run rpc.gssd or rpc.svcgssd. It is necessary because we first try the mandatory-to-implement and secure RPCSEC_GSS/krb5i flavour before falling back to the less secure
AUTH_SYS...
Sometimes? Its generally not.. from my experience...
Basically how I interpret this last paragraph, is we will be requiring admins set up secure mounts for them to avoid the 15sec delay mount times... aka... running a daemon that will say "no, no there is no security here" while spewing of log messages when Kerberos is not setup...
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
I think we should rather looks at adding a new mount option for
specifying the security flavour to use when establishing basic NFSv4.x
state, and then perhaps specifying the _default_ for that mount option
using a module parameter.The problem is everything is hard code in these two areas so having a mount option would not work...
We can change that code.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
The fact that -o sec=sys does not turn off the use of
AUTH_GSS_KRB5xis simple wrong... IMHO...I beg to differ. The problem previously was that it _did_ set the policy for the state management, and that meant that if you has 2 mounts on the same server with different security flavours, then then client behaviour depended on the order of the mounts. Get the order wrong, and you get anything from outright errors (
CLID_IN_USE) to insecure behaviour.
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
I see your point... but requiring all mounts to use some form of security I don't think is the answer either...
I'm saying that we may need a way to specify the security flavour to be used by the client's state manager when establishing the NFSv4 lease, and that would need to be done on a per-server basis.
Yes! I agree... But we also have to have away turn off secure lease establishments when the server does support such technology.
I'm not saying we don't need this type of technology, I'm saying we need a better to manage it. Having this module parameter is away to manage it.
steved.
Quoted 19 lines · Steve Dickson
Quoted 7 lines · Trond
Quoted 4 lines
Again, what servers, today, support this type of secure state establishment?
Quoted 3 lines
Having this type of security in the client I think is good... but if the client is not talking with any servers that support this type of security, why not have a way to turn it off?
I don't understand. Servers are _required_ to support
RPCSEC_GSSwith krb5 by both RFC3530 and RFC5661.AUTH_SYSis, in fact, the optional flavour.Agreed... 100% of the NFSv4 server have to support
RPCSEC_GSS. its mandated by the spec(s).Quoted 6 lines
The problem here is that sometimes kerberos isn't configured by the admin, who then expects that it shouldn't be necessary to run rpc.gssd or rpc.svcgssd. It is necessary because we first try the mandatory-to-implement and secure RPCSEC_GSS/krb5i flavour before falling back to the less secure
AUTH_SYS...
Quoted 6 lines
Sometimes? Its generally not.. from my experience...
Basically how I interpret this last paragraph, is we will be requiring admins set up secure mounts for them to avoid the 15sec delay mount times... aka... running a daemon that will say "no, no there is no security here" while spewing of log messages when Kerberos is not setup...
No. All we are requiring is that they run rpc.gssd.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
[email protected]
www.netapp.com
Quoted 22 lines · Trond
Quoted 19 lines · Steve Dickson
Quoted 7 lines · Trond
Quoted 4 lines
Again, what servers, today, support this type of secure state establishment?
Quoted 3 lines
Having this type of security in the client I think is good... but if the client is not talking with any servers that support this type of security, why not have a way to turn it off?
I don't understand. Servers are _required_ to support
RPCSEC_GSSwith krb5 by both RFC3530 and RFC5661.AUTH_SYSis, in fact, the optional flavour.Agreed... 100% of the NFSv4 server have to support
RPCSEC_GSS. its mandated by the spec(s).Quoted 6 lines
The problem here is that sometimes kerberos isn't configured by the admin, who then expects that it shouldn't be necessary to run rpc.gssd or rpc.svcgssd. It is necessary because we first try the mandatory-to-implement and secure RPCSEC_GSS/krb5i flavour before falling back to the less secure
AUTH_SYS...
Quoted 8 lines
Quoted 6 lines
Sometimes? Its generally not.. from my experience...
Basically how I interpret this last paragraph, is we will be requiring admins set up secure mounts for them to avoid the 15sec delay mount times... aka... running a daemon that will say "no, no there is no security here" while spewing of log messages when Kerberos is not setup...
No. All we are requiring is that they run rpc.gssd.
Even when they do not want any secure mounts at all?
What is that justification?
steved.
Quoted 32 lines · Steve Dickson
Quoted 29 lines · Trond
Quoted 25 lines · Steve Dickson
Quoted 7 lines · Trond
Quoted 4 lines
Again, what servers, today, support this type of secure state establishment?
Quoted 3 lines
Having this type of security in the client I think is good... but if the client is not talking with any servers that support this type of security, why not have a way to turn it off?
I don't understand. Servers are _required_ to support
RPCSEC_GSSwith krb5 by both RFC3530 and RFC5661.AUTH_SYSis, in fact, the optional flavour.Agreed... 100% of the NFSv4 server have to support
RPCSEC_GSS. its mandated by the spec(s).Quoted 6 lines
The problem here is that sometimes kerberos isn't configured by the admin, who then expects that it shouldn't be necessary to run rpc.gssd or rpc.svcgssd. It is necessary because we first try the mandatory-to-implement and secure RPCSEC_GSS/krb5i flavour before falling back to the less secure
AUTH_SYS...Sometimes? Its generally not.. from my experience...
Basically how I interpret this last paragraph, is we will be requiring admins set up secure mounts for them to avoid the 15sec delay mount times... aka... running a daemon that will say "no, no there is no security here" while spewing of log messages when Kerberos is not setup...
Quoted 4 lines
Quoted 1 line
No. All we are requiring is that they run rpc.gssd.
Even when they do not want any secure mounts at all?
What is that justification?
They get to skip a 15 second wait without having to blacklist the krb5 module.
So, this is what I mean when I say that we _might_ need a mount option to specify the security flavour that the client uses for the lease. It solves the problem that Bruce mentioned about what to do when krb5i fails, and it allows admins to not have to run rpc.gssd or blacklist any modules.
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
[email protected]
www.netapp.com
Quoted 38 lines · Trond
Quoted 35 lines · Steve Dickson
Quoted 22 lines · Trond
Quoted 19 lines · Steve Dickson
Quoted 7 lines · Trond
Quoted 4 lines
Again, what servers, today, support this type of secure state establishment?
Quoted 3 lines
Having this type of security in the client I think is good... but if the client is not talking with any servers that support this type of security, why not have a way to turn it off?
I don't understand. Servers are _required_ to support
RPCSEC_GSSwith krb5 by both RFC3530 and RFC5661.AUTH_SYSis, in fact, the optional flavour.Agreed... 100% of the NFSv4 server have to support
RPCSEC_GSS. its mandated by the spec(s).Quoted 6 lines
The problem here is that sometimes kerberos isn't configured by the admin, who then expects that it shouldn't be necessary to run rpc.gssd or rpc.svcgssd. It is necessary because we first try the mandatory-to-implement and secure RPCSEC_GSS/krb5i flavour before falling back to the less secure
AUTH_SYS...Quoted 8 lines
Quoted 6 lines
Sometimes? Its generally not.. from my experience...
Basically how I interpret this last paragraph, is we will be requiring admins set up secure mounts for them to avoid the 15sec delay mount times... aka... running a daemon that will say "no, no there is no security here" while spewing of log messages when Kerberos is not setup...
No. All we are requiring is that they run rpc.gssd.
Even when they do not want any secure mounts at all?
Quoted 8 lines
Quoted 1 line
What is that justification?
They get to skip a 15 second wait without having to blacklist the krb5 module.
So, this is what I mean when I say that we _might_ need a mount option to specify the security flavour that the client uses for the lease. It solves the problem that Bruce mentioned about what to do when krb5i fails, and it allows admins to not have to run rpc.gssd or blacklist any modules.
Fine... Would mind doing a brain dump of what this mount might look like and how it work in a different thread... Since this is pretty beaten down at this point... ;-)
steved.
Quoted 11 lines
Trond
--
Trond Myklebust
Linux NFS client maintainerNetApp
[email protected]
www.netapp.com