Skip to contentSkip to conversation

mm, slub: fix the typo in include/linux/slub_def.h

PATCH In review Zhi Yong Wu 3 participants 7 messages Nov 8, 2013 – Nov 22, 2013

Subsystems (3)
Memory management Slab allocator HWPoison memory failure handling
lore
Share & tools
lore

Zhi Yong Wu

author
#0 lore raw

PATCH 1/3 mm, slub: fix the typo in include/linux/slub_def.h

From: Zhi Yong Wu <[email protected]>

Signed-off-by Zhi Yong Wu <[email protected]>
---
 include/linux/slub_def.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/slub_def.h +1 -1
index cc0b67e..f56bfa9 100644
@@ -11,7 +11,7 @@
 enum stat_item {
 	ALLOC_FASTPATH,		/* Allocation from cpu slab */
 	ALLOC_SLOWPATH,		/* Allocation by getting a new cpu slab */
-	FREE_FASTPATH,		/* Free to cpu slub */
+	FREE_FASTPATH,		/* Free to cpu slab */
 	FREE_SLOWPATH,		/* Freeing not to cpu slab */
 	FREE_FROZEN,		/* Freeing to frozen slab */
 	FREE_ADD_PARTIAL,	/* Freeing moves slab to partial list */
Signature · 1 line
1.7.6.5
author
#1 lore raw

PATCH 2/3 mm, slub: fix the typo in mm/slub.c

From: Zhi Yong Wu <[email protected]>

Signed-off-by Zhi Yong Wu <[email protected]>
---
 mm/slub.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
mm/slub.c +3 -3
index c3eb3d3..7a64327 100644
@@ -155,7 +155,7 @@ static inline bool kmem_cache_has_cpu_partial(struct kmem_cache *s)
 /*
  * Maximum number of desirable partial slabs.
  * The existence of more partial slabs makes kmem_cache_shrink
- * sort the partial list by the number of objects in the.
+ * sort the partial list by the number of objects in use.
  */
 #define MAX_PARTIAL 10
 

@@ -2829,8 +2829,8 @@ static struct kmem_cache *kmem_cache_node;
  * slab on the node for this slabcache. There are no concurrent accesses
  * possible.
  *
- * Note that this function only works on the kmalloc_node_cache
- * when allocating for the kmalloc_node_cache. This is used for bootstrapping
+ * Note that this function only works on the kmem_cache_node
+ * when allocating for the kmem_cache_node. This is used for bootstrapping
  * memory on a fresh node that has no slab structures yet.
  */
 static void early_kmem_cache_node_alloc(int node)
Signature · 7 lines
1.7.6.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
author
#3 lore raw

PATCH 3/3 mm, memory-failure: fix the typo in me_pagecache_dirty()

In reply to Zhi Yong Wu

From: Zhi Yong Wu <[email protected]>

Signed-off-by Zhi Yong Wu <[email protected]>
---
 mm/memory-failure.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
mm/memory-failure.c +1 -1
index bf3351b..d8ec181 100644
@@ -611,7 +611,7 @@ static int me_pagecache_clean(struct page *p, unsigned long pfn)
 }
 
 /*
- * Dirty cache page page
+ * Dirty cache page
  * Issues: when the error hit a hole page the error is not properly
  * propagated.
  */
Signature · 7 lines
1.7.6.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
maintainer
#5 lore raw

Re: [PATCH 3/3] mm, memory-failure: fix the typo in me_pagecache_dirty()

In reply to Zhi Yong Wu

mm/memory-failure.c static int me_pagecache_clean(struct page *p, unsigned long pfn) · line 617

Quoted 11 lines · On Fri, 8 Nov 2013 20:47:38 +0800 Zhi Yong Wu <[email protected]> wrote:
mm/memory-failure.c +1 -1
@@ -611,7 +611,7 @@ static int me_pagecache_clean(struct page *p, unsigned long pfn)
 }
 
 /*
- * Dirty cache page page
+ * Dirty cache page
  * Issues: when the error hit a hole page the error is not properly
  * propagated.
  */

The accurate and complete description of this page is actually "pagecache page", so...

mm/memory-failure.c renamed from mm/memory-failure.c~mm-memory-failure-fix-the-typo-in-me_pagecache_dirty-fix +1 -1
@@ -611,7 +611,7 @@ static int me_pagecache_clean(struct pag
 }
 
 /*
- * Dirty cache page
+ * Dirty pagecache page
  * Issues: when the error hit a hole page the error is not properly
  * propagated.
  */

_