Skip to contentSkip to conversation

linuxdoc-tools: add dependency on texinfo

PATCH In review Joe Slater 3 participants 6 messages Nov 8, 2013 – Nov 12, 2013

lore
Share & tools
lore

Joe Slater

author
#0 lore raw

PATCH 1/1 linuxdoc-tools: add dependency on texinfo

We do run makeinfo, so we want to DEPEND on texinfo-native.

---
 .../linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb +1 -1
index ba9c72e..d8122e6 100644
@@ -4,7 +4,7 @@ HOMEPAGE = "http://packages.debian.org/linuxdoc-tools"
 LICENSE = "GPLv3+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=077ef64ec3ac257fb0d786531cf26931"
 
-DEPENDS = "groff-native openjade-native"
+DEPENDS = "groff-native openjade-native texinfo-native"
 
 
 SRC_URI = "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.gz \
Signature · 1 line
1.7.3.4
#1 lore raw
Quoted 1 line · Joe Slater

We do run makeinfo, so we want to DEPEND on texinfo-native.

makeinfo is checked for by the sanity tests so we require it be present?

Cheers,

Richard

Quoted 18 lines
---
 .../linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb +1 -1
index ba9c72e..d8122e6 100644
@@ -4,7 +4,7 @@ HOMEPAGE = "http://packages.debian.org/linuxdoc-tools"
 LICENSE = "GPLv3+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=077ef64ec3ac257fb0d786531cf26931"
 
-DEPENDS = "groff-native openjade-native"
+DEPENDS = "groff-native openjade-native texinfo-native"
 
 
 SRC_URI = "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.gz \
#2 lore raw

I believe we will use the host makeinfo, if that exists, so we won't automatically build texinfo-native. But, if we are building it at the same time we are trying to run makeinfo, we might get "our" version instead of the host's, and our version might not be fully installed. At least, that looks like what happened for the build failure this patch attempts to fix.

Joe

Quoted 36 lines

-----Original Message-----
From: Richard Purdie [mailto:[email protected]]
Sent: Tuesday, November 12, 2013 2:47 AM
To: Slater, Joseph
Cc: [email protected]
Subject: Re: [OE-core] [PATCH 1/1] linuxdoc-tools: add dependency on texinfo

Quoted 1 line · Joe Slater

We do run makeinfo, so we want to DEPEND on texinfo-native.

makeinfo is checked for by the sanity tests so we require it be present?

Cheers,

Richard

Review

Quoted 6 lines
---
 .../linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb

Quoted 12 lines

index ba9c72e..d8122e6 100644

meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb +1 -1
@@ -4,7 +4,7 @@ HOMEPAGE = "http://packages.debian.org/linuxdoc-tools"
 LICENSE = "GPLv3+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=077ef64ec3ac257fb0d786531cf26931"
 
-DEPENDS = "groff-native openjade-native"
+DEPENDS = "groff-native openjade-native texinfo-native"
 
 
 SRC_URI = "${DEBIAN_MIRROR}/main/l/linuxdoc-tools/linuxdoc-tools_${PV}.orig.tar.gz \
#3 lore raw
Quoted 6 lines · Joseph

I believe we will use the host makeinfo, if that exists, so we won't automatically build texinfo-native. But, if we are building it at the same time we are trying to run makeinfo, we might get "our" version instead of the host's, and our version might not be fully installed. At least, that looks like what happened for the build failure this patch attempts to fix.

It would help to have that in the commit message.

Equally, does this really solve the problem or does it just move it elsewhere as other applications probably use makeinfo too? :/

Cheers,

Richard

#4 lore raw
Quoted 17 lines

-----Original Message-----
From: Richard Purdie [mailto:[email protected]]
Sent: Tuesday, November 12, 2013 11:45 AM
To: Slater, Joseph
Cc: [email protected]
Subject: Re: [OE-core] [PATCH 1/1] linuxdoc-tools: add dependency on texinfo

Quoted 6 lines · Joseph

I believe we will use the host makeinfo, if that exists, so we won't automatically build texinfo-native. But, if we are building it at the same time we are trying to run makeinfo, we might get "our" version instead of the host's, and our version might not be fully installed. At least, that looks like what happened for the build failure this patch attempts to fix.

Quoted 4 lines

It would help to have that in the commit message.

Equally, does this really solve the problem or does it just move it elsewhere as other applications probably use makeinfo too? :/

It does just move it elsewhere. I don't know if texinfo would be basic enough to force it to build early (I'm not sure how to do that), or if we just expect packages that need it to depend on it.

Joe

Quoted 4 lines

Cheers,

Richard

#5 lore raw
Quoted 16 lines · Joseph
Quoted 16 lines

-----Original Message-----
From: Richard Purdie [mailto:[email protected]]
Sent: Tuesday, November 12, 2013 11:45 AM
To: Slater, Joseph
Cc: [email protected]
Subject: Re: [OE-core] [PATCH 1/1] linuxdoc-tools: add dependency on texinfo

Quoted 6 lines · Joseph

I believe we will use the host makeinfo, if that exists, so we won't automatically build texinfo-native. But, if we are building it at the same time we are trying to run makeinfo, we might get "our" version instead of the host's, and our version might not be fully installed. At least, that looks like what happened for the build failure this patch attempts to fix.

Quoted 8 lines
Quoted 4 lines

It would help to have that in the commit message.

Equally, does this really solve the problem or does it just move it elsewhere as other applications probably use makeinfo too? :/

It does just move it elsewhere. I don't know if texinfo would be basic enough to force it to build early (I'm not sure how to do that), or if we just expect packages that need it to depend on it.

Could we simply not install the makeinfo binary in texinfo-native and always use the one from the host?

Cheers,

Richard