Skip to contentSkip to conversation

sysvinit: unmount the psplash lazyily

PATCH In review Saul Wold 3 participants 3 messages Nov 15, 2013 – Nov 18, 2013

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

PATCH 1/1 sysvinit: unmount the psplash lazyily

There is an race condition where psplash is not quite exited before the unmount occurs causing a umount: /mnt/.psplash: target is busy message to appear, it's ok to lazyily unmount and not get this message

[YOCTO #5244]

---
 meta/recipes-core/sysvinit/sysvinit/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/sysvinit/sysvinit/rc +1 -1
index 655a0b0..1f400d9 100755
@@ -174,6 +174,6 @@ startup() {
 if [ "x$runlevel" != "xS" ] && [ ! -x /etc/rc${runlevel}.d/S??xserver-nodm ]; then
     if type psplash-write >/dev/null 2>&1; then
         TMPDIR=/mnt/.psplash psplash-write "QUIT" || true
-    	umount /mnt/.psplash
+    	umount -l /mnt/.psplash
     fi
 fi
Signature · 1 line
1.8.3.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Saul Wold

There is an race condition where psplash is not quite exited before the unmount occurs causing a umount: /mnt/.psplash: target is busy message to appear, it's ok to lazyily unmount and not get this message

[YOCTO #5244]

Agreed.

Robert, please consider it to be included in dora. This is a simple and nice bugfix.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#2 lore raw
Quoted 7 lines · Otavio Salvador
Quoted 6 lines · Saul Wold

There is an race condition where psplash is not quite exited before the unmount occurs causing a umount: /mnt/.psplash: target is busy message to appear, it's ok to lazyily unmount and not get this message

[YOCTO #5244]

Quoted 9 lines
Quoted 1 line

Agreed.

Robert, please consider it to be included in dora. This is a simple and nice bugfix.

Hi Otavio,

Thanks, I will try to add it in dora.

// Robert