Skip to contentSkip to conversation

PCI: Disable Gen2 for Tegra20 and Tegra30

PATCH In review Eric Brower 3 participants 3 messages Nov 18, 2013 – Dec 7, 2013

Subsystems (2)
PCI Tegra architecture support
lore
Share & tools
lore

Eric Brower

author
#0 lore raw

PATCH 1/1 PCI: Disable Gen2 for Tegra20 and Tegra30

Tegra20 and Tegra30 do not support gen2 PCIe, so correct the register setting to disable it.

Signed-off-by Eric Brower <[email protected]>
---
 drivers/pci/host/pci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/host/pci-tegra.c +1 -1
index 0afbbbc..b8ba2f7 100644
@@ -805,7 +805,7 @@ static int tegra_pcie_enable_controller(struct tegra_pcie *pcie)
 	afi_writel(pcie, value, AFI_PCIE_CONFIG);
 
 	value = afi_readl(pcie, AFI_FUSE);
-	value &= ~AFI_FUSE_PCIE_T0_GEN2_DIS;
+	value |= AFI_FUSE_PCIE_T0_GEN2_DIS;
 	afi_writel(pcie, value, AFI_FUSE);
 
 	/* initialize internal PHY, enable up to 16 PCIE lanes */
Signature · 1 line
1.8.1.5
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Eric Brower

Tegra20 and Tegra30 do not support gen2 PCIe, so correct the register setting to disable it.

Signed-off-by Eric Brower <[email protected]>
---
 drivers/pci/host/pci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/host/pci-tegra.c +0 -0
index 0afbbbc..b8ba2f7 100644

drivers/pci/host/pci-tegra.c static int tegra_pcie_enable_controller(struct tegra_pcie *pcie) · line 811

Quoted 8 lines
drivers/pci/host/pci-tegra.c +1 -1
@@ -805,7 +805,7 @@ static int tegra_pcie_enable_controller(struct tegra_pcie *pcie)
 	afi_writel(pcie, value, AFI_PCIE_CONFIG);
 
 	value = afi_readl(pcie, AFI_FUSE);
-	value &= ~AFI_FUSE_PCIE_T0_GEN2_DIS;
+	value |= AFI_FUSE_PCIE_T0_GEN2_DIS;
 	afi_writel(pcie, value, AFI_FUSE);
 
 	/* initialize internal PHY, enable up to 16 PCIE lanes */

Bjorn: can you pick this up directly or would you rather have me prepare a branch? It's the only one for Tegra so far, so a branch wouldn't be all that useful. In case you want to pick it up directly:

Acked-by Thierry Reding <[email protected]>
maintainer
#2 lore raw
In reply to Eric Brower
Quoted 4 lines · Eric Brower

Tegra20 and Tegra30 do not support gen2 PCIe, so correct the register setting to disable it.

Signed-off-by Eric Brower <[email protected]>

Applied with Thierry's ack to pci/host-tegra for v3.14, thanks!

Bjorn

Quoted 20 lines
---
 drivers/pci/host/pci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/host/pci-tegra.c +1 -1
index 0afbbbc..b8ba2f7 100644
@@ -805,7 +805,7 @@ static int tegra_pcie_enable_controller(struct tegra_pcie *pcie)
 	afi_writel(pcie, value, AFI_PCIE_CONFIG);
 
 	value = afi_readl(pcie, AFI_FUSE);
-	value &= ~AFI_FUSE_PCIE_T0_GEN2_DIS;
+	value |= AFI_FUSE_PCIE_T0_GEN2_DIS;
 	afi_writel(pcie, value, AFI_FUSE);
 
 	/* initialize internal PHY, enable up to 16 PCIE lanes */
Signature · 1 line
1.8.1.5