net/phy: Add Vitesse VSC8514 PHY support
Subsystems (2)
PATCH 1/1 net/phy: Add Vitesse VSC8514 PHY support
From: Shaohui Xie <[email protected]>
The VSC8514 works in QSGMII interface. Its register set and features are similar to VSC8574 which in QSGMII mode.
--- drivers/net/phy/vitesse.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/net/phy/vitesse.c +11 -0
@@ -241,6 +241,16 @@ static struct phy_driver VSC8234_driver = { .shutdown = &genphy_shutdown, }; +static struct phy_driver VSC8514_driver = { + .name ="Vitesse VSC8514" , + .uid =0x70670 , + .mask =0xffff0 , + .features =PHY_GBIT_FEATURES , + .config = &vsc8574_config, + .startup = &vitesse_startup, + .shutdown = &genphy_shutdown, +}; +static struct phy_driver VSC8574_driver = { .name ="Vitesse VSC8574" , .uid =0x704a0 ,
@@ -310,6 +320,7 @@ int phy_vitesse_init(void)phy_register (&VSC8244_driver);phy_register (&VSC8211_driver);phy_register (&VSC8221_driver); +phy_register (&VSC8514_driver);phy_register (&VSC8574_driver);phy_register (&VSC8662_driver);phy_register (&cis8201_driver);
Signature · 1 line
1.8.0
PATCH 1/1 net/phy: Add Vitesse VSC8514 PHY support
There is a patch for VSC8514 support already circulated by Arpit and me :
http://lists.denx.de/pipermail/u-boot/2013-August/161393.html
regards,
Bhupesh
Quoted 55 lines
-----Original Message-----
From: u-boot-release-bounces at linux.freescale.net [mailto:u-boot-release- bounces at linux.freescale.net] On Behalf Of shh.xie at gmail.com
Sent: Wednesday, November 20, 2013 1:07 PM
To: u-boot at lists.denx.de; sun york-R58495
Cc: Xie Shaohui-B21989
Subject: [u-boot-release] [PATCH] net/phy: Add Vitesse VSC8514 PHY supportFrom: Shaohui Xie <[email protected]>
The VSC8514 works in QSGMII interface. Its register set and features are similar to VSC8574 which in QSGMII mode.
Signed-off-by Shaohui Xie <[email protected]>--- drivers/net/phy/vitesse.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/net/phy/vitesse.c index renamed from drivers/net/phy/vitesse.c +0
-061f863e..9af4efe 100644
drivers/net/phy/vitesse.c +11
-1@@ -241,6 +241,16 @@ static struct phy_driver VSC8234_driver = { .shutdown = &genphy_shutdown, }; +static struct phy_driver VSC8514_driver = { + .name ="Vitesse VSC8514" , + .uid =0x70670 , + .mask =0xffff0 , + .features =PHY_GBIT_FEATURES , + .config = &vsc8574_config, + .startup = &vitesse_startup, + .shutdown = &genphy_shutdown, +}; +static struct phy_driver VSC8574_driver = { .name ="Vitesse VSC8574" , .uid =0x704a0 ,@@ -310,6 +320,7 @@ int phy_vitesse_init(void)phy_register (&VSC8244_driver);phy_register (&VSC8211_driver);phy_register (&VSC8221_driver); +phy_register (&VSC8514_driver);phy_register (&VSC8574_driver);phy_register (&VSC8662_driver);phy_register (&cis8201_driver); --1.8.0
_______________________________________________
u-boot-release mailing list
u-boot-release at linux.freescale.net
http://linux.freescale.net/mailman/listinfo/u-boot-release
PATCH 1/1 net/phy: Add Vitesse VSC8514 PHY support
I do not see your patch in upstream, and I was not aware of your patch also.
For 8514 it can use the same setting as 8574.
But one interesting thing is the PHY ID in your patch is "0x70570", but the PHY ID I read from the card is "0x70670".
Roy,
Please confirm if the card installed on board is 8514.
Best Regards,
Shaohui Xie
Quoted 70 lines
-----Original Message-----
From: Sharma Bhupesh-B45370
Sent: Wednesday, November 20, 2013 4:31 PM
To: 'shh.xie at gmail.com'; 'u-boot at lists.denx.de'; sun york-R58495
Cc: Xie Shaohui-B21989; Goel Arpit-B44344
Subject: RE: [u-boot-release] [PATCH] net/phy: Add Vitesse VSC8514 PHY supportThere is a patch for VSC8514 support already circulated by Arpit and me :
http://lists.denx.de/pipermail/u-boot/2013-August/161393.htmlregards,
BhupeshQuoted 56 lines
-----Original Message-----
From: u-boot-release-bounces at linux.freescale.net [mailto:u-boot-release- bounces at linux.freescale.net] On Behalf Of shh.xie at gmail.com
Sent: Wednesday, November 20, 2013 1:07 PM
To: u-boot at lists.denx.de; sun york-R58495
Cc: Xie Shaohui-B21989
Subject: [u-boot-release] [PATCH] net/phy: Add Vitesse VSC8514 PHY supportFrom: Shaohui Xie <[email protected]>
The VSC8514 works in QSGMII interface. Its register set and features are similar to VSC8574 which in QSGMII mode.
Signed-off-by Shaohui Xie <[email protected]>--- drivers/net/phy/vitesse.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/net/phy/vitesse.c +11
-1@@ -241,6 +241,16 @@ static struct phy_driver VSC8234_driver = { .shutdown = &genphy_shutdown, }; +static struct phy_driver VSC8514_driver = { + .name ="Vitesse VSC8514" , + .uid =0x70670 , + .mask =0xffff0 , + .features =PHY_GBIT_FEATURES , + .config = &vsc8574_config, + .startup = &vitesse_startup, + .shutdown = &genphy_shutdown, +}; +static struct phy_driver VSC8574_driver = { .name ="Vitesse VSC8574" , .uid =0x704a0 ,@@ -310,6 +320,7 @@ int phy_vitesse_init(void)phy_register (&VSC8244_driver);phy_register (&VSC8211_driver);phy_register (&VSC8221_driver); +phy_register (&VSC8514_driver);phy_register (&VSC8574_driver);phy_register (&VSC8662_driver);phy_register (&cis8201_driver); --1.8.0
_______________________________________________
u-boot-release mailing list
u-boot-release at linux.freescale.net
http://linux.freescale.net/mailman/listinfo/u-boot-release
PATCH 1/1 net/phy: Add Vitesse VSC8514 PHY support
Quoted 2 lines
I do not see your patch in upstream, and I was not aware of your patch also.
I don't know why Joe has not pushed this to upstream.
Joe can you please have a look the original patch and let us know if something is amiss.
Regards,
Bhupesh
Quoted 93 lines
-----Original Message-----
From: Xie Shaohui-B21989
Sent: Wednesday, November 20, 2013 2:14 PM
To: Sharma Bhupesh-B45370; 'shh.xie at gmail.com'; 'u-boot at lists.denx.de'; sun york-R58495; Zang Roy-R61911
Cc: Goel Arpit-B44344
Subject: RE: [u-boot-release] [PATCH] net/phy: Add Vitesse VSC8514 PHY supportI do not see your patch in upstream, and I was not aware of your patch also.
For 8514 it can use the same setting as 8574.
But one interesting thing is the PHY ID in your patch is "0x70570", but the PHY ID I read from the card is "0x70670".Roy,
Please confirm if the card installed on board is 8514.Best Regards,
Shaohui XieQuoted 9 lines
-----Original Message-----
From: Sharma Bhupesh-B45370
Sent: Wednesday, November 20, 2013 4:31 PM
To: 'shh.xie at gmail.com'; 'u-boot at lists.denx.de'; sun york-R58495
Cc: Xie Shaohui-B21989; Goel Arpit-B44344
Subject: RE: [u-boot-release] [PATCH] net/phy: Add Vitesse VSC8514 PHY supportThere is a patch for VSC8514 support already circulated by Arpit and me
:
Quoted 61 lines
http://lists.denx.de/pipermail/u-boot/2013-August/161393.html
regards,
BhupeshQuoted 56 lines
-----Original Message-----
From: u-boot-release-bounces at linux.freescale.net [mailto:u-boot-release- bounces at linux.freescale.net] On Behalf Of shh.xie at gmail.com
Sent: Wednesday, November 20, 2013 1:07 PM
To: u-boot at lists.denx.de; sun york-R58495
Cc: Xie Shaohui-B21989
Subject: [u-boot-release] [PATCH] net/phy: Add Vitesse VSC8514 PHY supportFrom: Shaohui Xie <[email protected]>
The VSC8514 works in QSGMII interface. Its register set and features are similar to VSC8574 which in QSGMII mode.
Signed-off-by Shaohui Xie <[email protected]>--- drivers/net/phy/vitesse.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/net/phy/vitesse.c +11
-1@@ -241,6 +241,16 @@ static struct phy_driver VSC8234_driver = { .shutdown = &genphy_shutdown, }; +static struct phy_driver VSC8514_driver = { + .name ="Vitesse VSC8514" , + .uid =0x70670 , + .mask =0xffff0 , + .features =PHY_GBIT_FEATURES , + .config = &vsc8574_config, + .startup = &vitesse_startup, + .shutdown = &genphy_shutdown, +}; +static struct phy_driver VSC8574_driver = { .name ="Vitesse VSC8574" , .uid =0x704a0 ,@@ -310,6 +320,7 @@ int phy_vitesse_init(void)phy_register (&VSC8244_driver);phy_register (&VSC8211_driver);phy_register (&VSC8221_driver); +phy_register (&VSC8514_driver);phy_register (&VSC8574_driver);phy_register (&VSC8662_driver);phy_register (&cis8201_driver); --1.8.0
_______________________________________________
u-boot-release mailing list
u-boot-release at linux.freescale.net
http://linux.freescale.net/mailman/listinfo/u-boot-release