Skip to contentSkip to conversation

libglib2: the system PCRE needs to have UTF and UCP enabled

PATCH New Sven Neumann 2 participants 6 messages Nov 22, 2013 – Nov 25, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 2/2 libglib2: the system PCRE needs to have UTF and UCP enabled

If glib2 is compiled with the system PCRE instead of the included copy, then that system PCRE needs to have support for UTF-8 and Unicode properties enabled. Otherwise you will get such warnings at run-time:

GLib-CRITICAL **: PCRE library is compiled without UTF8 support GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support

---
 package/libglib2/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/libglib2/Config.in +1 -0
index db6a950..7cbfea5 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	select BR2_PACKAGE_LIBFFI
+	select BR2_PACKAGE_PCRE_UCP if BR2_PACKAGE_PCRE
 	select BR2_PACKAGE_ZLIB
 	depends on BR2_USE_WCHAR # gettext
 	depends on BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.8.4.2
#1 lore raw

PATCH v2 2/2 libglib2: the system PCRE needs to have UTF and UCP enabled

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

If glib2 is compiled with the system PCRE instead of the included copy, then that system PCRE needs to have support for UTF-8 and Unicode properties enabled. Otherwise you will get such warnings at run-time:

GLib-CRITICAL **: PCRE library is compiled without UTF8 support GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support

Committed to next, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH v2 2/2 libglib2: the system PCRE needs to have UTF and UCP enabled

Hello,

Quoted 7 lines · Peter Korsgaard
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

If glib2 is compiled with the system PCRE instead of the included copy, then that system PCRE needs to have support for UTF-8 and Unicode properties enabled. Otherwise you will get such warnings at run-time:

Quoted 6 lines
Quoted 4 lines

GLib-CRITICAL **: PCRE library is compiled without UTF8 support GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support

Committed to next, thanks.

May I suggest that you also merge this to the stable tree. Otherwise glib2 will be unusable on any system that also has pcre selected (which is for example pulled in by gnutls).

Regards,
Sven

Signature · 14 lines
Sven Neumann
Senior System Architect

Lautsprecher Teufel GmbH
Gewerbehof B?lowbogen - Aufgang D1
B?lowstr. 66 - 10783 Berlin - Germany

Registernummer HRB 20271 beim Amtsgericht Berlin-Charlottenburg
Gesch?ftsf?hrer: Edgar van Velzen

Tel. +49 (0)30 - 300 930 - 0, Direkt -153
neumann at teufel.de  

www.teufel.de  www.teufelaudio.com  http://blog.teufel.de
#3 lore raw

PATCH v2 2/2 libglib2: the system PCRE needs to have UTF and UCP enabled

Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Hello,

Quoted 10 lines · Peter Korsgaard
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

If glib2 is compiled with the system PCRE instead of the included copy, then that system PCRE needs to have support for UTF-8 and Unicode properties enabled. Otherwise you will get such warnings at run-time:

GLib-CRITICAL **: PCRE library is compiled without UTF8 support GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Committed to next, thanks.

May I suggest that you also merge this to the stable tree. Otherwise glib2 will be unusable on any system that also has pcre selected (which is for example pulled in by gnutls).

Hmm, ok - That wasn't completely clear to me. So even though it's just a warning, this is something critical?

When was this introduced? By the 2.36.1 -> 2.36.3 bump or is 2013.08 also affected?

For the future, it is nice if patches that should go to the current release are clearly marked as such.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH v2 2/2 libglib2: the system PCRE needs to have UTF and UCP enabled

Hi Peter,

Quoted 16 lines · Peter Korsgaard
Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Hello,

Quoted 12 lines · Peter Korsgaard
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

If glib2 is compiled with the system PCRE instead of the included copy, then that system PCRE needs to have support for UTF-8 and Unicode properties enabled. Otherwise you will get such warnings at run-time:

GLib-CRITICAL **: PCRE library is compiled without UTF8 support GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Committed to next, thanks.

May I suggest that you also merge this to the stable tree. Otherwise glib2 will be unusable on any system that also has pcre selected (which is for example pulled in by gnutls).

Hmm, ok - That wasn't completely clear to me. So even though it's just a warning, this is something critical?

Any functionality that use GRegex won't work if the system PCRE is not compiled with UTF-8 and UCP support. There might be glib-based applications that won't be affected by this, but there is a good chance that people will run into unexpected problems because of this.

Quoted 2 lines

When was this introduced? By the 2.36.1 -> 2.36.3 bump or is 2013.08 also affected?

As far as I can see this was introduced with commit fe192908a4e:

commit fe192908a4e3195b6f724310fe83fadaf18b66e7
Author: Thomas Petazzoni <[email protected]>
Date: Sat Mar 9 08:21:30 2013 +0000

libglib2: use system pcre when available

Regards,
Sven

Signature · 14 lines
Sven Neumann
Senior System Architect

Lautsprecher Teufel GmbH
Gewerbehof B?lowbogen - Aufgang D1
B?lowstr. 66 - 10783 Berlin - Germany

Registernummer HRB 20271 beim Amtsgericht Berlin-Charlottenburg
Gesch?ftsf?hrer: Edgar van Velzen

Tel. +49 (0)30 - 300 930 - 0, Direkt -153
neumann at teufel.de  

www.teufel.de  www.teufelaudio.com  http://blog.teufel.de
#5 lore raw

PATCH v2 2/2 libglib2: the system PCRE needs to have UTF and UCP enabled

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Hi,

Quoted 7 lines
Quoted 2 lines

Hmm, ok - That wasn't completely clear to me. So even though it's just a warning, this is something critical?

Any functionality that use GRegex won't work if the system PCRE is not compiled with UTF-8 and UCP support. There might be glib-based applications that won't be affected by this, but there is a good chance that people will run into unexpected problems because of this.

Ok, thanks for the details.

Quoted 10 lines
Quoted 2 lines

When was this introduced? By the 2.36.1 -> 2.36.3 bump or is 2013.08 also affected?

As far as I can see this was introduced with commit fe192908a4e:

commit fe192908a4e3195b6f724310fe83fadaf18b66e7
Author: Thomas Petazzoni <[email protected]>
Date: Sat Mar 9 08:21:30 2013 +0000

libglib2: use system pcre when available

Ok, so 2013.08 is also affected. We afaik didn't have any bug reports related to this, but I have added the 2 patches for 2013.11 - Thanks.

Signature · 1 line
Bye, Peter Korsgaard