Drivers: staging: dgap: checkpatch.pl cleanups
PATCH 1/2 Drivers: staging: dgap: checkpatch.pl cleanups
A few checkpatch cleanups, particularly:
Lines 83, 87, 89, 196: Removed spaces before tabs. Lines 141, 265.267: Removed trailing whitespace.
--- drivers/staging/dgap/dgap_conf.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/staging/dgap/dgap_conf.h +11 -11
@@ -80,13 +80,13 @@#define MC8E8K 36#define AVANFS 42/* start of Avanstar family definitions */ -#define A8P 42 +#define A8P 42#define A16P 43#define AVANFE 43/* end of Avanstar family definitions */ #define DA2000FS 44/* start of AccelePort 2000 family definitions */ -#define DA22 44/* AccelePort 2002 */ -#define DA24 45/* AccelePort 2004 */ +#define DA22 44/* AccelePort 2002 */ +#define DA24 45/* AccelePort 2004 */ #define DA28 46/* AccelePort 2008 */ #define DA216 47/* AccelePort 2016 */ #define DAR4 48/* AccelePort RAS 4 port */
@@ -138,11 +138,11 @@#define CU 91#define #define XPRINT 93 -#define CMAJOR 94 -#define ALTPIN 95 -#define STARTO 96 -#define USEINTR 97 -#define PCIINFO 98 +#define CMAJOR 94 +#define ALTPIN 95 +#define STARTO 96 +#define USEINTR 97 +#define PCIINFO 98#define TTSIZ 100#define CHSIZ 101
@@ -193,7 +193,7 @@ struct cnode {union {struct { -char type;/* Board Type */ +char type;/* Board Type */ short port;/* I/O Address */ char *portstr;/* I/O Address in string */ long addr;/* Memory Address */
@@ -262,9 +262,9 @@ struct cnode { } module;char *ttyname; - +char *cuname; - +char *printname;int majornumber;
Signature · 1 line
1.7.9.5
PATCH 2/2 Drivers: staging: dgap: checkpatch.pl cleanups
A few checkpatch cleanups, particularly:
Lines 26, 60: Removed trailing whitespace.
Lines 36-38, 42-44, 47: Removed spaces at the start of the lines.
--- drivers/staging/dgap/dgap_downld.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/staging/dgap/dgap_downld.h +11 -11
@@ -23,7 +23,7 @@*/ /* -** downld.h +** downld.h ** - describes the interface between the user level download process ** and the concentrator download driver. */
@@ -33,18 +33,18 @@struct fepimg { -int type;/* board type */ -int len;/* length of image */ -char fepimage[1 ];/* beginning of image */ +int type;/* board type */ +int len;/* length of image */ +char fepimage[1 ];/* beginning of image */ };struct downldio { -unsigned int req_type;/* FEP or concentrator */ -unsigned int bdid;/* opaque board identifier */ -union { -struct downld_t dl;/* download structure */ -struct fepimg fi;/* fep/bios image structure */ - } image; +unsigned int req_type;/* FEP or concentrator */ +unsigned int bdid;/* opaque board identifier */ +union { +struct downld_t dl;/* download structure */ +struct fepimg fi;/* fep/bios image structure */ + } image; };#define DIGI_DLREQ_GET (('d'<<8) | 220)
@@ -57,7 +57,7 @@ struct downldio {#define DIGI_NUKE_RESET_ALL (1 << 31)#define DIGI_NUKE_INHIBIT_POLLER (1 << 30)#define DIGI_NUKE_BRD_NUMB 0x0f - +#define DLREQ_BIOS 0
Signature · 1 line
1.7.9.5
drivers/staging/dgap/dgap_downld.h struct downldio { · line 63
Quoted 10 lines · Aldo Iljazi
#define
DIGI_DLREQ_GET(('d'<<8) | 220)drivers/staging/dgap/dgap_downld.h +1
-1@@ -57,7 +57,7 @@ struct downldio {#define DIGI_NUKE_RESET_ALL (1 << 31)#define DIGI_NUKE_INHIBIT_POLLER (1 << 30)#define DIGI_NUKE_BRD_NUMB 0x0f - +#define DLREQ_BIOS 0
We shouldn't have two blank lines in a row.
regards,
dan carpenter
Quoted 5 lines · Aldo Iljazi
A few checkpatch cleanups, particularly:
Lines 83, 87, 89, 196: Removed spaces before tabs. Lines 141, 265.267: Removed trailing whitespace.
Don't send two patches with the exact same subject.
regards,
dan carpenter