mtd: nand: omap: fix ecc-layout for HAM1 ecc-scheme
Subsystems (2)
PATCH 1/1 mtd: nand: omap: fix ecc-layout for HAM1 ecc-scheme
As per OMAP3530 TRM referenced below [1]
For large-page NAND, ROM code expects following ecc-layout for HAM1 ecc-scheme
- OOB[1] (offset of 1 *byte* from start of OOB) for x8 NAND device
- OOB[2] (offset of 1 *word* from start of OOB) for x16 NAND device
Thus ecc-layout expected by ROM code for HAM1 ecc-scheme is:
*for x8 NAND Device*
+--------+---------+---------+---------+---------+---------+---------+ | xxxx | ECC[A0] | ECC[A1] | ECC[A2] | ECC[B0] | ECC[B1] | ECC[B2] | ... +--------+---------+---------+---------+---------+---------+---------+
*for x16 NAND Device*
+--------+--------+---------+---------+---------+---------+---------+---------+ | xxxxx | xxxxx | ECC[A0] | ECC[A1] | ECC[A2] | ECC[B0] | ECC[B1] | ECC[B2] | +--------+--------+---------+---------+---------+---------+---------+---------+
This patch fixes ecc-layout *only* for HAM1, as required by ROM-code For other ecc-schemes like (BCH8) ecc-layout is same for x8 or x16 devices.
[1] OMAP3530: http://www.ti.com/product/omap3530
TRM: http://www.ti.com/litv/pdf/spruf98x
Chapter-25: Initialization Sub-topic: Memory Booting
Section: 25.4.7.4 NAND
Figure 25-19. ECC Locations in NAND Spare Areas
--- drivers/mtd/nand/omap_gpmc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/mtd/nand/omap_gpmc.c +6 -2
@@ -626,8 +626,12 @@ static int omap_select_ecc_scheme(struct nand_chip *nand, nand->ecc.calculate = omap_calculate_ecc;/* define ecc-layout */ ecclayout->eccbytes = nand->ecc.bytes * eccsteps; -for (i =0 ; i < ecclayout->eccbytes; i++) - ecclayout->eccpos[i] = i +BADBLOCK_MARKER_LENGTH ; +for (i =0 ; i < ecclayout->eccbytes; i++) { +if (nand->options &NAND_BUSWIDTH_16 ) + ecclayout->eccpos[i] = i +2 ; +else + ecclayout->eccpos[i] = i +1 ; + } ecclayout->oobfree[0 ].offset = i +BADBLOCK_MARKER_LENGTH ; ecclayout->oobfree[0 ].length = oobsize - ecclayout->eccbytes -BADBLOCK_MARKER_LENGTH ;
Signature · 1 line
1.8.1
PATCH 1/1 mtd: nand: omap: fix ecc-layout for HAM1 ecc-scheme
Quoted 20 lines · Pekon Gupta
As per OMAP3530 TRM referenced below [1]
For large-page NAND, ROM code expects following ecc-layout for HAM1 ecc-scheme
- OOB[1] (offset of 1 *byte* from start of OOB) for x8 NAND device
- OOB[2] (offset of 1 *word* from start of OOB) for x16 NAND deviceThus ecc-layout expected by ROM code for HAM1 ecc-scheme is:
*for x8 NAND Device*+--------+---------+---------+---------+---------+---------+---------+ | xxxx | ECC[A0] | ECC[A1] | ECC[A2] | ECC[B0] | ECC[B1] | ECC[B2] | ... +--------+---------+---------+---------+---------+---------+---------+*for x16 NAND Device*
+--------+--------+---------+---------+---------+---------+---------+---------+ | xxxxx | xxxxx | ECC[A0] | ECC[A1] | ECC[A2] | ECC[B0] | ECC[B1] | ECC[B2] | +--------+--------+---------+---------+---------+---------+---------+---------+This patch fixes ecc-layout *only* for HAM1, as required by ROM-code For other ecc-schemes like (BCH8) ecc-layout is same for x8 or x16 devices.
Quoted 8 lines
[1] OMAP3530: http://www.ti.com/product/omap3530
TRM: http://www.ti.com/litv/pdf/spruf98x
Chapter-25: Initialization Sub-topic: Memory Booting
Section: 25.4.7.4 NAND
Figure 25-19. ECC Locations in NAND Spare AreasReported-by Stefan Roese <[email protected]>Signed-off-by Pekon Gupta <[email protected]>
This fixes the problem I reported. Tested again on x8 and x16 NAND OMAP3530 targets. Thanks Pekon!
Thanks,
Stefan
Quoted 26 lines · pekon gupta
As per OMAP3530 TRM referenced below [1]
For large-page NAND, ROM code expects following ecc-layout for HAM1 ecc-scheme
- OOB[1] (offset of 1 *byte* from start of OOB) for x8 NAND device
- OOB[2] (offset of 1 *word* from start of OOB) for x16 NAND deviceThus ecc-layout expected by ROM code for HAM1 ecc-scheme is:
*for x8 NAND Device*+--------+---------+---------+---------+---------+---------+---------+ | xxxx | ECC[A0] | ECC[A1] | ECC[A2] | ECC[B0] | ECC[B1] | ECC[B2] | ... +--------+---------+---------+---------+---------+---------+---------+*for x16 NAND Device*
+--------+--------+---------+---------+---------+---------+---------+---------+ | xxxxx | xxxxx | ECC[A0] | ECC[A1] | ECC[A2] | ECC[B0] | ECC[B1] | ECC[B2] | +--------+--------+---------+---------+---------+---------+---------+---------+This patch fixes ecc-layout *only* for HAM1, as required by ROM-code For other ecc-schemes like (BCH8) ecc-layout is same for x8 or x16 devices.
[1] OMAP3530: http://www.ti.com/product/omap3530
TRM: http://www.ti.com/litv/pdf/spruf98x
Chapter-25: Initialization Sub-topic: Memory Booting
Section: 25.4.7.4 NAND
Figure 25-19. ECC Locations in NAND Spare Areas
Quoted 7 lines
Reported-by Stefan Roese <[email protected]>Signed-off-by Pekon Gupta <[email protected]>Tested-by Stefan Roese <[email protected]>---
drivers/mtd/nand/omap_gpmc.c| 8 ++++++--1 file changed, 6 insertions(+), 2 deletions(-)
Applied to u-boot-nand-flash.git
-Scott