mnl: don't set NLM_F_ACK flag in mnl_nft_rule_batch_[add|del]
Pablo Neira Ayuso
maintainerPATCH 1/1 mnl: don't set NLM_F_ACK flag in mnl_nft_rule_batch_[add|del]
If the NLM_F_ACK flag is unset, the kernel still explicitly reports errors. Thus, we can save the handling of many explicit (useless) ack messages that indicate success.
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- src/mnl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
src/mnl.c +2 -2
@@ -273,7 +273,7 @@ int mnl_nft_rule_batch_add(struct nft_rule *nlr, unsigned int flags, nlh =nft_rule_nlmsg_build_hdr (mnl_nlmsg_batch_current (batch),NFT_MSG_NEWRULE ,nft_rule_attr_get_u32 (nlr,NFT_RULE_ATTR_FAMILY ), - flags|NLM_F_ACK |NLM_F_CREATE , seqnum); + flags|NLM_F_CREATE , seqnum);nft_rule_nlmsg_build_payload (nlh, nlr);if (!mnl_nlmsg_batch_next (batch))
@@ -290,7 +290,7 @@ int mnl_nft_rule_batch_del(struct nft_rule *nlr, unsigned int flags, nlh =nft_rule_nlmsg_build_hdr (mnl_nlmsg_batch_current (batch),NFT_MSG_DELRULE ,nft_rule_attr_get_u32 (nlr,NFT_RULE_ATTR_FAMILY ), -NLM_F_ACK , seqnum); +0 , seqnum);nft_rule_nlmsg_build_payload (nlh, nlr);
Signature · 1 line
1.7.10.4