Skip to contentSkip to conversation

kernel/locking: mutex: simplify access to the first entry in the wait-list

PATCH Superseded Andrzej Pietrasiewicz 3 participants 4 messages Dec 12, 2013 Locking primitives

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/locking: mutex: simplify access to the first entry in the wait-list

Use list_first_entry instead of explicitly accessing the first entry with "head".next. The comment one line above becomes obsolete.

---
 kernel/locking/mutex.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
kernel/locking/mutex.c +2 -3
index 4dd6e4c..4af4f9c 100644
@@ -730,10 +730,9 @@ __mutex_unlock_common_slowpath(atomic_t *lock_count, int nested)
 		atomic_set(&lock->count, 1);
 
 	if (!list_empty(&lock->wait_list)) {
-		/* get the first entry from the wait-list: */
 		struct mutex_waiter *waiter =
-				list_entry(lock->wait_list.next,
-					   struct mutex_waiter, list);
+				list_first_entry(&lock->wait_list,
+						 struct mutex_waiter, list);
 
 		debug_mutex_wake_waiter(lock, waiter);
 
Signature · 1 line
1.7.0.4
#2 lore raw

W dniu 12.12.2013 10:53, Peter Zijlstra pisze:

Quoted 9 lines · Andrzej Pietrasiewicz
Quoted 5 lines

Use list_first_entry instead of explicitly accessing the first entry with "head".next. The comment one line above becomes obsolete.

This is an invalid sign-off trail.

Right... Thanks for spotting this. I will correct it and resubmit.

AP

#3 lore raw
In reply to Andrzej Pietrasiewicz
Quoted 5 lines · Andrzej Pietrasiewicz

Use list_first_entry instead of explicitly accessing the first entry with "head".next. The comment one line above becomes obsolete.

that signoff sequence looks bogus - the first SOB should be the author, the last SOB the person sending the patch. If you want to credit someone please do it elsewhere in the changelog.

Thanks,

Ingo