Skip to contentSkip to conversation

spi:rewrite the Freescale DSPI driver.

PATCH Superseded Chao Fu 2 participants 7 messages Dec 13, 2013 – Dec 16, 2013

Subsystems (5)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Chao Fu

author
#0 lore raw

PATCH v2 1/4 spi:rewrite the Freescale DSPI driver.

From: Chao Fu <[email protected]>

Freescale DSPI module is used on both the ColdFire platform and the ARM platform. The original DSPI driver is written for ColdFire platform only, this patch rewrite the driver to make it be used across the platforms. Some files, functions, variables and macros were changed accordingly for some ColdFire boards and Arm boards.
The rewrite including the following changes:

Rename the file name :

        cf_spi.c -> fsl_dspi.c
Move the file:
        arch/m68k/include/asm/coldfire/dspi.h -> include/fsl_dspi.h
Rename the functions and variables:
        cfxxx -> dspixxx
Renamed macros:
        CONFIG_CF_DSPI -> CONFIG_FSL_DSPI

Keep the following functions for ColdFire:
cfspi_port_conf()
cfspi_claim_bus()
cfspi_release_bus()
Add function for ColdFire:

        get_dspi_clk()

Tested on board M54455EVB and VF610-twr.

---
 arch/m68k/cpu/mcf5227x/cpu_init.c                  |   3 +-
 arch/m68k/cpu/mcf5227x/speed.c                     |   7 +
 arch/m68k/cpu/mcf52x2/speed.c                      |   7 +
 arch/m68k/cpu/mcf5445x/cpu_init.c                  |   3 +-
 arch/m68k/cpu/mcf5445x/speed.c                     |   7 +
 arch/m68k/include/asm/immap_5227x.h                |   1 -
 arch/m68k/include/asm/immap_5301x.h                |   1 -
 arch/m68k/include/asm/immap_5441x.h                |   1 -
 arch/m68k/include/asm/immap_5445x.h                |   1 -
 arch/m68k/include/asm/immap_547x_8x.h              |   1 -
 drivers/spi/Makefile                               |   2 +-
 drivers/spi/{cf_spi.c => fsl_dspi.c}               | 240 +++++++++++----------
 include/configs/M52277EVB.h                        |   3 +-
 include/configs/M54418TWR.h                        |   3 +-
 include/configs/M54451EVB.h                        |   3 +-
 include/configs/M54455EVB.h                        |   3 +-
 .../asm/coldfire/dspi.h => include/fsl_dspi.h      |   8 +-
 17 files changed, 156 insertions(+), 138 deletions(-)
 rename drivers/spi/{cf_spi.c => fsl_dspi.c} (56%)
 rename arch/m68k/include/asm/coldfire/dspi.h => include/fsl_dspi.h (96%)
arch/m68k/cpu/mcf5227x/cpu_init.c +2 -1
index 91b5fad..bd0b4ab 100644
@@ -16,6 +16,7 @@
 #include <asm/io.h>
 #include <asm/rtc.h>
 #include <linux/compiler.h>
+#include <fsl_dspi.h>
 
 /*
  * Breath some life into the CPU...
@@ -139,7 +140,7 @@ void uart_port_conf(int port)
 	}
 }
 
-#ifdef CONFIG_CF_DSPI
+#ifdef CONFIG_FSL_DSPI
 void cfspi_port_conf(void)
 {
 	gpio_t *gpio = (gpio_t *) MMAP_GPIO;
arch/m68k/cpu/mcf5227x/speed.c +7 -0
index 44de4a6..2bfff13 100644
@@ -124,3 +124,10 @@ int get_clocks(void)
 
 	return (0);
 }
+
+#ifdef CONFIG_FSL_DSPI
+int get_dspi_clk(void)
+{
+	return gd->bus_clk;
+}
+#endif
arch/m68k/cpu/mcf52x2/speed.c +7 -0
index c5961d4..69b49c7 100644
@@ -83,3 +83,10 @@ int get_clocks (void)
 
 	return (0);
 }
+
+#ifdef CONFIG_FSL_DSPI
+int get_dspi_clk(void)
+{
+	return gd->bus_clk;
+}
+#endif
arch/m68k/cpu/mcf5445x/cpu_init.c +2 -1
index 9c324dc..bb7a4cd 100644
@@ -16,6 +16,7 @@
 #include <asm/rtc.h>
 #include <asm/io.h>
 #include <linux/compiler.h>
+#include <fsl_dspi.h>
 
 #if defined(CONFIG_CMD_NET)
 #include <config.h>
@@ -423,7 +424,7 @@ int fecpin_setclear(struct eth_device *dev, int setclear)
 }
 #endif
 
-#ifdef CONFIG_CF_DSPI
+#ifdef CONFIG_FSL_DSPI
 void cfspi_port_conf(void)
 {
 	gpio_t *gpio = (gpio_t *) MMAP_GPIO;
arch/m68k/cpu/mcf5445x/speed.c +7 -0
index 07a9b35..29c858e 100644
@@ -279,3 +279,10 @@ int get_clocks(void)
 
 	return (0);
 }
+
+#ifdef CONFIG_FSL_DSPI
+int get_dspi_clk(void)
+{
+	return gd->bus_clk;
+}
+#endif
arch/m68k/include/asm/immap_5227x.h +0 -1
index 2cc4102..18a592e 100644
@@ -51,7 +51,6 @@
 #define MMAP_PLL	(CONFIG_SYS_MBAR + 0x000C0000)
 
 #include <asm/coldfire/crossbar.h>
-#include <asm/coldfire/dspi.h>
 #include <asm/coldfire/edma.h>
 #include <asm/coldfire/eport.h>
 #include <asm/coldfire/flexbus.h>
arch/m68k/include/asm/immap_5301x.h +0 -1
index 337fe73..6b19023 100644
@@ -52,7 +52,6 @@
 #define MMAP_ESDHC	(CONFIG_SYS_MBAR + 0x000CC000)
 
 #include <asm/coldfire/crossbar.h>
-#include <asm/coldfire/dspi.h>
 #include <asm/coldfire/edma.h>
 #include <asm/coldfire/eport.h>
 #include <asm/coldfire/flexbus.h>
arch/m68k/include/asm/immap_5441x.h +0 -1
index 4db6145..62cb681 100644
@@ -78,7 +78,6 @@
 #define MMAP_GPIO	0xEC094000
 
 #include <asm/coldfire/crossbar.h>
-#include <asm/coldfire/dspi.h>
 #include <asm/coldfire/edma.h>
 #include <asm/coldfire/eport.h>
 #include <asm/coldfire/flexbus.h>
arch/m68k/include/asm/immap_5445x.h +0 -1
index 2b12972..1525f9d 100644
@@ -55,7 +55,6 @@
 
 #include <asm/coldfire/ata.h>
 #include <asm/coldfire/crossbar.h>
-#include <asm/coldfire/dspi.h>
 #include <asm/coldfire/edma.h>
 #include <asm/coldfire/eport.h>
 #include <asm/coldfire/flexbus.h>
arch/m68k/include/asm/immap_547x_8x.h +0 -1
index e1ce220..baa7779 100644
@@ -41,7 +41,6 @@
 #define MMAP_SRAMCFG	(CONFIG_SYS_MBAR + 0x0001FF00)
 #define MMAP_SEC	(CONFIG_SYS_MBAR + 0x00020000)
 
-#include <asm/coldfire/dspi.h>
 #include <asm/coldfire/eport.h>
 #include <asm/coldfire/flexbus.h>
 #include <asm/coldfire/flexcan.h>
drivers/spi/Makefile +1 -1
index 27902fe..a047f02 100644
@@ -15,7 +15,7 @@ obj-$(CONFIG_ATMEL_DATAFLASH_SPI) += atmel_dataflash_spi.o
 obj-$(CONFIG_ATMEL_SPI) += atmel_spi.o
 obj-$(CONFIG_BFIN_SPI) += bfin_spi.o
 obj-$(CONFIG_BFIN_SPI6XX) += bfin_spi6xx.o
-obj-$(CONFIG_CF_SPI) += cf_spi.o
+obj-$(CONFIG_FSL_DSPI) += fsl_dspi.o
 obj-$(CONFIG_CF_QSPI) += cf_qspi.o
 obj-$(CONFIG_DAVINCI_SPI) += davinci_spi.o
 obj-$(CONFIG_EXYNOS_SPI) += exynos_spi.o
drivers/spi/fsl_dspi.c renamed from drivers/spi/cf_spi.c +122 -118

402 lines not on this page · raw message

include/configs/M52277EVB.h +1 -2
index cde7305..485af4c 100644
@@ -137,8 +137,7 @@
 #define CONFIG_SYS_IMMR			CONFIG_SYS_MBAR
 
 /* DSPI and Serial Flash */
-#define CONFIG_CF_SPI
-#define CONFIG_CF_DSPI
+#define CONFIG_FSL_DSPI
 #define CONFIG_HARD_SPI
 #define CONFIG_SYS_SBFHDR_SIZE		0x7
 #ifdef CONFIG_CMD_SPI
include/configs/M54418TWR.h +1 -2
index de063b7..d8bb8cd 100644
@@ -207,8 +207,7 @@
 #define CONFIG_SYS_IMMR		CONFIG_SYS_MBAR
 
 /* DSPI and Serial Flash */
-#define CONFIG_CF_SPI
-#define CONFIG_CF_DSPI
+#define CONFIG_FSL_DSPI
 #define CONFIG_SERIAL_FLASH
 #define CONFIG_HARD_SPI
 #define CONFIG_SYS_SBFHDR_SIZE		0x7
include/configs/M54451EVB.h +1 -2
index 0f4b726..7141601 100644
@@ -148,8 +148,7 @@
 #define CONFIG_SYS_IMMR			CONFIG_SYS_MBAR
 
 /* DSPI and Serial Flash */
-#define CONFIG_CF_SPI
-#define CONFIG_CF_DSPI
+#define CONFIG_FSL_DSPI
 #define CONFIG_SERIAL_FLASH
 #define CONFIG_HARD_SPI
 #define CONFIG_SYS_SBFHDR_SIZE		0x7
include/configs/M54455EVB.h +1 -2
index 7a55d3c..15b7c40 100644
@@ -181,8 +181,7 @@
 #define CONFIG_SYS_IMMR		CONFIG_SYS_MBAR
 
 /* DSPI and Serial Flash */
-#define CONFIG_CF_SPI
-#define CONFIG_CF_DSPI
+#define CONFIG_FSL_DSPI
 #define CONFIG_HARD_SPI
 #define CONFIG_SYS_SBFHDR_SIZE		0x13
 #ifdef CONFIG_CMD_SPI
include/fsl_dspi.h renamed from arch/m68k/include/asm/coldfire/dspi.h +4 -4
similarity index 96%
rename from arch/m68k/include/asm/coldfire/dspi.h
rename to include/fsl_dspi.h
index fda7138..36a352e 100644
@@ -1,8 +1,9 @@
 /*
- * MCF5227x Internal Memory Map
+ * Freescale DSPI Module Defines
  *
- * Copyright (C) 2004-2007 Freescale Semiconductor, Inc.
+ * Copyright (C) 2004-2007, 2013 Freescale Semiconductor, Inc.
  * TsiChung Liew (Tsi-Chung.Liew at freescale.com)
+ * Chao Fu (B44548 at freesacle.com)
  *
  * SPDX-License-Identifier:	GPL-2.0+
  */
@@ -19,8 +20,7 @@ typedef struct dspi {
 	u32 sr;		/* 0x2C */
 	u32 irsr;	/* 0x30 */
 	u32 tfr;	/* 0x34 - PUSHR */
-	u16 resv1;	/* 0x38 */
-	u16 rfr;	/* 0x3A - POPR */
+	u32 rfr;	/* 0x38 - POPR */
 #ifdef CONFIG_MCF547x_8x
 	u32 tfdr[4];	/* 0x3C */
 	u8 resv2[0x30];	/* 0x40 */
Signature · 1 line
1.8.4
author
#1 lore raw

PATCH v2 2/4 arm:vf610:Enable the DSPI for Freescale vf610 platform

From: Chao Fu <[email protected]>

This patch enable the DSPI moudle on VF610 platform with following udpate:
Add get_dspi_clk() function and enable DPSI clock gate.
Add DSPI iomux definition and set the iomux for DSPI.

---
Change in v2:
Separated vf610-twr update into patch 3/4.

arch/arm/cpu/armv7/vf610/generic.c | 7 +++++++

 arch/arm/include/asm/arch-vf610/clock.h       | 1 +
 arch/arm/include/asm/arch-vf610/crm_regs.h    | 1 +
 arch/arm/include/asm/arch-vf610/iomux-vf610.h | 8 ++++++++
 arch/arm/include/asm/imx-common/iomux-v3.h    | 2 ++
 5 files changed, 19 insertions(+)
arch/arm/cpu/armv7/vf610/generic.c +7 -0
index a26d63e..266343e 100644
@@ -196,6 +196,11 @@ static u32 get_i2c_clk(void)
 	return get_ipg_clk();
 }
 
+static u32 get_dspi_clk(void)
+{
+	return get_ipg_clk();
+}
+
 unsigned int mxc_get_clock(enum mxc_clock clk)
 {
 	switch (clk) {
@@ -213,6 +218,8 @@ unsigned int mxc_get_clock(enum mxc_clock clk)
 		return get_fec_clk();
 	case MXC_I2C_CLK:
 		return get_i2c_clk();
+	case MXC_DSPI_CLK:
+		return get_dspi_clk();
 	default:
 		break;
 	}
arch/arm/include/asm/arch-vf610/clock.h +1 -0
index 535adad..e5a5c6d 100644
@@ -17,6 +17,7 @@ enum mxc_clock {
 	MXC_ESDHC_CLK,
 	MXC_FEC_CLK,
 	MXC_I2C_CLK,
+	MXC_DSPI_CLK,
 };
 
 void enable_ocotp_clk(unsigned char enable);
arch/arm/include/asm/arch-vf610/crm_regs.h +1 -0
index 85f1fda..a03c627 100644
@@ -165,6 +165,7 @@ struct anadig_reg {
 
 #define CCM_REG_CTRL_MASK			0xffffffff
 #define CCM_CCGR0_UART1_CTRL_MASK		(0x3 << 16)
+#define CCM_CCGR0_DSPI0_CTRL_MASK		(0x3 << 24)
 #define CCM_CCGR1_PIT_CTRL_MASK			(0x3 << 14)
 #define CCM_CCGR1_WDOGA5_CTRL_MASK		(0x3 << 28)
 #define CCM_CCGR2_IOMUXC_CTRL_MASK		(0x3 << 16)
arch/arm/include/asm/arch-vf610/iomux-vf610.h +8 -0
index 4a39eb0..2942ebd 100644
@@ -19,6 +19,10 @@
 #define VF610_DDR_PAD_CTRL	PAD_CTL_DSE_25ohm
 #define VF610_I2C_PAD_CTRL	(PAD_CTL_PUS_47K_UP | PAD_CTL_DSE_50ohm | \
 				PAD_CTL_SPEED_HIGH | PAD_CTL_OBE_IBE_ENABLE)
+#define VF610_DSPI_PAD_CTRL	(PAD_CTL_OBE | PAD_CTL_DSE_25ohm | \
+				PAD_CTL_SPEED_MED)
+#define VF610_DSPI_SIN_PAD_CTRL	(PAD_CTL_IBE | PAD_CTL_DSE_25ohm | \
+				PAD_CTL_SPEED_MED)
 
 enum {
 	VF610_PAD_PTA6__RMII0_CLKIN		= IOMUX_PAD(0x0000, 0x0000, 2, __NA_, 0, VF610_ENET_PAD_CTRL),
@@ -41,6 +45,10 @@ enum {
 	VF610_PAD_PTA29__ESDHC1_DAT3		= IOMUX_PAD(0x004c, 0x004c, 5, __NA_, 0, VF610_SDHC_PAD_CTRL),
 	VF610_PAD_PTB14__I2C0_SCL		= IOMUX_PAD(0x0090, 0x0090, 2, 0x033c, 1, VF610_I2C_PAD_CTRL),
 	VF610_PAD_PTB15__I2C0_SDA		= IOMUX_PAD(0x0094, 0x0094, 2, 0x0340, 1, VF610_I2C_PAD_CTRL),
+	VF610_PAD_PTB19__DSPI0_CS0		= IOMUX_PAD(0x00a4, 0x00a4, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
+	VF610_PAD_PTB20__DSPI0_SIN		= IOMUX_PAD(0x00a8, 0x00a8, 1, __NA_, 0, VF610_DSPI_SIN_PAD_CTRL),
+	VF610_PAD_PTB21__DSPI0_SOUT		= IOMUX_PAD(0x00ac, 0x00ac, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
+	VF610_PAD_PTB22__DSPI0_SCK		= IOMUX_PAD(0x00b0, 0x00b0, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
 	VF610_PAD_DDR_A15__DDR_A_15		= IOMUX_PAD(0x0220, 0x0220, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
 	VF610_PAD_DDR_A14__DDR_A_14		= IOMUX_PAD(0x0224, 0x0224, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
 	VF610_PAD_DDR_A13__DDR_A_13		= IOMUX_PAD(0x0228, 0x0228, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
arch/arm/include/asm/imx-common/iomux-v3.h +2 -0
index dc2b3ef..bd07758 100644
@@ -124,6 +124,8 @@ typedef u64 iomux_v3_cfg_t;
 #define PAD_CTL_PUS_100K_UP	(2 << 4 | PAD_CTL_PUE)
 #define PAD_CTL_PKE		(1 << 3)
 #define PAD_CTL_PUE		(1 << 2 | PAD_CTL_PKE)
+#define PAD_CTL_OBE		(1 << 1)
+#define PAD_CTL_IBE		(1 << 0)
 
 #define PAD_CTL_OBE_IBE_ENABLE	(3 << 0)
 
Signature · 1 line
1.8.4
#2 lore raw

PATCH v2 2/4 arm:vf610:Enable the DSPI for Freescale vf610 platform

Quoted 99 lines · Chao Fu

From: Chao Fu <[email protected]>

This patch enable the DSPI moudle on VF610 platform with following udpate:
Add get_dspi_clk() function and enable DPSI clock gate.
Add DSPI iomux definition and set the iomux for DSPI.

---
Change in v2:
Separated vf610-twr update into patch 3/4.

arch/arm/cpu/armv7/vf610/generic.c | 7 +++++++

  arch/arm/include/asm/arch-vf610/clock.h       | 1 +
  arch/arm/include/asm/arch-vf610/crm_regs.h    | 1 +
  arch/arm/include/asm/arch-vf610/iomux-vf610.h | 8 ++++++++
  arch/arm/include/asm/imx-common/iomux-v3.h    | 2 ++
  5 files changed, 19 insertions(+)
arch/arm/cpu/armv7/vf610/generic.c +7 -0
index a26d63e..266343e 100644
@@ -196,6 +196,11 @@ static u32 get_i2c_clk(void)
      return get_ipg_clk();
  }
 
+static u32 get_dspi_clk(void)
+{
+     return get_ipg_clk();
+}
+
  unsigned int mxc_get_clock(enum mxc_clock clk)
  {
      switch (clk) {
@@ -213,6 +218,8 @@ unsigned int mxc_get_clock(enum mxc_clock clk)
              return get_fec_clk();
      case MXC_I2C_CLK:
              return get_i2c_clk();
+     case MXC_DSPI_CLK:
+             return get_dspi_clk();
      default:
              break;
      }
arch/arm/include/asm/arch-vf610/clock.h +1 -0
index 535adad..e5a5c6d 100644
@@ -17,6 +17,7 @@ enum mxc_clock {
      MXC_ESDHC_CLK,
      MXC_FEC_CLK,
      MXC_I2C_CLK,
+     MXC_DSPI_CLK,
  };
 
  void enable_ocotp_clk(unsigned char enable);
arch/arm/include/asm/arch-vf610/crm_regs.h +1 -0
index 85f1fda..a03c627 100644
@@ -165,6 +165,7 @@ struct anadig_reg {
 
  #define CCM_REG_CTRL_MASK                   0xffffffff
  #define CCM_CCGR0_UART1_CTRL_MASK           (0x3 << 16)
+#define CCM_CCGR0_DSPI0_CTRL_MASK            (0x3 << 24)
  #define CCM_CCGR1_PIT_CTRL_MASK                     (0x3 << 14)
  #define CCM_CCGR1_WDOGA5_CTRL_MASK          (0x3 << 28)
  #define CCM_CCGR2_IOMUXC_CTRL_MASK          (0x3 << 16)
arch/arm/include/asm/arch-vf610/iomux-vf610.h +8 -0
index 4a39eb0..2942ebd 100644
@@ -19,6 +19,10 @@
  #define VF610_DDR_PAD_CTRL  PAD_CTL_DSE_25ohm
  #define VF610_I2C_PAD_CTRL  (PAD_CTL_PUS_47K_UP | PAD_CTL_DSE_50ohm | \
                              PAD_CTL_SPEED_HIGH | PAD_CTL_OBE_IBE_ENABLE)
+#define VF610_DSPI_PAD_CTRL  (PAD_CTL_OBE | PAD_CTL_DSE_25ohm | \
+                             PAD_CTL_SPEED_MED)
+#define VF610_DSPI_SIN_PAD_CTRL      (PAD_CTL_IBE | PAD_CTL_DSE_25ohm | \
+                             PAD_CTL_SPEED_MED)
 
  enum {
      VF610_PAD_PTA6__RMII0_CLKIN             = IOMUX_PAD(0x0000, 0x0000, 2, __NA_, 0, VF610_ENET_PAD_CTRL),
@@ -41,6 +45,10 @@ enum {
      VF610_PAD_PTA29__ESDHC1_DAT3            = IOMUX_PAD(0x004c, 0x004c, 5, __NA_, 0, VF610_SDHC_PAD_CTRL),
      VF610_PAD_PTB14__I2C0_SCL               = IOMUX_PAD(0x0090, 0x0090, 2, 0x033c, 1, VF610_I2C_PAD_CTRL),
      VF610_PAD_PTB15__I2C0_SDA               = IOMUX_PAD(0x0094, 0x0094, 2, 0x0340, 1, VF610_I2C_PAD_CTRL),
+     VF610_PAD_PTB19__DSPI0_CS0              = IOMUX_PAD(0x00a4, 0x00a4, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
+     VF610_PAD_PTB20__DSPI0_SIN              = IOMUX_PAD(0x00a8, 0x00a8, 1, __NA_, 0, VF610_DSPI_SIN_PAD_CTRL),
+     VF610_PAD_PTB21__DSPI0_SOUT             = IOMUX_PAD(0x00ac, 0x00ac, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
+     VF610_PAD_PTB22__DSPI0_SCK              = IOMUX_PAD(0x00b0, 0x00b0, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
      VF610_PAD_DDR_A15__DDR_A_15             = IOMUX_PAD(0x0220, 0x0220, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
      VF610_PAD_DDR_A14__DDR_A_14             = IOMUX_PAD(0x0224, 0x0224, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
      VF610_PAD_DDR_A13__DDR_A_13             = IOMUX_PAD(0x0228, 0x0228, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
arch/arm/include/asm/imx-common/iomux-v3.h +0 -0
index dc2b3ef..bd07758 100644

arch/arm/include/asm/imx-common/iomux-v3.h typedef u64 iomux_v3_cfg_t; · line 131

Quoted 8 lines
arch/arm/include/asm/imx-common/iomux-v3.h +2 -0
@@ -124,6 +124,8 @@ typedef u64 iomux_v3_cfg_t;
  #define PAD_CTL_PUS_100K_UP (2 << 4 | PAD_CTL_PUE)
  #define PAD_CTL_PKE         (1 << 3)
  #define PAD_CTL_PUE         (1 << 2 | PAD_CTL_PKE)
+#define PAD_CTL_OBE          (1 << 1)
+#define PAD_CTL_IBE          (1 << 0)
 
  #define PAD_CTL_OBE_IBE_ENABLE      (3 << 0)
 

WARNING: line over 80 characters
#101: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:48:
+ VF610_PAD_PTB19__DSPI0_CS0 = IOMUX_PAD(0x00a4, 0x00a4, 1, __NA_, 0,
VF610_DSPI_PAD_CTRL),

WARNING: line over 80 characters
#102: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:49:
+ VF610_PAD_PTB20__DSPI0_SIN = IOMUX_PAD(0x00a8, 0x00a8, 1, __NA_, 0,
VF610_DSPI_SIN_PAD_CTRL),

WARNING: line over 80 characters
#103: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:50:
+ VF610_PAD_PTB21__DSPI0_SOUT = IOMUX_PAD(0x00ac, 0x00ac, 1, __NA_, 0,
VF610_DSPI_PAD_CTRL),

WARNING: line over 80 characters
#104: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:51:
+ VF610_PAD_PTB22__DSPI0_SCK = IOMUX_PAD(0x00b0, 0x00b0, 1, __NA_, 0,
VF610_DSPI_PAD_CTRL),

total: 0 errors, 4 warnings, 0 checks, 61 lines checked

--
Thanks,
Jagan.

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

author
#3 lore raw

PATCH v2 2/4 arm:vf610:Enable the DSPI for Freescale vf610 platform

Quoted 25 lines

WARNING: line over 80 characters
#101: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:48:
+ VF610_PAD_PTB19__DSPI0_CS0 = IOMUX_PAD(0x00a4,
0x00a4, 1, __NA_, 0,
VF610_DSPI_PAD_CTRL),

WARNING: line over 80 characters
#102: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:49:
+ VF610_PAD_PTB20__DSPI0_SIN = IOMUX_PAD(0x00a8,
0x00a8, 1, __NA_, 0,
VF610_DSPI_SIN_PAD_CTRL),

WARNING: line over 80 characters
#103: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:50:
+ VF610_PAD_PTB21__DSPI0_SOUT = IOMUX_PAD(0x00ac,
0x00ac, 1, __NA_, 0,
VF610_DSPI_PAD_CTRL),

WARNING: line over 80 characters
#104: FILE: arch/arm/include/asm/arch-vf610/iomux-vf610.h:51:
+ VF610_PAD_PTB22__DSPI0_SCK = IOMUX_PAD(0x00b0,
0x00b0, 1, __NA_, 0,
VF610_DSPI_PAD_CTRL),

Quoted 8 lines

total: 0 errors, 4 warnings, 0 checks, 61 lines checked

--
Thanks,
Jagan.

Dear Jagan,

Thank you! Our team hope this code about iomux definition orderliness and striking , we will keep the format , so the code every line in original file is over 80 characters. Do you think so?

       VF610_PAD_PTB15__I2C0_SDA               = IOMUX_PAD(0x0094, 0x0094, 2, 0x0340, 1, VF610_I2C_PAD_CTRL),
 +     VF610_PAD_PTB19__DSPI0_CS0              = IOMUX_PAD(0x00a4, 0x00a4, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
 +     VF610_PAD_PTB20__DSPI0_SIN              = IOMUX_PAD(0x00a8, 0x00a8, 1, __NA_, 0, VF610_DSPI_SIN_PAD_CTRL),
 +     VF610_PAD_PTB21__DSPI0_SOUT             = IOMUX_PAD(0x00ac, 0x00ac, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
 +     VF610_PAD_PTB22__DSPI0_SCK              = IOMUX_PAD(0x00b0, 0x00b0, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
       VF610_PAD_DDR_A15__DDR_A_15             = IOMUX_PAD(0x0220, 0x0220, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
       VF610_PAD_DDR_A14__DDR_A_14             = IOMUX_PAD(0x0224, 0x0224, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
       VF610_PAD_DDR_A13__DDR_A_13             = IOMUX_PAD(0x0228, 0x0228, 0, __NA_, 0, VF610_DDR_PAD_CTRL),

If we modify it . It looks as following:

      VF610_PAD_PTB15__I2C0_SDA
		= IOMUX_PAD(0x0094, 0x0094, 2, 0x0340, 1, VF610_I2C_PAD_CTRL),
      VF610_PAD_PTB19__DSPI0_CS0
		= IOMUX_PAD(0x00a4, 0x00a4, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
      VF610_PAD_PTB20__DSPI0_SIN
		= IOMUX_PAD(0x00a8, 0x00a8, 1, __NA_, 0, VF610_DSPI_SIN_PAD_CTRL),
      VF610_PAD_PTB21__DSPI0_SOUT
		= IOMUX_PAD(0x00ac, 0x00ac, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
      VF610_PAD_PTB22__DSPI0_SCK
		= IOMUX_PAD(0x00b0, 0x00b0, 1, __NA_, 0, VF610_DSPI_PAD_CTRL),
      VF610_PAD_DDR_A15__DDR_A_15
		= IOMUX_PAD(0x0220, 0x0220, 0, __NA_, 0, VF610_DDR_PAD_CTRL),
	...

Best Regards,
Fu Chao

author
#4 lore raw

PATCH v2 3/4 arm:vf610:vf610-twr:Enable the DSPI for Freesacale vf610-twr board

In reply to Chao Fu

From: Chao Fu <[email protected]>

Enable DSPI iomux for vf610twr board.
Add the SPI configuration for vf610twr board.

---
Change in v2 :
New.

 board/freescale/vf610twr/vf610twr.c | 15 ++++++++++++++-
 include/configs/vf610twr.h          | 15 +++++++++++++++
 2 files changed, 29 insertions(+), 1 deletion(-)
board/freescale/vf610twr/vf610twr.c +14 -1
index 699ea7f..ee6612f 100644
@@ -278,6 +278,18 @@ static void setup_iomux_i2c(void)
 	imx_iomux_v3_setup_multiple_pads(i2c0_pads, ARRAY_SIZE(i2c0_pads));
 }
 
+static void setup_iomux_dspi(void)
+{
+	static const iomux_v3_cfg_t dspi0_pads[] = {
+		VF610_PAD_PTB19__DSPI0_CS0,
+		VF610_PAD_PTB20__DSPI0_SIN,
+		VF610_PAD_PTB21__DSPI0_SOUT,
+		VF610_PAD_PTB22__DSPI0_SCK,
+	};
+
+	imx_iomux_v3_setup_multiple_pads(dspi0_pads, ARRAY_SIZE(dspi0_pads));
+}
+
 #ifdef CONFIG_FSL_ESDHC
 struct fsl_esdhc_cfg esdhc_cfg[1] = {
 	{ESDHC1_BASE_ADDR},
@@ -315,7 +327,7 @@ static void clock_init(void)
 	struct anadig_reg *anadig = (struct anadig_reg *)ANADIG_BASE_ADDR;
 
 	clrsetbits_le32(&ccm->ccgr0, CCM_REG_CTRL_MASK,
-		CCM_CCGR0_UART1_CTRL_MASK);
+		CCM_CCGR0_UART1_CTRL_MASK | CCM_CCGR0_DSPI0_CTRL_MASK);
 	clrsetbits_le32(&ccm->ccgr1, CCM_REG_CTRL_MASK,
 		CCM_CCGR1_PIT_CTRL_MASK | CCM_CCGR1_WDOGA5_CTRL_MASK);
 	clrsetbits_le32(&ccm->ccgr2, CCM_REG_CTRL_MASK,
@@ -386,6 +398,7 @@ int board_early_init_f(void)
 	setup_iomux_uart();
 	setup_iomux_enet();
 	setup_iomux_i2c();
+	setup_iomux_dspi();
 
 	return 0;
 }
include/configs/vf610twr.h +15 -0
index 8d0a00d..73f96e7 100644
@@ -74,6 +74,21 @@
 #define CONFIG_SYS_I2C_MXC
 #define CONFIG_SYS_SPD_BUS_NUM		0
 
+/* DSPI Configs */
+#define CONFIG_CMD_SPI
+#define CONFIG_CMD_SF
+#define CONFIG_FSL_DSPI
+#define CONFIG_SPI_FLASH
+#define CONFIG_SPI_FLASH_ATMEL
+#define MMAP_DSPI  SPI0_BASE_ADDR
+#define CONFIG_SYS_DSPI_CTAR0	(DSPI_CTAR_TRSZ(7) | \
+					 DSPI_CTAR_PCSSCK_1CLK | \
+					 DSPI_CTAR_PASC(0) | \
+					 DSPI_CTAR_PDT(0) | \
+					 DSPI_CTAR_CSSCK(0) | \
+					 DSPI_CTAR_ASC(0) | \
+					 DSPI_CTAR_DT(0))
+
 #define CONFIG_BOOTDELAY		3
 
 #define CONFIG_LOADADDR			0x82000000
Signature · 1 line
1.8.4
author
#5 lore raw

PATCH v2 4/4 mtd:vf610twr:add flash at26df081a for vf610twr platform

In reply to Chao Fu

From: Chao Fu <[email protected]>

AT26DF081 is used on vf610twr board through the DSPI bus, this patch add AT26DF081 into the spi flash params table.

---
Change in v2: None

 drivers/mtd/spi/sf_probe.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi/sf_probe.c +1 -0
index 5eb8ffe..4df1961 100644
@@ -47,6 +47,7 @@ static const struct spi_flash_params spi_flash_params_table[] = {
 	{"AT45DB321D",	   0x1f2700, 0x0,	64 * 1024,    64,	       SECT_4K},
 	{"AT45DB641D",	   0x1f2800, 0x0,	64 * 1024,   128,	       SECT_4K},
 	{"AT25DF321",      0x1f4701, 0x0,	64 * 1024,    64,	       SECT_4K},
+	{"AT26DF081",      0x1f4501, 0x0,	64 * 1024,    64,	       SECT_4K},
 #endif
 #ifdef CONFIG_SPI_FLASH_EON		/* EON */
 	{"EN25Q32B",	   0x1c3016, 0x0,	64 * 1024,    64,	             0},
Signature · 1 line
1.8.4
#6 lore raw

PATCH v2 1/4 spi:rewrite the Freescale DSPI driver.

In reply to Chao Fu

Hi Chao Fu,

Please check the checkpatch.pl issues.

Quoted 707 lines · Chao Fu

From: Chao Fu <[email protected]>

Freescale DSPI module is used on both the ColdFire platform and the ARM platform. The original DSPI driver is written for ColdFire platform only, this patch rewrite the driver to make it be used across the platforms. Some files, functions, variables and macros were changed accordingly for some ColdFire boards and Arm boards.
The rewrite including the following changes:

Rename the file name :

         cf_spi.c -> fsl_dspi.c
Move the file:
         arch/m68k/include/asm/coldfire/dspi.h -> include/fsl_dspi.h
Rename the functions and variables:
         cfxxx -> dspixxx
Renamed macros:
         CONFIG_CF_DSPI -> CONFIG_FSL_DSPI

Keep the following functions for ColdFire:
cfspi_port_conf()
cfspi_claim_bus()
cfspi_release_bus()
Add function for ColdFire:

         get_dspi_clk()

Tested on board M54455EVB and VF610-twr.

---
  arch/m68k/cpu/mcf5227x/cpu_init.c                  |   3 +-
  arch/m68k/cpu/mcf5227x/speed.c                     |   7 +
  arch/m68k/cpu/mcf52x2/speed.c                      |   7 +
  arch/m68k/cpu/mcf5445x/cpu_init.c                  |   3 +-
  arch/m68k/cpu/mcf5445x/speed.c                     |   7 +
  arch/m68k/include/asm/immap_5227x.h                |   1 -
  arch/m68k/include/asm/immap_5301x.h                |   1 -
  arch/m68k/include/asm/immap_5441x.h                |   1 -
  arch/m68k/include/asm/immap_5445x.h                |   1 -
  arch/m68k/include/asm/immap_547x_8x.h              |   1 -
  drivers/spi/Makefile                               |   2 +-
  drivers/spi/{cf_spi.c => fsl_dspi.c}               | 240 +++++++++++----------
  include/configs/M52277EVB.h                        |   3 +-
  include/configs/M54418TWR.h                        |   3 +-
  include/configs/M54451EVB.h                        |   3 +-
  include/configs/M54455EVB.h                        |   3 +-
  .../asm/coldfire/dspi.h => include/fsl_dspi.h      |   8 +-
  17 files changed, 156 insertions(+), 138 deletions(-)

rename drivers/spi/{cf_spi.c => fsl_dspi.c} (56%)
rename arch/m68k/include/asm/coldfire/dspi.h => include/fsl_dspi.h (96%)

arch/m68k/cpu/mcf5227x/cpu_init.c +2 -1
index 91b5fad..bd0b4ab 100644
@@ -16,6 +16,7 @@
  #include <asm/io.h>
  #include <asm/rtc.h>
  #include <linux/compiler.h>
+#include <fsl_dspi.h>
 
  /*
   * Breath some life into the CPU...
@@ -139,7 +140,7 @@ void uart_port_conf(int port)
      }
  }
 
-#ifdef CONFIG_CF_DSPI
+#ifdef CONFIG_FSL_DSPI
  void cfspi_port_conf(void)
  {
      gpio_t *gpio = (gpio_t *) MMAP_GPIO;
arch/m68k/cpu/mcf5227x/speed.c +7 -0
index 44de4a6..2bfff13 100644
@@ -124,3 +124,10 @@ int get_clocks(void)
 
      return (0);
  }
+
+#ifdef CONFIG_FSL_DSPI
+int get_dspi_clk(void)
+{
+     return gd->bus_clk;
+}
+#endif
arch/m68k/cpu/mcf52x2/speed.c +7 -0
index c5961d4..69b49c7 100644
@@ -83,3 +83,10 @@ int get_clocks (void)
 
      return (0);
  }
+
+#ifdef CONFIG_FSL_DSPI
+int get_dspi_clk(void)
+{
+     return gd->bus_clk;
+}
+#endif
arch/m68k/cpu/mcf5445x/cpu_init.c +2 -1
index 9c324dc..bb7a4cd 100644
@@ -16,6 +16,7 @@
  #include <asm/rtc.h>
  #include <asm/io.h>
  #include <linux/compiler.h>
+#include <fsl_dspi.h>
 
  #if defined(CONFIG_CMD_NET)
  #include <config.h>
@@ -423,7 +424,7 @@ int fecpin_setclear(struct eth_device *dev, int setclear)
  }
  #endif
 
-#ifdef CONFIG_CF_DSPI
+#ifdef CONFIG_FSL_DSPI
  void cfspi_port_conf(void)
  {
      gpio_t *gpio = (gpio_t *) MMAP_GPIO;
arch/m68k/cpu/mcf5445x/speed.c +7 -0
index 07a9b35..29c858e 100644
@@ -279,3 +279,10 @@ int get_clocks(void)
 
      return (0);
  }
+
+#ifdef CONFIG_FSL_DSPI
+int get_dspi_clk(void)
+{
+     return gd->bus_clk;
+}
+#endif
arch/m68k/include/asm/immap_5227x.h +0 -1
index 2cc4102..18a592e 100644
@@ -51,7 +51,6 @@
  #define MMAP_PLL    (CONFIG_SYS_MBAR + 0x000C0000)
 
  #include <asm/coldfire/crossbar.h>
-#include <asm/coldfire/dspi.h>
  #include <asm/coldfire/edma.h>
  #include <asm/coldfire/eport.h>
  #include <asm/coldfire/flexbus.h>
arch/m68k/include/asm/immap_5301x.h +0 -1
index 337fe73..6b19023 100644
@@ -52,7 +52,6 @@
  #define MMAP_ESDHC  (CONFIG_SYS_MBAR + 0x000CC000)
 
  #include <asm/coldfire/crossbar.h>
-#include <asm/coldfire/dspi.h>
  #include <asm/coldfire/edma.h>
  #include <asm/coldfire/eport.h>
  #include <asm/coldfire/flexbus.h>
arch/m68k/include/asm/immap_5441x.h +0 -1
index 4db6145..62cb681 100644
@@ -78,7 +78,6 @@
  #define MMAP_GPIO   0xEC094000
 
  #include <asm/coldfire/crossbar.h>
-#include <asm/coldfire/dspi.h>
  #include <asm/coldfire/edma.h>
  #include <asm/coldfire/eport.h>
  #include <asm/coldfire/flexbus.h>
arch/m68k/include/asm/immap_5445x.h +0 -1
index 2b12972..1525f9d 100644
@@ -55,7 +55,6 @@
 
  #include <asm/coldfire/ata.h>
  #include <asm/coldfire/crossbar.h>
-#include <asm/coldfire/dspi.h>
  #include <asm/coldfire/edma.h>
  #include <asm/coldfire/eport.h>
  #include <asm/coldfire/flexbus.h>
arch/m68k/include/asm/immap_547x_8x.h +0 -1
index e1ce220..baa7779 100644
@@ -41,7 +41,6 @@
  #define MMAP_SRAMCFG        (CONFIG_SYS_MBAR + 0x0001FF00)
  #define MMAP_SEC    (CONFIG_SYS_MBAR + 0x00020000)
 
-#include <asm/coldfire/dspi.h>
  #include <asm/coldfire/eport.h>
  #include <asm/coldfire/flexbus.h>
  #include <asm/coldfire/flexcan.h>
drivers/spi/Makefile +1 -1
index 27902fe..a047f02 100644
@@ -15,7 +15,7 @@ obj-$(CONFIG_ATMEL_DATAFLASH_SPI) += atmel_dataflash_spi.o
  obj-$(CONFIG_ATMEL_SPI) += atmel_spi.o
  obj-$(CONFIG_BFIN_SPI) += bfin_spi.o
  obj-$(CONFIG_BFIN_SPI6XX) += bfin_spi6xx.o
-obj-$(CONFIG_CF_SPI) += cf_spi.o
+obj-$(CONFIG_FSL_DSPI) += fsl_dspi.o
  obj-$(CONFIG_CF_QSPI) += cf_qspi.o
  obj-$(CONFIG_DAVINCI_SPI) += davinci_spi.o
  obj-$(CONFIG_EXYNOS_SPI) += exynos_spi.o
drivers/spi/fsl_dspi.c renamed from drivers/spi/cf_spi.c +122 -118
similarity index 56%
rename from drivers/spi/cf_spi.c
rename to drivers/spi/fsl_dspi.c
index 879a809..47ac1f8 100644
@@ -1,10 +1,10 @@
  /*
- *
   * (C) Copyright 2000-2003
   * Wolfgang Denk, DENX Software Engineering, wd at denx.de.
   *
- * Copyright (C) 2004-2009 Freescale Semiconductor, Inc.
+ * Copyright (C) 2004-2009, 2013 Freescale Semiconductor, Inc.
   * TsiChung Liew (Tsi-Chung.Liew at freescale.com)
+ * Chao Fu (B44548 at freescale.com)
   *
   * SPDX-License-Identifier: GPL-2.0+
   */
@@ -12,26 +12,28 @@
  #include <common.h>
  #include <spi.h>
  #include <malloc.h>
+#include <asm/io.h>
+#include <fsl_dspi.h>
+
+#ifdef CONFIG_VF610
+#include <asm/arch/clock.h>
+#endif
+
+#ifndef CONFIG_VF610
  #include <asm/immap.h>
+#endif
 
-struct cf_spi_slave {
+struct dspi_slave {
      struct spi_slave slave;
+     struct dspi *regs;
      uint baudrate;
      int charbit;
  };
 
-int cfspi_xfer(struct spi_slave *slave, uint bitlen, const void *dout,
-            void *din, ulong flags);
-struct spi_slave *cfspi_setup_slave(struct cf_spi_slave *cfslave, uint mode);
-void cfspi_init(void);
-void cfspi_tx(u32 ctrl, u16 data);
-u16 cfspi_rx(void);
-
-extern void cfspi_port_conf(void);
-extern int cfspi_claim_bus(uint bus, uint cs);
-extern void cfspi_release_bus(uint bus, uint cs);
-
-DECLARE_GLOBAL_DATA_PTR;
+static inline struct dspi_slave *to_dspi_spi(struct spi_slave *slave)
+{
+     return container_of(slave, struct dspi_slave, slave);
+}
 
  #ifndef CONFIG_SPI_IDLE_VAL
  #if defined(CONFIG_SPI_MMC)
@@ -41,77 +43,37 @@ DECLARE_GLOBAL_DATA_PTR;
  #endif
  #endif
 
-#if defined(CONFIG_CF_DSPI)
+#if defined(CONFIG_FSL_DSPI)
  /* DSPI specific mode */
  #define SPI_MODE_MOD        0x00200000
  #define SPI_DBLRATE 0x00100000
 
-void cfspi_init(void)
-{
-     volatile dspi_t *dspi = (dspi_t *) MMAP_DSPI;
-
-     cfspi_port_conf();      /* port configuration */
-
-     dspi->mcr = DSPI_MCR_MSTR | DSPI_MCR_CSIS7 | DSPI_MCR_CSIS6 |
-         DSPI_MCR_CSIS5 | DSPI_MCR_CSIS4 | DSPI_MCR_CSIS3 |
-         DSPI_MCR_CSIS2 | DSPI_MCR_CSIS1 | DSPI_MCR_CSIS0 |
-         DSPI_MCR_CRXF | DSPI_MCR_CTXF;
-
-     /* Default setting in platform configuration */
-#ifdef CONFIG_SYS_DSPI_CTAR0
-     dspi->ctar[0] = CONFIG_SYS_DSPI_CTAR0;
-#endif
-#ifdef CONFIG_SYS_DSPI_CTAR1
-     dspi->ctar[1] = CONFIG_SYS_DSPI_CTAR1;
-#endif
-#ifdef CONFIG_SYS_DSPI_CTAR2
-     dspi->ctar[2] = CONFIG_SYS_DSPI_CTAR2;
-#endif
-#ifdef CONFIG_SYS_DSPI_CTAR3
-     dspi->ctar[3] = CONFIG_SYS_DSPI_CTAR3;
-#endif
-#ifdef CONFIG_SYS_DSPI_CTAR4
-     dspi->ctar[4] = CONFIG_SYS_DSPI_CTAR4;
-#endif
-#ifdef CONFIG_SYS_DSPI_CTAR5
-     dspi->ctar[5] = CONFIG_SYS_DSPI_CTAR5;
-#endif
-#ifdef CONFIG_SYS_DSPI_CTAR6
-     dspi->ctar[6] = CONFIG_SYS_DSPI_CTAR6;
-#endif
-#ifdef CONFIG_SYS_DSPI_CTAR7
-     dspi->ctar[7] = CONFIG_SYS_DSPI_CTAR7;
-#endif
-}
-
-void cfspi_tx(u32 ctrl, u16 data)
+static void dspi_tx(struct dspi_slave *dspislave, u32 ctrl, u16 data)
  {
-     volatile dspi_t *dspi = (dspi_t *) MMAP_DSPI;
-
-     while ((dspi->sr & 0x0000F000) >= 4) ;
+     while ((readl(&dspislave->regs->sr) & 0x0000F000) >= 4)
+             ;
 
-     dspi->tfr = (ctrl | data);
+     writel((ctrl | data), &dspislave->regs->tfr);
  }
 
-u16 cfspi_rx(void)
+static u16 dspi_rx(struct dspi_slave *dspislave)
  {
-     volatile dspi_t *dspi = (dspi_t *) MMAP_DSPI;
+     while ((readl(&dspislave->regs->sr) & 0x000000F0) == 0)
+             ;
 
-     while ((dspi->sr & 0x000000F0) == 0) ;
-
-     return (dspi->rfr & 0xFFFF);
+     return (u16)(readl(&dspislave->regs->rfr) & 0xFFFF);
  }
 
-int cfspi_xfer(struct spi_slave *slave, uint bitlen, const void *dout,
+int dspi_xfer(struct spi_slave *slave, uint bitlen, const void *dout,
             void *din, ulong flags)
  {
-     struct cf_spi_slave *cfslave = (struct cf_spi_slave *)slave;
+     struct dspi_slave *dspislave = to_dspi_spi(slave);
      u16 *spi_rd16 = NULL, *spi_wr16 = NULL;
      u8 *spi_rd = NULL, *spi_wr = NULL;
      static u32 ctrl = 0;
      uint len = bitlen >> 3;
 
-     if (cfslave->charbit == 16) {
+     if (dspislave->charbit == 16) {
              bitlen >>= 1;
              spi_wr16 = (u16 *) dout;
              spi_rd16 = (u16 *) din;
@@ -129,19 +91,19 @@ int cfspi_xfer(struct spi_slave *slave, uint bitlen, const void *dout,
              int tmp_len = len - 1;
              while (tmp_len--) {
                      if (dout != NULL) {
-                             if (cfslave->charbit == 16)
-                                     cfspi_tx(ctrl, *spi_wr16++);
+                             if (dspislave->charbit == 16)
+                                     dspi_tx(dspislave, ctrl, *spi_wr16++);
                              else
-                                     cfspi_tx(ctrl, *spi_wr++);
-                             cfspi_rx();
+                                     dspi_tx(dspislave, ctrl, *spi_wr++);
+                             dspi_rx(dspislave);
                      }
 
                      if (din != NULL) {
-                             cfspi_tx(ctrl, CONFIG_SPI_IDLE_VAL);
-                             if (cfslave->charbit == 16)
-                                     *spi_rd16++ = cfspi_rx();
+                             dspi_tx(dspislave, ctrl, CONFIG_SPI_IDLE_VAL);
+                             if (dspislave->charbit == 16)
+                                     *spi_rd16++ = dspi_rx(dspislave);
                              else
-                                     *spi_rd++ = cfspi_rx();
+                                     *spi_rd++ = dspi_rx(dspislave);
                      }
              }
 
@@ -153,30 +115,30 @@ int cfspi_xfer(struct spi_slave *slave, uint bitlen, const void *dout,
 
      if (len) {
              if (dout != NULL) {
-                     if (cfslave->charbit == 16)
-                             cfspi_tx(ctrl, *spi_wr16);
+                     if (dspislave->charbit == 16)
+                             dspi_tx(dspislave, ctrl, *spi_wr16);
                      else
-                             cfspi_tx(ctrl, *spi_wr);
-                     cfspi_rx();
+                             dspi_tx(dspislave, ctrl, *spi_wr);
+                     dspi_rx(dspislave);
              }
 
              if (din != NULL) {
-                     cfspi_tx(ctrl, CONFIG_SPI_IDLE_VAL);
-                     if (cfslave->charbit == 16)
-                             *spi_rd16 = cfspi_rx();
+                     dspi_tx(dspislave, ctrl, CONFIG_SPI_IDLE_VAL);
+                     if (dspislave->charbit == 16)
+                             *spi_rd16 = dspi_rx(dspislave);
                      else
-                             *spi_rd = cfspi_rx();
+                             *spi_rd = dspi_rx(dspislave);
              }
      } else {
              /* dummy read */
-             cfspi_tx(ctrl, CONFIG_SPI_IDLE_VAL);
-             cfspi_rx();
+             dspi_tx(dspislave, ctrl, CONFIG_SPI_IDLE_VAL);
+             dspi_rx(dspislave);
      }
 
      return 0;
  }
 
-struct spi_slave *cfspi_setup_slave(struct cf_spi_slave *cfslave, uint mode)
+struct spi_slave *dspi_setup_slave(struct dspi_slave *dspislave, uint mode)
  {
      /*
       * bit definition for mode:
@@ -191,7 +153,6 @@ struct spi_slave *cfspi_setup_slave(struct cf_spi_slave *cfslave, uint mode)
       *     11 -  8: Delay after transfer scaler
       *      7 -  0: SPI_CPHA, SPI_CPOL, SPI_LSB_FIRST
       */
-     volatile dspi_t *dspi = (dspi_t *) MMAP_DSPI;
      int prescaler[] = { 2, 3, 5, 7 };
      int scaler[] = {
              2, 4, 6, 8,
@@ -200,21 +161,63 @@ struct spi_slave *cfspi_setup_slave(struct cf_spi_slave *cfslave, uint mode)
              4096, 8192, 16384, 32768
      };
      int i, j, pbrcnt, brcnt, diff, tmp, dbr = 0;
-     int best_i, best_j, bestmatch = 0x7FFFFFFF, baud_speed;
+     int best_i, best_j, bestmatch = 0x7FFFFFFF, baud_speed, bus_clk;
      u32 bus_setup = 0;
 
+     dspislave->regs = (dspi_t *) MMAP_DSPI;
+
+#ifndef CONFIG_VF610
+     cfspi_port_conf();      /* port configuration */
+#endif
+
+     writel(DSPI_MCR_MSTR | DSPI_MCR_CSIS7 | DSPI_MCR_CSIS6 |
+             DSPI_MCR_CSIS5 | DSPI_MCR_CSIS4 | DSPI_MCR_CSIS3 |
+             DSPI_MCR_CSIS2 | DSPI_MCR_CSIS1 | DSPI_MCR_CSIS0 |
+             DSPI_MCR_CRXF | DSPI_MCR_CTXF,
+             &dspislave->regs->mcr);
+     /* Default setting in platform configuration */
+#ifdef CONFIG_SYS_DSPI_CTAR0
+     writel(CONFIG_SYS_DSPI_CTAR0, &dspislave->regs->ctar[0]);
+#endif
+#ifdef CONFIG_SYS_DSPI_CTAR1
+     writel(CONFIG_SYS_DSPI_CTAR1, &dspislave->regs->ctar[1]);
+#endif
+#ifdef CONFIG_SYS_DSPI_CTAR2
+     writel(CONFIG_SYS_DSPI_CTAR2, &dspislave->regs->ctar[2]);
+#endif
+#ifdef CONFIG_SYS_DSPI_CTAR3
+     writel(CONFIG_SYS_DSPI_CTAR3, &dspislave->regs->ctar[3]);
+#endif
+#ifdef CONFIG_SYS_DSPI_CTAR4
+     writel(CONFIG_SYS_DSPI_CTAR4, &dspislave->regs->ctar[4]);
+#endif
+#ifdef CONFIG_SYS_DSPI_CTAR5
+     writel(CONFIG_SYS_DSPI_CTAR5, &dspislave->regs->ctar[5]);
+#endif
+#ifdef CONFIG_SYS_DSPI_CTAR6
+     writel(CONFIG_SYS_DSPI_CTAR6, &dspislave->regs->ctar[6]);
+#endif
+#ifdef CONFIG_SYS_DSPI_CTAR7
+     writel(CONFIG_SYS_DSPI_CTAR7, &dspislave->regs->ctar[7]);
+#endif
+
      tmp = (prescaler[3] * scaler[15]);
+#ifdef CONFIG_VF610
+     bus_clk = mxc_get_clock(MXC_DSPI_CLK);
+#else
+     bus_clk = get_dspi_clk();
+#endif
      /* Maximum and minimum baudrate it can handle */
-     if ((cfslave->baudrate > (gd->bus_clk >> 1)) ||
-         (cfslave->baudrate < (gd->bus_clk / tmp))) {
+     if ((dspislave->baudrate > (bus_clk >> 1)) ||
+         (dspislave->baudrate < (bus_clk / tmp))) {
              printf("Exceed baudrate limitation: Max %d - Min %d\n",
-                    (int)(gd->bus_clk >> 1), (int)(gd->bus_clk / tmp));
+                    (int)(bus_clk >> 1), (int)(bus_clk / tmp));
              return NULL;
      }
 
      /* Activate Double Baud when it exceed 1/4 the bus clk */
      if ((CONFIG_SYS_DSPI_CTAR0 & DSPI_CTAR_DBR) ||
-         (cfslave->baudrate > (gd->bus_clk / (prescaler[0] * scaler[0])))) {
+         (dspislave->baudrate > (bus_clk / (prescaler[0] * scaler[0])))) {
              bus_setup |= DSPI_CTAR_DBR;
              dbr = 1;
      }
@@ -231,7 +234,8 @@ struct spi_slave *cfspi_setup_slave(struct cf_spi_slave *cfslave, uint mode)
 
              if ((mode & 0xF0000000) == 0)
                      bus_setup |=
-                         dspi->ctar[cfslave->slave.bus] & 0x78000000;
+                         readl(&dspislave->regs->ctar[dspislave->slave.bus])
+                         & 0x78000000;
              else
                      bus_setup |= ((mode & 0xF0000000) >> 1);
 
@@ -246,25 +250,26 @@ struct spi_slave *cfspi_setup_slave(struct cf_spi_slave *cfslave, uint mode)
              bus_setup |= (mode & 0x0FC00000) >> 4;  /* PSCSCK, PASC, PDT */
              bus_setup |= (mode & 0x000FFF00) >> 4;  /* CSSCK, ASC, DT */
      } else
-             bus_setup |= (dspi->ctar[cfslave->slave.bus] & 0x78FCFFF0);
+             bus_setup |= readl(&dspislave->regs->ctar[dspislave->slave.bus])
+                             & 0x78FCFFF0;
 
-     cfslave->charbit =
-         ((dspi->ctar[cfslave->slave.bus] & 0x78000000) ==
-          0x78000000) ? 16 : 8;
+     dspislave->charbit =
+         ((readl(&dspislave->regs->ctar[dspislave->slave.bus]) & 0x78000000)
+          == 0x78000000) ? 16 : 8;
 
      pbrcnt = sizeof(prescaler) / sizeof(int);
      brcnt = sizeof(scaler) / sizeof(int);
 
      /* baudrate calculation - to closer value, may not be exact match */
      for (best_i = 0, best_j = 0, i = 0; i < pbrcnt; i++) {
-             baud_speed = gd->bus_clk / prescaler[i];
+             baud_speed = bus_clk / prescaler[i];
              for (j = 0; j < brcnt; j++) {
                      tmp = (baud_speed / scaler[j]) * (1 + dbr);
 
-                     if (tmp > cfslave->baudrate)
-                             diff = tmp - cfslave->baudrate;
+                     if (tmp > dspislave->baudrate)
+                             diff = tmp - dspislave->baudrate;
                      else
-                             diff = cfslave->baudrate - tmp;
+                             diff = dspislave->baudrate - tmp;
 
                      if (diff < bestmatch) {
                              bestmatch = diff;
@@ -273,16 +278,12 @@ struct spi_slave *cfspi_setup_slave(struct cf_spi_slave *cfslave, uint mode)
                      }
              }
      }
-     bus_setup |= (DSPI_CTAR_PBR(best_i) | DSPI_CTAR_BR(best_j));
-     dspi->ctar[cfslave->slave.bus] = bus_setup;
 
-     return &cfslave->slave;
+     bus_setup |= (DSPI_CTAR_PBR(best_i) | DSPI_CTAR_BR(best_j));
+     writel(bus_setup, &dspislave->regs->ctar[dspislave->slave.bus]) ;
+     return &dspislave->slave;
  }
-#endif                               /* CONFIG_CF_DSPI */
-
-#ifdef CONFIG_CF_QSPI
-/* 52xx, 53xx */
-#endif                               /* CONFIG_CF_QSPI */
+#endif                               /* CONFIG_FSL_DSPI */
 
  #ifdef CONFIG_CMD_SPI
  int spi_cs_is_valid(unsigned int bus, unsigned int cs)
@@ -303,25 +304,22 @@ void spi_init_r(void)
 
  void spi_init(void)
  {
-     cfspi_init();
  }
 
  struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
                                unsigned int max_hz, unsigned int mode)
  {
-     struct cf_spi_slave *cfslave;
+     struct dspi_slave *dspislave;
 
      if (!spi_cs_is_valid(bus, cs))
              return NULL;
-
-     cfslave = spi_alloc_slave(struct cf_spi_slave, bus, cs);
-     if (!cfslave)
+     dspislave = spi_alloc_slave(struct dspi_slave, bus, cs);
+     if (!dspislave)
              return NULL;
 
-     cfslave->baudrate = max_hz;
-
+     dspislave->baudrate = max_hz;
      /* specific setup */
-     return cfspi_setup_slave(cfslave, mode);
+     return dspi_setup_slave(dspislave, mode);
  }
 
  void spi_free_slave(struct spi_slave *slave)
@@ -331,17 +329,23 @@ void spi_free_slave(struct spi_slave *slave)
 
  int spi_claim_bus(struct spi_slave *slave)
  {
+#ifdef CONFIG_VF610
+     return 0;
+#else
      return cfspi_claim_bus(slave->bus, slave->cs);
+#endif
  }
 
  void spi_release_bus(struct spi_slave *slave)
  {
+#ifndef CONFIG_VF610
      cfspi_release_bus(slave->bus, slave->cs);
+#endif
  }
 
  int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout,
           void *din, unsigned long flags)
  {
-     return cfspi_xfer(slave, bitlen, dout, din, flags);
+     return dspi_xfer(slave, bitlen, dout, din, flags);
  }
  #endif                              /* CONFIG_CMD_SPI */
include/configs/M52277EVB.h +1 -2
index cde7305..485af4c 100644
@@ -137,8 +137,7 @@
  #define CONFIG_SYS_IMMR                     CONFIG_SYS_MBAR
 
  /* DSPI and Serial Flash */
-#define CONFIG_CF_SPI
-#define CONFIG_CF_DSPI
+#define CONFIG_FSL_DSPI
  #define CONFIG_HARD_SPI
  #define CONFIG_SYS_SBFHDR_SIZE              0x7
  #ifdef CONFIG_CMD_SPI
include/configs/M54418TWR.h +1 -2
index de063b7..d8bb8cd 100644
@@ -207,8 +207,7 @@
  #define CONFIG_SYS_IMMR             CONFIG_SYS_MBAR
 
  /* DSPI and Serial Flash */
-#define CONFIG_CF_SPI
-#define CONFIG_CF_DSPI
+#define CONFIG_FSL_DSPI
  #define CONFIG_SERIAL_FLASH
  #define CONFIG_HARD_SPI
  #define CONFIG_SYS_SBFHDR_SIZE              0x7
include/configs/M54451EVB.h +1 -2
index 0f4b726..7141601 100644
@@ -148,8 +148,7 @@
  #define CONFIG_SYS_IMMR                     CONFIG_SYS_MBAR
 
  /* DSPI and Serial Flash */
-#define CONFIG_CF_SPI
-#define CONFIG_CF_DSPI
+#define CONFIG_FSL_DSPI
  #define CONFIG_SERIAL_FLASH
  #define CONFIG_HARD_SPI
  #define CONFIG_SYS_SBFHDR_SIZE              0x7
include/configs/M54455EVB.h +1 -2
index 7a55d3c..15b7c40 100644
@@ -181,8 +181,7 @@
  #define CONFIG_SYS_IMMR             CONFIG_SYS_MBAR
 
  /* DSPI and Serial Flash */
-#define CONFIG_CF_SPI
-#define CONFIG_CF_DSPI
+#define CONFIG_FSL_DSPI
  #define CONFIG_HARD_SPI
  #define CONFIG_SYS_SBFHDR_SIZE              0x13
  #ifdef CONFIG_CMD_SPI
include/fsl_dspi.h renamed from arch/m68k/include/asm/coldfire/dspi.h +3 -2
similarity index 96%
rename from arch/m68k/include/asm/coldfire/dspi.h
rename to include/fsl_dspi.h
index fda7138..36a352e 100644
@@ -1,8 +1,9 @@
  /*
- * MCF5227x Internal Memory Map
+ * Freescale DSPI Module Defines
   *
- * Copyright (C) 2004-2007 Freescale Semiconductor, Inc.
+ * Copyright (C) 2004-2007, 2013 Freescale Semiconductor, Inc.
   * TsiChung Liew (Tsi-Chung.Liew at freescale.com)
+ * Chao Fu (B44548 at freesacle.com)
   *
   * SPDX-License-Identifier: GPL-2.0+
   */

include/fsl_dspi.h typedef struct dspi { · line 26

Quoted 9 lines
include/fsl_dspi.h renamed from arch/m68k/include/asm/coldfire/dspi.h +1 -2
@@ -19,8 +20,7 @@ typedef struct dspi {
      u32 sr;         /* 0x2C */
      u32 irsr;       /* 0x30 */
      u32 tfr;        /* 0x34 - PUSHR */
-     u16 resv1;      /* 0x38 */
-     u16 rfr;        /* 0x3A - POPR */
+     u32 rfr;        /* 0x38 - POPR */
  #ifdef CONFIG_MCF547x_8x
      u32 tfdr[4];    /* 0x3C */
      u8 resv2[0x30]; /* 0x40 */

CHECK: No space is necessary after a cast
#461: FILE: drivers/spi/fsl_dspi.c:167:

+ dspislave->regs = (dspi_t *) MMAP_DSPI;

CHECK: space prohibited before semicolon
#576: FILE: drivers/spi/fsl_dspi.c:283:
+ writel(bus_setup, &dspislave->regs->ctar[dspislave->slave.bus]) ;

total: 0 errors, 0 warnings, 2 checks, 561 lines checked

--
Thanks,
Jagan.

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.