netfilter: nf_tables: fix dumping with large number of sets
Subsystems (2)
Pablo Neira Ayuso
maintainerPATCH 1/1 netfilter: nf_tables: fix dumping with large number of sets
If not table name is specified, the dumping of the existing sets may be incomplete with a sufficiently large number of sets spread in several tables that belong to the same family.
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- net/netfilter/nf_tables_api.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
net/netfilter/nf_tables_api.c +9 -3
@@ -2079,17 +2079,21 @@ static int nf_tables_dump_sets_all(struct nft_ctx *ctx, struct sk_buff *skb, struct netlink_callback *cb) {const struct nft_set *set; -unsigned int idx =0 , s_idx = cb->args[0 ]; +unsigned int idx, s_idx = cb->args[0 ];struct nft_table *table, *cur_table = (struct nft_table *)cb->args[2 ];if (cb->args[1 ])return skb->len;list_for_each_entry (table, &ctx->afi->tables, list) { -if (cur_table && cur_table != table) -continue ; +if (cur_table) { +if (cur_table != table) +continue ; + cur_table =NULL ; + } ctx->table = table; + idx =0 ;list_for_each_entry (set, &ctx->table->sets, list) {if (idx < s_idx) goto cont;
@@ -2102,6 +2106,8 @@ static int nf_tables_dump_sets_all(struct nft_ctx *ctx, struct sk_buff *skb, cont: idx++; } +if (s_idx) + s_idx =0 ; } cb->args[1 ] =1 ; done:
Signature · 1 line
1.7.10.4