batman-adv: use batadv_compare_eth when possible
PATCH 1/1 batman-adv: use batadv_compare_eth when possible
When comparing Ethernet address it is better to use the more generic batadv_compare_eth. The latter is also optimised for architectures having a fast unaligned access.
--- network-coding.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
network-coding.c +2 -4
@@ -481,12 +481,10 @@ static int batadv_nc_hash_compare(const struct hlist_node *node, nc_path2 = data2;/* Return 1 if the two keys are identical */ -if (memcmp (nc_path1->prev_hop, nc_path2->prev_hop, -sizeof (nc_path1->prev_hop)) !=0 ) +if (!batadv_compare_eth (nc_path1->prev_hop, nc_path2->prev_hop))return 0 ; -if (memcmp (nc_path1->next_hop, nc_path2->next_hop, -sizeof (nc_path1->next_hop)) !=0 ) +if (!batadv_compare_eth (nc_path1->next_hop, nc_path2->next_hop))return 0 ;return 1 ;
Signature · 1 line
1.8.5.2
Quoted 5 lines · Antonio Quartulli
When comparing Ethernet address it is better to use the more generic
batadv_compare_eth. The latter is also optimised for architectures having a fast unaligned access.Signed-off-by Antonio Quartulli <[email protected]>
Martin,
I forgot to add you to the CC list :) Sorry!
Cheers,
Signature · 1 line
Antonio Quartulli
Quoted 6 lines · On Sunday 05 January 2014 12:36:49 Antonio Quartulli wrote:
When comparing Ethernet address it is better to use the more generic
batadv_compare_eth. The latter is also optimised for architectures having a fast unaligned access.Signed-off-by Antonio Quartulli <[email protected]>---
It looks like this patch doesn't apply anymore. Can you please resent it or mark it correctly in patchwork [1].
But for the cleanup:
Thanks,
Sven