Skip to contentSkip to conversation

Staging: rts5139: Fixed style issues

PATCH In review Morgan Creekmore 2 participants 2 messages Jan 6, 2014 – Jan 9, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rts5139: Fixed style issues

Fixed style issues for lines over 80 chars

---
 drivers/staging/rts5139/rts51x_card.c | 10 +++++-----
 drivers/staging/rts5139/rts51x_card.h |  8 ++++----
 2 files changed, 9 insertions(+), 9 deletions(-)
drivers/staging/rts5139/rts51x_card.c +5 -5
index 509d83e..03456d9 100644
@@ -373,7 +373,7 @@ void rts51x_release_cards(struct rts51x_chip *chip)
 
 static inline u8 double_depth(u8 depth)
 {
-	return ((depth > 1) ? (depth - 1) : depth);
+	return (depth > 1) ? (depth - 1) : depth;
 }
 
 int rts51x_switch_ssc_clock(struct rts51x_chip *chip, int clk)
@@ -653,8 +653,8 @@ int rts51x_switch_normal_clock(struct rts51x_chip *chip, int clk)
 	return STATUS_SUCCESS;
 }
 
-int rts51x_card_rw(struct scsi_cmnd *srb, struct rts51x_chip *chip, u32 sec_addr,
-	    u16 sec_cnt)
+int rts51x_card_rw(struct scsi_cmnd *srb, struct rts51x_chip *chip,
+		u32 sec_addr, u16 sec_cnt)
 {
 	int retval;
 	unsigned int lun = SCSI_LUN(srb);
@@ -770,8 +770,8 @@ void rts51x_eject_card(struct rts51x_chip *chip, unsigned int lun)
 			      XD_INT | MS_INT | SD_INT);
 }
 
-void rts51x_trans_dma_enable(enum dma_data_direction dir, struct rts51x_chip *chip,
-		      u32 byte_cnt, u8 pack_size)
+void rts51x_trans_dma_enable(enum dma_data_direction dir,
+		struct rts51x_chip *chip, u32 byte_cnt, u8 pack_size)
 {
 	if (pack_size > DMA_1024)
 		pack_size = DMA_512;
drivers/staging/rts5139/rts51x_card.h +4 -4
index e62b25c..df8816e 100644
@@ -743,13 +743,13 @@ void rts51x_init_cards(struct rts51x_chip *chip);
 void rts51x_release_cards(struct rts51x_chip *chip);
 int rts51x_switch_ssc_clock(struct rts51x_chip *chip, int clk);
 int rts51x_switch_normal_clock(struct rts51x_chip *chip, int clk);
-int rts51x_card_rw(struct scsi_cmnd *srb, struct rts51x_chip *chip, u32 sec_addr,
-	    u16 sec_cnt);
+int rts51x_card_rw(struct scsi_cmnd *srb, struct rts51x_chip *chip,
+		u32 sec_addr, u16 sec_cnt);
 u8 rts51x_get_lun_card(struct rts51x_chip *chip, unsigned int lun);
 int rts51x_select_card(struct rts51x_chip *chip, int card);
 void rts51x_eject_card(struct rts51x_chip *chip, unsigned int lun);
-void rts51x_trans_dma_enable(enum dma_data_direction dir, struct rts51x_chip *chip,
-		      u32 byte_cnt, u8 pack_size);
+void rts51x_trans_dma_enable(enum dma_data_direction dir,
+		struct rts51x_chip *chip, u32 byte_cnt, u8 pack_size);
 int rts51x_enable_card_clock(struct rts51x_chip *chip, u8 card);
 int rts51x_card_power_on(struct rts51x_chip *chip, u8 card);
 int rts51x_toggle_gpio(struct rts51x_chip *chip, u8 gpio);
Signature · 1 line
1.8.3.2
maintainer
#1 lore raw
Quoted 13 lines · Morgan Creekmore

Fixed style issues for lines over 80 chars

---
 drivers/staging/rts5139/rts51x_card.c | 10 +++++-----
 drivers/staging/rts5139/rts51x_card.h |  8 ++++----
 2 files changed, 9 insertions(+), 9 deletions(-)
drivers/staging/rts5139/rts51x_card.c +0 -0
index 509d83e..03456d9 100644

drivers/staging/rts5139/rts51x_card.c void rts51x_release_cards(struct rts51x_chip *chip) · line 376

Quoted 5 lines
drivers/staging/rts5139/rts51x_card.c +1 -1
@@ -373,7 +373,7 @@ void rts51x_release_cards(struct rts51x_chip *chip)
 
 static inline u8 double_depth(u8 depth)
 {
-	return ((depth > 1) ? (depth - 1) : depth);
+	return (depth > 1) ? (depth - 1) : depth;

This fix isn't what you said you were doing in the above changelog description :(

Please be correct in your changelogs.

greg k-h