Skip to contentSkip to conversation

spi: fsl-dspi: Add missing breaks for switch cases

PATCH In review Axel Lin 3 participants 4 messages Jan 8, 2014 – Jan 13, 2014 2 messages not in the archive

Subsystems (2)
SPI Freescale dspi driver
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 spi: fsl-dspi: Add missing breaks for switch cases

Signed-off-by Axel Lin <[email protected]>
---
 drivers/spi/spi-fsl-dspi.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/spi/spi-fsl-dspi.c +2 -0
index 8641b03..a37f156 100644
@@ -320,8 +320,10 @@ static void dspi_chipselect(struct spi_device *spi, int value)
 	switch (value) {
 	case BITBANG_CS_ACTIVE:
 		pushr |= SPI_PUSHR_CONT;
+		break;
 	case BITBANG_CS_INACTIVE:
 		pushr &= ~SPI_PUSHR_CONT;
+		break;
 	}
 
 	writel(pushr, dspi->base + SPI_PUSHR);
Signature · 8 lines
1.8.1.2



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author
#1 lore raw

Hi Chao and Alison,

I'm wondering if this driver really work without this patch? Any chance to test this patch?

Regards,
Axel

2014/1/8 Axel Lin <[email protected]>:

Quoted 21 lines
Signed-off-by Axel Lin <[email protected]>
---
 drivers/spi/spi-fsl-dspi.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/spi/spi-fsl-dspi.c +2 -1
index 8641b03..a37f156 100644
@@ -320,8 +320,10 @@ static void dspi_chipselect(struct spi_device *spi, int value)
        switch (value) {
        case BITBANG_CS_ACTIVE:
                pushr |= SPI_PUSHR_CONT;
+               break;
        case BITBANG_CS_INACTIVE:
                pushr &= ~SPI_PUSHR_CONT;
+               break;
        }
 
        writel(pushr, dspi->base + SPI_PUSHR);
--
Quoted 4 lines

1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): CAFRkauCMCZr4MGDMt1GJKd8uTKWH5bX_BXB5-Ouy5vFVg6ZY0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#3 lore raw
Quoted 4 lines · Axel Lin

Hi Chao and Alison,

I'm wondering if this driver really work without this patch? Any chance to test this patch?

I applied the patch already - sorry, seems I must've forgotten to mail out.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 9 lines
Quoted 6 lines

Hi Chao and Alison,

I'm wondering if this driver really work without this patch? Any chance to test this patch?

I applied the patch already - sorry, seems I must've forgotten to mail out.

[Chao Fu] Hi Axel , Mark,
Sorry for this careless omission. But no break it is really working in former debugging, make me can not find this omission. I will take more care of my code, thank you! --
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html