perf, tools: Add --initial-delay support to perf record v3
PATCH 1/1 perf, tools: Add --initial-delay support to perf record v3
From: Andi Kleen <[email protected]>
perf stat has a --delay option to delay measuring the workload. This is useful to skip measuring the startup phase of the program, which is often very different from the main workload.
The same is useful for perf record when sampling.
--no-delay was already taken, so add a --initial-delay to perf record too.
-D was already taken for record, so there is only a long option.
v2: Don't disable group members (Namhyung Kim)
v3: port to latest perf/core
rename to --initial-delay to avoid conflict with --no-delay
--- tools/perf/Documentation/perf-record.txt | 4 ++++ tools/perf/builtin-record.c | 9 ++++++++- tools/perf/perf.h | 1 + tools/perf/util/evsel.c | 3 ++- 4 files changed, 15 insertions(+), 2 deletions(-)
tools/perf/Documentation/perf-record.txt +4 -0
@@ -209,6 +209,10 @@ overrides that and uses per-thread mmaps. A side-effect of that is that inheritance is automatically disabled. --per-thread is ignored with a warning if combined with -a or -C options. +--initial-delay msecs:: +After starting the program, wait msecs before measuring. This is useful to +filter out the startup phase of the program, which is often very different. + SEE ALSO -------- linkperf:perf-stat[1], linkperf:perf-list[1]
tools/perf/builtin-record.c +8 -1
@@ -499,7 +499,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)* (apart from group members) have enable_on_exec=1 set, * so don't spoil it by prematurely enabling them. */ -if (!target__none (&opts->target)) +if (!target__none (&opts->target) && !opts->initial_delay)perf_evlist__enable (rec->evlist);/*
@@ -508,6 +508,11 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)if (forks)perf_evlist__start_workload (rec->evlist); +if (opts->initial_delay) { +usleep (opts->initial_delay *1000 ); +perf_evlist__enable (rec->evlist); + } +for (;;) {int hits = rec->samples;
@@ -877,6 +882,8 @@ const struct option record_options[] = {OPT_CALLBACK ('G' ,"cgroup" , &record.evlist,"name" ,"monitor event in cgroup name only" , parse_cgroups), +OPT_UINTEGER (0 ,"initial-delay" , &record.opts.initial_delay, +"ms to wait before starting measurement after program start" ),OPT_STRING ('u' ,"uid" , &record.opts.target.uid_str,"user" , "user to profile"),
tools/perf/perf.h +1 -0
@@ -269,6 +269,7 @@ struct record_opts {u64 user_interval;u16 stack_dump_size;bool sample_transaction; + unsigned initial_delay; };#endif
tools/perf/util/evsel.c +2 -1
@@ -658,7 +658,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts)* Setting enable_on_exec for independent events and * group leaders for traced executed by perf. */ -if (target__none (&opts->target) &&perf_evsel__is_group_leader (evsel)) +if (target__none (&opts->target) &&perf_evsel__is_group_leader (evsel) && + !opts->initial_delay) attr->enable_on_exec =1 ; }
Signature · 1 line
1.8.3.1
Hi Andi,
Quoted 8 lines · Andi Kleen
From: Andi Kleen <[email protected]>
perf stat has a --delay option to delay measuring the workload. This is useful to skip measuring the startup phase of the program, which is often very different from the main workload.
The same is useful for perf record when sampling.
Quoted 7 lines
--no-delay was already taken, so add a --initial-delay to perf record too.
-D was already taken for record, so there is only a long option.v2: Don't disable group members (Namhyung Kim)
v3: port to latest perf/core
rename to --initial-delay to avoid conflict with --no-delay
Thanks,
Namhyung
tip-bot for Andi Kleen
merge bot[tip:perf/core] perf record: Add --initial-delay option
In reply to Andi Kleenperf record: Add --initial-delay option
Commit-ID: 6619a53ef7572b9eaf7aa71ff7f74c0d06b3817b Gitweb: http://git.kernel.org/tip/6619a53ef7572b9eaf7aa71ff7f74c0d06b3817b Author: Andi Kleen <[email protected]> AuthorDate: Sat, 11 Jan 2014 13:38:27 -0800 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 13 Jan 2014 10:07:03 -0300
perf record: Add --initial-delay option
perf stat has a --delay option to delay measuring the workload.
This is useful to skip measuring the startup phase of the program, which is often very different from the main workload.
The same is useful for perf record when sampling.
--no-delay was already taken, so add a --initial-delay to perf record too.
-D was already taken for record, so there is only a long option.
v2: Don't disable group members (Namhyung Kim)
v3: port to latest perf/core
rename to --initial-delay to avoid conflict with --no-delay
--- tools/perf/Documentation/perf-record.txt | 4 ++++ tools/perf/builtin-record.c | 9 ++++++++- tools/perf/perf.h | 1 + tools/perf/util/evsel.c | 3 ++- 4 files changed, 15 insertions(+), 2 deletions(-)
tools/perf/Documentation/perf-record.txt +4 -0
@@ -209,6 +209,10 @@ overrides that and uses per-thread mmaps. A side-effect of that is that inheritance is automatically disabled. --per-thread is ignored with a warning if combined with -a or -C options. +--initial-delay msecs:: +After starting the program, wait msecs before measuring. This is useful to +filter out the startup phase of the program, which is often very different. + SEE ALSO -------- linkperf:perf-stat[1], linkperf:perf-list[1]
tools/perf/builtin-record.c +8 -1
@@ -499,7 +499,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)* (apart from group members) have enable_on_exec=1 set, * so don't spoil it by prematurely enabling them. */ -if (!target__none (&opts->target)) +if (!target__none (&opts->target) && !opts->initial_delay)perf_evlist__enable (rec->evlist);/*
@@ -508,6 +508,11 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)if (forks)perf_evlist__start_workload (rec->evlist); +if (opts->initial_delay) { +usleep (opts->initial_delay *1000 ); +perf_evlist__enable (rec->evlist); + } +for (;;) {int hits = rec->samples;
@@ -877,6 +882,8 @@ const struct option record_options[] = {OPT_CALLBACK ('G' ,"cgroup" , &record.evlist,"name" ,"monitor event in cgroup name only" , parse_cgroups), +OPT_UINTEGER (0 ,"initial-delay" , &record.opts.initial_delay, +"ms to wait before starting measurement after program start" ),OPT_STRING ('u' ,"uid" , &record.opts.target.uid_str,"user" , "user to profile"),
tools/perf/perf.h +1 -0
@@ -269,6 +269,7 @@ struct record_opts {u64 user_interval;u16 stack_dump_size;bool sample_transaction; + unsigned initial_delay; };#endif
tools/perf/util/evsel.c +2 -1
@@ -658,7 +658,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts)* Setting enable_on_exec for independent events and * group leaders for traced executed by perf. */ -if (target__none (&opts->target) &&perf_evsel__is_group_leader (evsel)) +if (target__none (&opts->target) &&perf_evsel__is_group_leader (evsel) && + !opts->initial_delay) attr->enable_on_exec =1 ; }