Skip to contentSkip to conversation

fs/ramfs: don't use module_init for non-modular core code

PATCH New Paul Gortmaker 1 participant 1 message Jan 12, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/ramfs: don't use module_init for non-modular core code

The ramfs is always built in. It will never be modular, so using module_init as an alias for __initcall is rather misleading.

Fix this up now, so that we can relocate module_init from init.h into module.h in the future. If we don't do this, we'd have to add module.h to obviously non-modular code, and that would be a worse thing.

Note that direct use of __initcall is discouraged, vs. one of the priority categorized subgroups. As __initcall gets mapped onto device_initcall, our use of fs_initcall (which makes sense for fs code) will thus change this registration from level 6-device to level 5-fs (i.e. slightly earlier). However no observable impact of that small difference has been observed during testing, or is expected.

Also note that this change uncovers a missing semicolon bug in the registration of the initcall.

---
 fs/ramfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ramfs/inode.c +1 -1
index 03b8016e5bbc..d365b1c4eb3c 100644
@@ -282,4 +282,4 @@ int __init init_ramfs_fs(void)
 
 	return err;
 }
-module_init(init_ramfs_fs)
+fs_initcall(init_ramfs_fs);
Signature · 1 line
1.8.5.2