Skip to contentSkip to conversation

DAS1800: Fixing foo * bar should be foo *bar

PATCH In review Joe Borg 2 participants 3 messages Jan 13, 2014 Staging

lore
Share & tools
lore

Joe Borg

author
#0 lore raw

PATCH 1/1 DAS1800: Fixing foo * bar should be foo *bar

Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data().

Signed-off-by Joe Borg <[email protected]>

---
 drivers/staging/comedi/drivers/das1800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/das1800.c +1 -1
index 1880038..8fb87df 100644
@@ -462,7 +462,7 @@ static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev,
 	return sample;
 }
 
-static void munge_data(struct comedi_device *dev, uint16_t * array,
+static void munge_data(struct comedi_device *dev, uint16_t *array,
 		       unsigned int num_elements)
 {
 	unsigned int i;
Signature · 1 line
1.8.5.2
maintainer
#1 lore raw
Quoted 2 lines · Joe Borg

Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data().

Ok, real minor nits here, but I'd like you to make them for future patches as it makes my life easier, and I don't like to edit patches by hand, as I don't scale very well.

Your subject should be:
[PATCH] staging: comedi: das1800: fix for * bar to be foo *bar

you need to add the driver subsystem, and specific area and driver. And no kernel drivers are ALL CAPS, so that should never be used.

I've taken this patch as-is, but in the future please try to do this.

Oh, one more thing:

Quoted 1 line

Signed-off-by Joe Borg <[email protected]>

You forgot a ':' here :)

thanks,

greg k-h

maintainer
#2 lore raw

Re: [PATCH] staging: comedi: das1800: Fixing foo * bar should be foo *bar

In reply to Joe Borg
Quoted 13 lines · Joe Borg

Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data().

---
 drivers/staging/comedi/drivers/das1800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/das1800.c +0 -0
index 1880038..8fb87df 100644

drivers/staging/comedi/drivers/das1800.c static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev, · line 466

Quoted 6 lines
drivers/staging/comedi/drivers/das1800.c +1 -1
@@ -462,7 +462,7 @@ static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev,
 	return sample;
 }
 
-static void munge_data(struct comedi_device *dev, uint16_t * array,
+static void munge_data(struct comedi_device *dev, uint16_t *array,
 		       unsigned int num_elements)

Ok, after all that work, it turns out I can't even apply this patch as someone else did it already a while ago. You should be working off of linux-next, or my staging.git tree, not Linus's tree, as that does not contain all of the work we are doing on the next version of linux (hence the -next).

So, care to try again with a different fix?

thanks,

greg k-h