Skip to contentSkip to conversation

Call arch_pick_mmap_layout() only once

PATCH New Richard Weinberger 1 participant 1 message Jan 14, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Call arch_pick_mmap_layout() only once

Currently both setup_new_exec() and flush_old_exec() issue a call to arch_pick_mmap_layout().
As setup_new_exec() and flush_old_exec() are always called pairwise arch_pick_mmap_layout() is called twice.

This patch removes one call from setup_new_exec() to have it only called once.

---
Changes between v1 and v2:

Pat reported that v1 broke IA32 emulation on x86_64. It turned out that we have to keep the second call to arch_pick_mmap_layout() and are free to remove the first one. v1 did it the other way around.
This is needed because only the latter call will see all current->personality flags.

fs/exec.c +0 -1
index 7ea097f..a733599 100644
@@ -843,7 +843,6 @@ static int exec_mmap(struct mm_struct *mm)
 	tsk->active_mm = mm;
 	activate_mm(active_mm, mm);
 	task_unlock(tsk);
-	arch_pick_mmap_layout(mm);
 	if (old_mm) {
 		up_read(&old_mm->mmap_sem);
 		BUG_ON(active_mm != old_mm);
Signature · 1 line
1.8.4.2