i915: send D1 opregion notification
Subsystems (2)
PATCH v2 1/1 i915: send D1 opregion notification
The opregion notification for runtime suspend is currently D1, not D3.
Signed-off-by Kristen Carlson Accardi <[email protected]>
--- drivers/gpu/drm/i915/i915_drv.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +9 -1
@@ -925,7 +925,15 @@ static int i915_runtime_suspend(struct device *device)del_timer_sync (&dev_priv->gpu_error.hangcheck_timer); dev_priv->pm.suspended = true; -intel_opregion_notify_adapter (dev, PCI_D3cold); + +/* +* current versions of firmware which depend on this opregion +* notification have repurposed the D1 definition to mean +* "runtime suspended" vs. what you would normally expect (D3) +* to distinguish it from notifications that might be sent +* via the suspend path. +*/ +intel_opregion_notify_adapter (dev,PCI_D1 );return 0 ; }
Signature · 1 line
1.8.3.2
Daniel Vetter
AppliedQuoted 3 lines · Kristen Carlson Accardi
The opregion notification for runtime suspend is currently D1, not D3.
Signed-off-by Kristen Carlson Accardi <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Quoted 32 lines
--- drivers/gpu/drm/i915/i915_drv.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_drv.c +9
-1@@ -925,7 +925,15 @@ static int i915_runtime_suspend(struct device *device)del_timer_sync (&dev_priv->gpu_error.hangcheck_timer); dev_priv->pm.suspended = true; -intel_opregion_notify_adapter (dev, PCI_D3cold); + +/* +* current versions of firmware which depend on this opregion +* notification have repurposed the D1 definition to mean +* "runtime suspended" vs. what you would normally expect (D3) +* to distinguish it from notifications that might be sent +* via the suspend path. +*/ +intel_opregion_notify_adapter (dev,PCI_D1 );return 0 ; }Signature · 6 lines
1.8.3.2 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch