Revert "x86: fix 27-rc crash on vsmp due to paravirt during module load"
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 11 lines · Paul Gortmaker
This reverts commit
05e12e1c4c09cd35ac9f4e6af1e42b0036375d72.The old change from
__init-->__init_or_moduledoesn't make sense anymore, given that thearch/x86/kernel/vsmp_64.ccode is only for non-modular builds.As of commit
70511134f61bd6e5eed19f767381f9fb3e762d49("Revert "x86: don't compilevsmp_64for 32bit") this file became obj-y and hence is only for built-in. That makes any "or_module" support redundant.
Quoted 4 lines
We need to distinguish between the two in order to do some header cleanups. This revert starts that process.
Signed-off-by Paul Gortmaker <[email protected]>
I suspect you want to carry this as part of your header cleanups, to not have to wait for upstream propagation?
Please fix the title: the original commit was right, but was mooted by other changes. That's not a revert but a change that happens to be the inverse of an earlier change.
Thanks,
Ingo
Quoted 14 lines · Ingo Molnar
Quoted 11 lines · Paul Gortmaker
This reverts commit
05e12e1c4c09cd35ac9f4e6af1e42b0036375d72.The old change from
__init-->__init_or_moduledoesn't make sense anymore, given that thearch/x86/kernel/vsmp_64.ccode is only for non-modular builds.As of commit
70511134f61bd6e5eed19f767381f9fb3e762d49("Revert "x86: don't compilevsmp_64for 32bit") this file became obj-y and hence is only for built-in. That makes any "or_module" support redundant.
Quoted 7 lines
Quoted 4 lines
We need to distinguish between the two in order to do some header cleanups. This revert starts that process.
Signed-off-by Paul Gortmaker <[email protected]>I suspect you want to carry this as part of your header cleanups, to not have to wait for upstream propagation?
Either way is fine; I've already fed out some of the other independent chunks to maintainers just to keep the size of what goes in from me at rc1 a bit smaller.
Quoted 4 lines
Please fix the title: the original commit was right, but was mooted by other changes. That's not a revert but a change that happens to be the inverse of an earlier change.
Fair point; will fix.
Thanks,
Paul.
--
Quoted 5 lines
Thanks,
Ingo