conf/bitbake.conf: default HOMEPAGE to blank instead of unknown

PATCH Superseded Paul Eggleton 3 participants 9 messages Jan 21, 2014

Share & tools

Paul Eggleton

author

2014-01-21 12:18 UTC #0 lore raw

PATCH 1/1 conf/bitbake.conf: default HOMEPAGE to blank instead of unknown

The default value for HOMEPAGE of "unknown" has been in place since the early OE-Classic days, but it doesn't really make sense - "unknown" is not a valid URL and it just means we have to explicitly check for this hardcoded string if we're displaying the value in some form of UI, such as Toaster. There is some code in the unmaintained oelint.bbclass to check for this value, presumably on the assumption that the recipe will explicitly set it to "" if there really isn't a homepage, but looking at recipes in OE-Core and meta-oe suggests that we haven't been using this convention for some time (with one exception in the latter) and it's rather uncommon these days to have no URL to associate with a recipe.

Signed-off-by Paul Eggleton <[email protected]>

---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

meta/conf/bitbake.conf +1 -1

index 57668e1..4fb6a1c 100644
@@ -241,7 +241,7 @@ This package contains documentation."
 
 LICENSE = "INVALID"
 MAINTAINER = "OE-Core Developers <[email protected]>"
-HOMEPAGE = "unknown"
+HOMEPAGE = ""
 
 # Package dependencies and provides.

Signature · 1 line

1.8.4.2

Saul Wold

2014-01-21 22:09 UTC #1 lore raw

Quoted 21 lines · Paul Eggleton

The default value for HOMEPAGE of "unknown" has been in place since the early OE-Classic days, but it doesn't really make sense - "unknown" is not a valid URL and it just means we have to explicitly check for this hardcoded string if we're displaying the value in some form of UI, such as Toaster. There is some code in the unmaintained oelint.bbclass to check for this value, presumably on the assumption that the recipe will explicitly set it to "" if there really isn't a homepage, but looking at recipes in OE-Core and meta-oe suggests that we haven't been using this convention for some time (with one exception in the latter) and it's rather uncommon these days to have no URL to associate with a recipe.
Signed-off-by Paul Eggleton <[email protected]>
---
  meta/conf/bitbake.conf | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +0 -0
index 57668e1..4fb6a1c 100644

meta/conf/bitbake.conf This package contains documentation." · line 245

Quoted 6 lines

meta/conf/bitbake.conf +1 -1

@@ -241,7 +241,7 @@ This package contains documentation."
 
  LICENSE = "INVALID"
  MAINTAINER = "OE-Core Developers <[email protected]>"
-HOMEPAGE = "unknown"
+HOMEPAGE = ""

This seems to have caused a couple of problems with shadow-securetty, updaterc and depmodwrapper.

There may be more.

I will look to see what I can do to fix those recipes.

Sau!

Quoted 3 lines

meta/conf/bitbake.conf +0 -0
  # Package dependencies and provides.
 

Paul Eggleton

author

2014-01-21 22:12 UTC #2 lore raw

Hi Saul,

Quoted 33 lines · On Tuesday 21 January 2014 14:09:16 Saul Wold wrote:

Quoted 22 lines · Paul Eggleton
The default value for HOMEPAGE of "unknown" has been in place since the early OE-Classic days, but it doesn't really make sense - "unknown" is not a valid URL and it just means we have to explicitly check for this hardcoded string if we're displaying the value in some form of UI, such as Toaster. There is some code in the unmaintained oelint.bbclass to check for this value, presumably on the assumption that the recipe will explicitly set it to "" if there really isn't a homepage, but looking at recipes in OE-Core and meta-oe suggests that we haven't been using this convention for some time (with one exception in the latter) and it's rather uncommon these days to have no URL to associate with a recipe.
Signed-off-by Paul Eggleton <[email protected]>
---
  meta/conf/bitbake.conf | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +0 -0
index 57668e1..4fb6a1c 100644
meta/conf/bitbake.conf This package contains documentation." · line 245
Quoted 6 lines
meta/conf/bitbake.conf +1 -1
@@ -241,7 +241,7 @@ This package contains documentation."
 
  LICENSE = "INVALID"
  MAINTAINER = "OE-Core Developers
  <[email protected]>"> 
-HOMEPAGE = "unknown"
+HOMEPAGE = ""
This seems to have caused a couple of problems with shadow-securetty, updaterc and depmodwrapper.

Quoted 1 line

There may be more.

Can you perhaps be more specific as to what the problem is?

Thanks,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Paul Eggleton

author

2014-01-21 22:22 UTC #3 lore raw

Quoted 37 lines · On Tuesday 21 January 2014 22:12:13 Paul Eggleton wrote:

Hi Saul,
Quoted 34 lines · On Tuesday 21 January 2014 14:09:16 Saul Wold wrote:
Quoted 22 lines · Paul Eggleton
The default value for HOMEPAGE of "unknown" has been in place since the early OE-Classic days, but it doesn't really make sense - "unknown" is not a valid URL and it just means we have to explicitly check for this hardcoded string if we're displaying the value in some form of UI, such as Toaster. There is some code in the unmaintained oelint.bbclass to check for this value, presumably on the assumption that the recipe will explicitly set it to "" if there really isn't a homepage, but looking at recipes in OE-Core and meta-oe suggests that we haven't been using this convention for some time (with one exception in the latter) and it's rather uncommon these days to have no URL to associate with a recipe.
Signed-off-by Paul Eggleton <[email protected]>
---
  meta/conf/bitbake.conf | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +0 -0
index 57668e1..4fb6a1c 100644
meta/conf/bitbake.conf This package contains documentation." · line 246
Quoted 7 lines
meta/conf/bitbake.conf +1 -1
@@ -241,7 +241,7 @@ This package contains documentation."
 
  LICENSE = "INVALID"
  MAINTAINER = "OE-Core Developers
  <[email protected]>">
 
-HOMEPAGE = "unknown"
+HOMEPAGE = ""
This seems to have caused a couple of problems with shadow-securetty, updaterc and depmodwrapper.

Quoted 3 lines

Quoted 1 line
There may be more.
Can you perhaps be more specific as to what the problem is?

Oh, I see, rpmbuild blows up with URL blank. Great :/

Let's hold off on this one for now because fixing one or two recipes isn't going to cover it.

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Richard Purdie

2014-01-21 22:42 UTC #4 lore raw

Quoted 38 lines · Paul Eggleton

Quoted 37 lines · On Tuesday 21 January 2014 22:12:13 Paul Eggleton wrote:
Hi Saul,
Quoted 34 lines · On Tuesday 21 January 2014 14:09:16 Saul Wold wrote:
Quoted 22 lines · Paul Eggleton
The default value for HOMEPAGE of "unknown" has been in place since the early OE-Classic days, but it doesn't really make sense - "unknown" is not a valid URL and it just means we have to explicitly check for this hardcoded string if we're displaying the value in some form of UI, such as Toaster. There is some code in the unmaintained oelint.bbclass to check for this value, presumably on the assumption that the recipe will explicitly set it to "" if there really isn't a homepage, but looking at recipes in OE-Core and meta-oe suggests that we haven't been using this convention for some time (with one exception in the latter) and it's rather uncommon these days to have no URL to associate with a recipe.
Signed-off-by Paul Eggleton <[email protected]>
---
  meta/conf/bitbake.conf | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +0 -0
index 57668e1..4fb6a1c 100644
meta/conf/bitbake.conf This package contains documentation." · line 246
Quoted 7 lines
meta/conf/bitbake.conf +1 -1
@@ -241,7 +241,7 @@ This package contains documentation."
 
  LICENSE = "INVALID"
  MAINTAINER = "OE-Core Developers
  <[email protected]>">
 
-HOMEPAGE = "unknown"
+HOMEPAGE = ""
This seems to have caused a couple of problems with shadow-securetty, updaterc and depmodwrapper.

Quoted 8 lines

Quoted 3 lines
Quoted 1 line
There may be more.
Can you perhaps be more specific as to what the problem is?
Oh, I see, rpmbuild blows up with URL blank. Great :/
Let's hold off on this one for now because fixing one or two recipes isn't going to cover it.

I'm perfectly fine with the rpm backend injecting something to deal with this rather than cluttering bitbake.conf or the toaster code. I think cleaning out bitbake.conf is something we need to do more of.

SRCREV ??= "INVALID" is on my hitlist (newer bitbake's shouldn't need that).

Cheers,

Richard

Saul Wold

2014-01-21 22:24 UTC #5 lore raw

In reply to Paul Eggleton

Quoted 36 lines · Paul Eggleton

Hi Saul,
Quoted 33 lines · On Tuesday 21 January 2014 14:09:16 Saul Wold wrote:
Quoted 22 lines · Paul Eggleton
The default value for HOMEPAGE of "unknown" has been in place since the early OE-Classic days, but it doesn't really make sense - "unknown" is not a valid URL and it just means we have to explicitly check for this hardcoded string if we're displaying the value in some form of UI, such as Toaster. There is some code in the unmaintained oelint.bbclass to check for this value, presumably on the assumption that the recipe will explicitly set it to "" if there really isn't a homepage, but looking at recipes in OE-Core and meta-oe suggests that we haven't been using this convention for some time (with one exception in the latter) and it's rather uncommon these days to have no URL to associate with a recipe.
Signed-off-by Paul Eggleton <[email protected]>
---
   meta/conf/bitbake.conf | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +0 -0
index 57668e1..4fb6a1c 100644
meta/conf/bitbake.conf This package contains documentation." · line 245
Quoted 6 lines
meta/conf/bitbake.conf +1 -1
@@ -241,7 +241,7 @@ This package contains documentation."
 
   LICENSE = "INVALID"
   MAINTAINER = "OE-Core Developers
   <[email protected]>">
-HOMEPAGE = "unknown"
+HOMEPAGE = ""
This seems to have caused a couple of problems with shadow-securetty, updaterc and depmodwrapper.

Quoted 4 lines

Quoted 1 line
There may be more.
Can you perhaps be more specific as to what the problem is?

Sorry, thought perhaps you would see the autobuilder failures.

Quoted 34 lines

ERROR: Task 1962 (/home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/meta/recipes-core/update-rc.d/update-rc.d_0.7.bb, do_package_write_rpm) failed with exit code '1'
NOTE: recipe shadow-securetty-4.1.4.3-r2: task do_package_write_deb: Started
ERROR: Function failed: dpkg-deb execution failed
ERROR: Logfile of failure stored in: /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/temp/log.do_package_write_deb.8751 Log data follows:
| DEBUG: Executing python function sstate_task_prefunc
| DEBUG: Python function sstate_task_prefunc finished
| DEBUG: Executing python function do_package_write_deb
| DEBUG: Executing python function read_subpackage_metadata
| DEBUG: Python function read_subpackage_metadata finished
| DEBUG: Executing python function do_package_deb
| dpkg-deb: error: parsing file '/home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/packages-split/shadow-securetty-dbg/DEBIAN/control' near line 11 package 'shadow-securetty-dbg':
|  EOF before value of field `Homepage' (missing final newline)
| DEBUG: Python function do_package_deb finished
| DEBUG: Python function do_package_write_deb finished
| ERROR: Function failed: dpkg-deb execution failed
NOTE: recipe shadow-securetty-4.1.4.3-r2: task do_package_write_deb: Failed
ERROR: Task 4847 (/home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/meta/recipes-extended/shadow/shadow-securetty_4.1.4.3.bb, do_package_write_deb) failed with exit code '1'
ERROR: Function failed: BUILDSPEC (log file is located at /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/temp/log.do_package_write_rpm.8020)
ERROR: Logfile of failure stored in: /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/temp/log.do_package_write_rpm.8020 Log data follows:
| DEBUG: Executing python function sstate_task_prefunc
| DEBUG: Python function sstate_task_prefunc finished
| DEBUG: Executing python function do_package_write_rpm
| DEBUG: Executing python function read_subpackage_metadata
| DEBUG: Python function read_subpackage_metadata finished
| DEBUG: Executing python function do_package_rpm
| DEBUG: Executing python function write_specfile
| NOTE: Creating EMPTY RPM Package for shadow-securetty-dbg
| NOTE: Not creating empty RPM package for shadow-securetty-staticdev
| NOTE: Creating EMPTY RPM Package for shadow-securetty-dev
| NOTE: Not creating empty RPM package for shadow-securetty-doc
| NOTE: Not creating empty RPM package for shadow-securetty-locale
| NOTE: Creating RPM package for shadow-securetty

Quoted 8 lines

| NOTE: Creating RPM package for shadow-securetty
| DEBUG: Python function write_specfile finished
| DEBUG: Executing shell function BUILDSPEC
| error: line 8: Empty tag: URL:
| error: Package has no %description: shadow-securetty-4.1.4.3-r2.qemuarm
| Building target platforms: qemuarm-poky-linux-gnueabi
| WARNING: /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/temp/run.BUILDSPEC.8020:1 exit 1 from
|   rpmbuild --nodeps --short-circuit --target qemuarm-poky-linux-gnueabi --buildroot /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/package --define '_topdir /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2' --define '_rpmdir /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/deploy-rpms/qemuarm' --define '_build_name_fmt %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm' --define '_use_internal_dependency_generator 0' --define '__find_requires %{nil}' --define '__find_provides %{nil}' --define '_unpackaged_files_terminate_build 0' --define 'debug_package %{nil}' --define '_rpmfc_magic_path /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/sysroots/x86_64-linux/usr/share/misc/magic.mgc' --define

'_tmppath /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2' -bb /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/shadow-securetty.spec

Quoted 10 lines

| DEBUG: Python function do_package_rpm finished
| DEBUG: Python function do_package_write_rpm finished
| ERROR: Function failed: BUILDSPEC (log file is located at /home/pokybuild/yocto-autobuilder-dev/yocto-slave/nightly-arm/build/build/tmp/work/qemuarm-poky-linux-gnueabi/shadow-securetty/4.1.4.3-r2/temp/log.do_package_write_rpm.8020)

NOTE: recipe shadow-securetty-4.1.4.3-r2: task do_package_write_rpm: Failed

Thanks,
Paul

Richard Purdie

2014-01-21 22:23 UTC #6 lore raw

In reply to Paul Eggleton

Quoted 21 lines · Paul Eggleton

The default value for HOMEPAGE of "unknown" has been in place since the early OE-Classic days, but it doesn't really make sense - "unknown" is not a valid URL and it just means we have to explicitly check for this hardcoded string if we're displaying the value in some form of UI, such as Toaster. There is some code in the unmaintained oelint.bbclass to check for this value, presumably on the assumption that the recipe will explicitly set it to "" if there really isn't a homepage, but looking at recipes in OE-Core and meta-oe suggests that we haven't been using this convention for some time (with one exception in the latter) and it's rather uncommon these days to have no URL to associate with a recipe.
Signed-off-by Paul Eggleton <[email protected]>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +0 -0
index 57668e1..4fb6a1c 100644

meta/conf/bitbake.conf This package contains documentation." · line 245

Quoted 6 lines

meta/conf/bitbake.conf +1 -1

@@ -241,7 +241,7 @@ This package contains documentation."
 
 LICENSE = "INVALID"
 MAINTAINER = "OE-Core Developers <[email protected]>"
-HOMEPAGE = "unknown"
+HOMEPAGE = ""

Perhaps we just shouldn't set it at all in bitbake.conf and let recipes elect to set it?

Cheers,

Richard

Paul Eggleton

author

2014-01-21 22:40 UTC #7 lore raw

Quoted 24 lines · On Tuesday 21 January 2014 22:23:18 Richard Purdie wrote:

Quoted 23 lines · Paul Eggleton
The default value for HOMEPAGE of "unknown" has been in place since the early OE-Classic days, but it doesn't really make sense - "unknown" is not a valid URL and it just means we have to explicitly check for this hardcoded string if we're displaying the value in some form of UI, such as Toaster. There is some code in the unmaintained oelint.bbclass to check for this value, presumably on the assumption that the recipe will explicitly set it to "" if there really isn't a homepage, but looking at recipes in OE-Core and meta-oe suggests that we haven't been using this convention for some time (with one exception in the latter) and it's rather uncommon these days to have no URL to associate with a recipe.
Signed-off-by Paul Eggleton <[email protected]>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +0 -0
index 57668e1..4fb6a1c 100644
@@ -241,7 +241,7 @@ This package contains documentation."
 

Quoted 8 lines

meta/conf/bitbake.conf This package contains documentation." · line 244
Quoted 5 lines
meta/conf/bitbake.conf +1 -1
 LICENSE = "INVALID"
 MAINTAINER = "OE-Core Developers
 <[email protected]>"> 
-HOMEPAGE = "unknown"
+HOMEPAGE = ""
Perhaps we just shouldn't set it at all in bitbake.conf and let recipes elect to set it?

Maybe, but I think that alone isn't necessarily enough because then converting the value to a string gives you "None" (and this is what happens with the rpm backend).

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Richard Purdie

2014-01-21 22:42 UTC #8 lore raw

Quoted 34 lines · Paul Eggleton

Quoted 24 lines · On Tuesday 21 January 2014 22:23:18 Richard Purdie wrote:
Quoted 23 lines · Paul Eggleton
The default value for HOMEPAGE of "unknown" has been in place since the early OE-Classic days, but it doesn't really make sense - "unknown" is not a valid URL and it just means we have to explicitly check for this hardcoded string if we're displaying the value in some form of UI, such as Toaster. There is some code in the unmaintained oelint.bbclass to check for this value, presumably on the assumption that the recipe will explicitly set it to "" if there really isn't a homepage, but looking at recipes in OE-Core and meta-oe suggests that we haven't been using this convention for some time (with one exception in the latter) and it's rather uncommon these days to have no URL to associate with a recipe.
Signed-off-by Paul Eggleton <[email protected]>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +0 -0
index 57668e1..4fb6a1c 100644
@@ -241,7 +241,7 @@ This package contains documentation."
 
Quoted 8 lines
meta/conf/bitbake.conf This package contains documentation." · line 244
Quoted 5 lines
meta/conf/bitbake.conf +1 -1
 LICENSE = "INVALID"
 MAINTAINER = "OE-Core Developers
 <[email protected]>"> 
-HOMEPAGE = "unknown"
+HOMEPAGE = ""
Perhaps we just shouldn't set it at all in bitbake.conf and let recipes elect to set it?

Quoted 3 lines

Maybe, but I think that alone isn't necessarily enough because then converting the value to a string gives you "None" (and this is what happens with the rpm backend).

Lets fix the rpm backend then ;-)

Cheers,

Richard