Skip to contentSkip to conversation

batman-adv: fix TT-TVLV parsing on OGM reception

PATCH Applied Antonio Quartulli 2 participants 2 messages Jan 27, 2014 – Jan 29, 2014

lore
Share & tools
lore

Antonio Quartulli

author
#0 lore raw

PATCH 1/1 batman-adv: fix TT-TVLV parsing on OGM reception

When accessing a TT-TVLV container in the OGM RX path the variable pointing to the list of changes to apply is altered by mistake.

This makes the TT component read data at the wrong position in the OGM packet buffer.

Fix it by removing the bogus pointer alteration.

Signed-off-by Antonio Quartulli <[email protected]>
---
 translation-table.c | 1 -
 1 file changed, 1 deletion(-)
translation-table.c +0 -1
index 097ca01..05c2a9b 100644
@@ -3208,7 +3208,6 @@ static void batadv_tt_update_orig(struct batadv_priv *bat_priv,
 
 		spin_lock_bh(&orig_node->tt_lock);
 
-		tt_change = (struct batadv_tvlv_tt_change *)tt_buff;
 		batadv_tt_update_changes(bat_priv, orig_node, tt_num_changes,
 					 ttvn, tt_change);
Signature · 1 line
1.8.5.3
Applied
#1 lore raw
Quoted 7 lines · On Monday 27 January 2014 12:23:28 Antonio Quartulli wrote:

When accessing a TT-TVLV container in the OGM RX path the variable pointing to the list of changes to apply is altered by mistake.

This makes the TT component read data at the wrong position in the OGM packet buffer.

Quoted 6 lines

Fix it by removing the bogus pointer alteration.

Signed-off-by Antonio Quartulli <[email protected]>
---
 translation-table.c | 1 -
 1 file changed, 1 deletion(-)

Applied in revision db13d36.

Thanks,
Marek