Skip to contentSkip to conversation

tools: correct proftool build rule

PATCH Superseded Ian Campbell 3 participants 5 messages Jan 31, 2014 – Feb 19, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools: correct proftool build rule

The incorrect substitution made it rebuild every time.

---
 tools/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/Makefile +2 -2
index 323d408..602b2e5 100644
@@ -59,7 +59,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
 BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
 BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX)
 BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX)
-BIN_FILES-y += proftool(SFX)
+BIN_FILES-y += proftool$(SFX)
 
 # Source files which exist outside the tools directory
 EXT_OBJ_FILES-$(CONFIG_BUILD_ENVCRC) += common/env_embedded.o
@@ -182,7 +182,7 @@ $(obj)bmp_logo$(SFX):	$(obj)bmp_logo.o
 	$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
 	$(HOSTSTRIP) $@
 
-$(obj)proftool(SFX):	$(obj)proftool.o
+$(obj)proftool$(SFX):	$(obj)proftool.o
 	$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
 	$(HOSTSTRIP) $@
 
Signature · 1 line
1.8.5.3
#2 lore raw

PATCH v2 1/1 tools: correct proftool build rule

In reply to Ian Campbell

The incorrect substitution made it rebuild every time.

---
 tools/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/Makefile +2 -2
index 328cea3..052e4d4 100644
@@ -60,7 +60,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
 BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
 BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX)
 BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX)
-BIN_FILES-y += proftool(SFX)
+BIN_FILES-y += proftool$(SFX)
 BIN_FILES-$(CONFIG_STATIC_RELA) += relocate-rela$(SFX)
 
 # Source files which exist outside the tools directory
@@ -186,7 +186,7 @@ $(obj)bmp_logo$(SFX):	$(obj)bmp_logo.o
 	$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
 	$(HOSTSTRIP) $@
 
-$(obj)proftool(SFX):	$(obj)proftool.o
+$(obj)proftool$(SFX):	$(obj)proftool.o
 	$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
 	$(HOSTSTRIP) $@
 
Signature · 1 line
1.8.5.3
#3 lore raw

PATCH v2 1/1 tools: correct proftool build rule

Quoted 5 lines · Ian Campbell

The incorrect substitution made it rebuild every time.

Thanks Ian.

Quoted 29 lines
---
 tools/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/Makefile +2 -3
index 328cea3..052e4d4 100644
@@ -60,7 +60,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
 BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
 BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX)
 BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX)
-BIN_FILES-y += proftool(SFX)
+BIN_FILES-y += proftool$(SFX)
 BIN_FILES-$(CONFIG_STATIC_RELA) += relocate-rela$(SFX)
 
 # Source files which exist outside the tools directory
@@ -186,7 +186,7 @@ $(obj)bmp_logo$(SFX):       $(obj)bmp_logo.o
        $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
        $(HOSTSTRIP) $@
 
-$(obj)proftool(SFX):   $(obj)proftool.o
+$(obj)proftool$(SFX):  $(obj)proftool.o
        $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^
        $(HOSTSTRIP) $@
 
--

1.8.5.3

#4 lore raw

PATCH v2 1/1 tools: correct proftool build rule

In reply to Ian Campbell
Quoted 6 lines · Ian Campbell

The incorrect substitution made it rebuild every time.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140219/665ec707/attachment.pgp>