tools: correct proftool build rule
PATCH 1/1 tools: correct proftool build rule
The incorrect substitution made it rebuild every time.
Signed-off-by Ian Campbell <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
--- tools/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/Makefile +2 -2
@@ -59,7 +59,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX) BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX) BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX) BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX) -BIN_FILES-y += proftool(SFX) +BIN_FILES-y += proftool$(SFX) # Source files which exist outside the tools directory EXT_OBJ_FILES-$(CONFIG_BUILD_ENVCRC) += common/env_embedded.o
@@ -182,7 +182,7 @@ $(obj)bmp_logo$(SFX): $(obj)bmp_logo.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@ -$(obj)proftool(SFX): $(obj)proftool.o +$(obj)proftool$(SFX): $(obj)proftool.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@
Signature · 1 line
1.8.5.3
PATCH 1/1 tools: correct proftool build rule
Hi Ian,
Quoted 5 lines · Ian Campbell
The incorrect substitution made it rebuild every time.
Signed-off-by Ian Campbell <[email protected]>Cc Tom Rini <[email protected]>Cc Simon Glass <[email protected]>
It looks correct but does not apply for me on master.
Regards,
Simon
PATCH v2 1/1 tools: correct proftool build rule
In reply to Ian CampbellThe incorrect substitution made it rebuild every time.
Signed-off-by Ian Campbell <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
--- tools/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/Makefile +2 -2
@@ -60,7 +60,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX) BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX) BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX) BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX) -BIN_FILES-y += proftool(SFX) +BIN_FILES-y += proftool$(SFX) BIN_FILES-$(CONFIG_STATIC_RELA) += relocate-rela$(SFX) # Source files which exist outside the tools directory
@@ -186,7 +186,7 @@ $(obj)bmp_logo$(SFX): $(obj)bmp_logo.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@ -$(obj)proftool(SFX): $(obj)proftool.o +$(obj)proftool$(SFX): $(obj)proftool.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@
Signature · 1 line
1.8.5.3
PATCH v2 1/1 tools: correct proftool build rule
Quoted 5 lines · Ian Campbell
The incorrect substitution made it rebuild every time.
Signed-off-by Ian Campbell <[email protected]>Cc Tom Rini <[email protected]>Cc Simon Glass <[email protected]>
Thanks Ian.
Acked-by Simon Glass <[email protected]>
Quoted 29 lines
--- tools/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/Makefile +2
-3@@ -60,7 +60,7 @@ BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX) BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX) BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX) BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX) -BIN_FILES-y += proftool(SFX) +BIN_FILES-y += proftool$(SFX) BIN_FILES-$(CONFIG_STATIC_RELA) += relocate-rela$(SFX) # Source files which exist outside the tools directory@@ -186,7 +186,7 @@ $(obj)bmp_logo$(SFX): $(obj)bmp_logo.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@ -$(obj)proftool(SFX): $(obj)proftool.o +$(obj)proftool$(SFX): $(obj)proftool.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTSTRIP) $@ --1.8.5.3
PATCH v2 1/1 tools: correct proftool build rule
In reply to Ian CampbellQuoted 6 lines · Ian Campbell
The incorrect substitution made it rebuild every time.
Signed-off-by Ian Campbell <[email protected]>Cc Tom Rini <[email protected]>Cc Simon Glass <[email protected]>Acked-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140219/665ec707/attachment.pgp>