spi: bfin5xx: Remove duplicate code to check spi->mode
PATCH 1/1 spi: bfin5xx: Remove duplicate code to check spi->mode
This checking is already done in the implementation of spi_setup().
--- drivers/spi/spi-bfin5xx.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/spi/spi-bfin5xx.c +0 -4
@@ -1030,10 +1030,6 @@ static int bfin_spi_setup(struct spi_device *spi) }/* translate common spi framework into our register */ -if (spi->mode & ~(SPI_CPOL |SPI_CPHA |SPI_LSB_FIRST )) { -dev_err (&spi->dev,"unsupported spi modes detected\n" ); - goto error; - }if (spi->mode &SPI_CPOL ) chip->ctl_reg |=BIT_CTL_CPOL ;if (spi->mode &SPI_CPHA )
Signature · 8 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Q0MgU2NvdHQgSmlhbmcNCg0KDQo+LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj5Gcm9tOiBB eGVsIExpbiBbbWFpbHRvOmF4ZWwubGluQGluZ2ljcy5jb21dDQo+U2VudDogTW9uZGF5LCBGZWJy dWFyeSAwMywgMjAxNCAxMDo1MiBBTQ0KPlRvOiBNYXJrIEJyb3duDQo+Q2M6IFpoYW5nLCBTb25p YzsgU3RldmVuIE1pYW87IGxpbnV4LXNwaUB2Z2VyLmtlcm5lbC5vcmcNCj5TdWJqZWN0OiBbUEFU Q0hdIHNwaTogYmZpbjV4eDogUmVtb3ZlIGR1cGxpY2F0ZSBjb2RlIHRvIGNoZWNrIHNwaS0+bW9k ZQ0KPg0KPlRoaXMgY2hlY2tpbmcgaXMgYWxyZWFkeSBkb25lIGluIHRoZSBpbXBsZW1lbnRhdGlv biBvZiBzcGlfc2V0dXAoKS4NCj4NCj5TaWduZWQtb2ZmLWJ5OiBBeGVsIExpbiA8YXhlbC5saW5A aW5naWNzLmNvbT4NCj4tLS0NCj4gZHJpdmVycy9zcGkvc3BpLWJmaW41eHguYyB8IDQgLS0tLQ0K PiAxIGZpbGUgY2hhbmdlZCwgNCBkZWxldGlvbnMoLSkNCj4NCj5kaWZmIC0tZ2l0IGEvZHJpdmVy cy9zcGkvc3BpLWJmaW41eHguYyBiL2RyaXZlcnMvc3BpL3NwaS1iZmluNXh4LmMgaW5kZXggZjBm MTk1YS4uYzY5MDJkMg0KPjEwMDY0NA0KPi0tLSBhL2RyaXZlcnMvc3BpL3NwaS1iZmluNXh4LmMN Cj4rKysgYi9kcml2ZXJzL3NwaS9zcGktYmZpbjV4eC5jDQo+QEAgLTEwMzAsMTAgKzEwMzAsNiBA QCBzdGF0aWMgaW50IGJmaW5fc3BpX3NldHVwKHN0cnVjdCBzcGlfZGV2aWNlICpzcGkpDQo+ICAg ICAgIH0NCj4NCj4gICAgICAgLyogdHJhbnNsYXRlIGNvbW1vbiBzcGkgZnJhbWV3b3JrIGludG8g b3VyIHJlZ2lzdGVyICovDQo+LSAgICAgIGlmIChzcGktPm1vZGUgJiB+KFNQSV9DUE9MIHwgU1BJ X0NQSEEgfCBTUElfTFNCX0ZJUlNUKSkgew0KPi0gICAgICAgICAgICAgIGRldl9lcnIoJnNwaS0+ ZGV2LCAidW5zdXBwb3J0ZWQgc3BpIG1vZGVzIGRldGVjdGVkXG4iKTsNCj4tICAgICAgICAgICAg ICBnb3RvIGVycm9yOw0KPi0gICAgICB9DQo+ICAgICAgIGlmIChzcGktPm1vZGUgJiBTUElfQ1BP TCkNCj4gICAgICAgICAgICAgICBjaGlwLT5jdGxfcmVnIHw9IEJJVF9DVExfQ1BPTDsNCj4gICAg ICAgaWYgKHNwaS0+bW9kZSAmIFNQSV9DUEhBKQ0KPi0tDQo+MS44LjEuMg0KPg0KPg0KPg0KDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Mark Brown
AppliedQuoted 1 line · Axel Lin
This checking is already done in the implementation of
spi_setup().
Applied, thanks.