Skip to contentSkip to conversation

drivers/mfd: fix pointer-integer size mismatch warnings

PATCH In review SeongJae Park 2 participants 3 messages Feb 4, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/mfd: fix pointer-integer size mismatch warnings

Fix the pointer-integer size mismatch warnings below:

	drivers/mfd/wm8994-core.c: In function ‘wm8994_i2c_probe’:
	mfd/wm8994-core.c:639:19: warning: cast from pointer to integer of
			different size [-Wpointer-to-int-cast]
	    wm8994->type = (int)of_id->data;
	                   ^
	drivers/mfd/max8997.c: In function ‘max8997_i2c_get_driver_data’:
	drivers/mfd/max8997.c:173:10: warning: cast from pointer to integer of
			different size [-Wpointer-to-int-cast]
	   return (int)match->data;
	          ^
---
 drivers/mfd/max8997.c     | 2 +-
 drivers/mfd/wm8994-core.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/max8997.c +1 -1
index be88a3b..768bcb1 100644
@@ -170,7 +170,7 @@ static inline int max8997_i2c_get_driver_data(struct i2c_client *i2c,
 	if (IS_ENABLED(CONFIG_OF) && i2c->dev.of_node) {
 		const struct of_device_id *match;
 		match = of_match_node(max8997_pmic_dt_match, i2c->dev.of_node);
-		return (int)match->data;
+		return (int)(long)match->data;
 	}
 	return (int)id->driver_data;
 }
drivers/mfd/wm8994-core.c +1 -1
index ba04f1b..1b25335 100644
@@ -636,7 +636,7 @@ static int wm8994_i2c_probe(struct i2c_client *i2c,
 	if (i2c->dev.of_node) {
 		of_id = of_match_device(wm8994_of_match, &i2c->dev);
 		if (of_id)
-			wm8994->type = (int)of_id->data;
+			wm8994->type = (int)(long)of_id->data;
 	} else {
 		wm8994->type = id->driver_data;
 	}
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 11 lines

Fix the pointer-integer size mismatch warnings below:

	drivers/mfd/wm8994-core.c: In function ‘wm8994_i2c_probe’:
	mfd/wm8994-core.c:639:19: warning: cast from pointer to integer of
			different size [-Wpointer-to-int-cast]
	    wm8994->type = (int)of_id->data;
	                   ^
	drivers/mfd/max8997.c: In function ‘max8997_i2c_get_driver_data’:
	drivers/mfd/max8997.c:173:10: warning: cast from pointer to integer of
			different size [-Wpointer-to-int-cast]
	   return (int)match->data;
	          ^

Already fixed:
https://lkml.org/lkml/2014/1/23/309
https://lkml.org/lkml/2014/1/23/326

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#2 lore raw
Quoted 12 lines · Lee Jones
Quoted 11 lines

Fix the pointer-integer size mismatch warnings below:

      drivers/mfd/wm8994-core.c: In function ‘wm8994_i2c_probe’:
      mfd/wm8994-core.c:639:19: warning: cast from pointer to integer of
                      different size [-Wpointer-to-int-cast]
          wm8994->type = (int)of_id->data;
                         ^
      drivers/mfd/max8997.c: In function ‘max8997_i2c_get_driver_data’:
      drivers/mfd/max8997.c:173:10: warning: cast from pointer to integer of
                      different size [-Wpointer-to-int-cast]
         return (int)match->data;
                ^
Quoted 3 lines

Already fixed:
https://lkml.org/lkml/2014/1/23/309
https://lkml.org/lkml/2014/1/23/326

Oops, sorry, didn't check that(I checked only the -next tree). Thank you for let me know.

Quoted 6 lines

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead

Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog