Skip to contentSkip to conversation

staging: bcm: fix pointer-integer size mismatch warnings

PATCH In review SeongJae Park 2 participants 5 messages Feb 4, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: bcm: fix pointer-integer size mismatch warnings

Fix the pointer-integer size mismatch warnings below:
drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
^
drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
^
drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
^

---
 drivers/staging/bcm/CmHost.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/staging/bcm/CmHost.c +6 -3
index cc91b5e..dd8f8f7 100644
@@ -1384,7 +1384,8 @@ ULONG StoreCmControlResponseMessage(struct bcm_mini_adapter *Adapter, PVOID pvBu
 	}
 
 	/* this can't possibly be right */
-	pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
+	pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)
+		(uintptr_t)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
 
 	if (pstAddIndicationAlt->u8Type == DSA_REQ) {
 		struct bcm_add_request AddRequest;
@@ -1423,7 +1424,8 @@ ULONG StoreCmControlResponseMessage(struct bcm_mini_adapter *Adapter, PVOID pvBu
 		return 0;
 	}
 
-	pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
+	pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)
+		(uintptr_t)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
 
 	/* ACTIVE SET */
 	pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)
@@ -1437,7 +1439,8 @@ ULONG StoreCmControlResponseMessage(struct bcm_mini_adapter *Adapter, PVOID pvBu
 		return 0;
 	}
 
-	pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
+	pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)
+		(uintptr_t)ntohl((ULONG)pstAddIndication->psfActiveSet);
 
 	(*puBufferLength) = sizeof(struct bcm_add_indication);
 	*(struct bcm_add_indication *)pvBuffer = *pstAddIndication;
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 6 lines · SeongJae Park

Fix the pointer-integer size mismatch warnings below:
drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
^

Quoted 8 lines

drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
^
drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
^

No. You haven't fixed the bug, you've just silenced the warning so now someone has to spent hours and hours looking for it when it comes time to write a proper fix. Don't do that.

regards,
dan carpenter

#2 lore raw

Hello,

Quoted 16 lines · Dan Carpenter
Quoted 6 lines · SeongJae Park

Fix the pointer-integer size mismatch warnings below:
drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
^

Quoted 8 lines

drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
^
drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
^

Quoted 4 lines

No. You haven't fixed the bug, you've just silenced the warning so now someone has to spent hours and hours looking for it when it comes time to write a proper fix. Don't do that.

I had thought silencing warning may be better in someway for some people. But, anyway, now I agree and respect your opinion. Thank you for the opinion :)

Quoted 4 lines

regards,
dan carpenter

#3 lore raw
Quoted 19 lines · SeongJae Park

Hello,

Quoted 16 lines · Dan Carpenter
Quoted 14 lines · SeongJae Park

Fix the pointer-integer size mismatch warnings below:
drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
^
drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
^
drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
^

Quoted 7 lines
Quoted 4 lines

No. You haven't fixed the bug, you've just silenced the warning so now someone has to spent hours and hours looking for it when it comes time to write a proper fix. Don't do that.

I had thought silencing warning may be better in someway for some people. But, anyway, now I agree and respect your opinion. Thank you for the opinion :)

Don't worry about it. You're not the first person to try submit that patch.

When I last looked at it, this driver only worked under 32 bits and there were other 64 bit bugs as well besides this one.

regards,
dan carpenter

#4 lore raw
Quoted 28 lines · Dan Carpenter
Quoted 19 lines · SeongJae Park

Hello,

Quoted 16 lines · Dan Carpenter
Quoted 14 lines · SeongJae Park

Fix the pointer-integer size mismatch warnings below:
drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet);
^
drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet);
^
drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet);
^

Quoted 7 lines
Quoted 4 lines

No. You haven't fixed the bug, you've just silenced the warning so now someone has to spent hours and hours looking for it when it comes time to write a proper fix. Don't do that.

I had thought silencing warning may be better in someway for some people. But, anyway, now I agree and respect your opinion. Thank you for the opinion :)

Quoted 9 lines

Don't worry about it. You're not the first person to try submit that patch.

When I last looked at it, this driver only worked under 32 bits and there were other 64 bit bugs as well besides this one.

regards,
dan carpenter

Thank you very much for your kind reply. I'm yet newbie to kernel community and thinking I should try with unavoidable mistakes. Your reply have gave me more courage for trial.
I will not forget the learning I got from this trial :)