Skip to contentSkip to conversation

systemd: add a hard dependency on udev=$EXTENDPKGV

PATCH In review Ross Burton 2 participants 3 messages Feb 6, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 systemd: add a hard dependency on udev=$EXTENDPKGV

If the systemd/sysvinit DISTRO_FEATURES are changed without wiping the package feeds it's possible to build an image that pulls in mismatching versions of systemd and udev. This leads to images that are broken and don't boot correctly.

Prevent this by adding a version-locked dependency on udev in systemd so that images that attempt to install mis-matching versions don't build.

---
 meta/recipes-core/systemd/systemd_208.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/systemd/systemd_208.bb +1 -1
index 41a106a..5ed31c3 100644
@@ -225,7 +225,7 @@ FILES_${PN} = " ${base_bindir}/* \
 FILES_${PN}-dbg += "${rootlibdir}/.debug ${systemd_unitdir}/.debug ${systemd_unitdir}/*/.debug ${base_libdir}/security/.debug/"
 FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
 
-RDEPENDS_${PN} += "kmod dbus util-linux-mount"
+RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV})"
 
 RRECOMMENDS_${PN} += "systemd-serialgetty systemd-compat-units \
                       util-linux-agetty \
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 18 lines · Ross Burton

If the systemd/sysvinit DISTRO_FEATURES are changed without wiping the package feeds it's possible to build an image that pulls in mismatching versions of systemd and udev. This leads to images that are broken and don't boot correctly.

Prevent this by adding a version-locked dependency on udev in systemd so that images that attempt to install mis-matching versions don't build.

---
 meta/recipes-core/systemd/systemd_208.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/systemd/systemd_208.bb +0 -0
index 41a106a..5ed31c3 100644

meta/recipes-core/systemd/systemd_208.bb FILES_${PN} = " ${base_bindir}/* \ · line 231

Quoted 8 lines
meta/recipes-core/systemd/systemd_208.bb +1 -1
@@ -225,7 +225,7 @@ FILES_${PN} = " ${base_bindir}/* \
 FILES_${PN}-dbg += "${rootlibdir}/.debug ${systemd_unitdir}/.debug ${systemd_unitdir}/*/.debug ${base_libdir}/security/.debug/"
 FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
 
-RDEPENDS_${PN} += "kmod dbus util-linux-mount"
+RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV})"
 
 RRECOMMENDS_${PN} += "systemd-serialgetty systemd-compat-units \
                       util-linux-agetty \

Hi Ross,

which package manager did you test to verify it is working as expected?

Bye Henning

#2 lore raw
Quoted 1 line · Henning Heinold

which package manager did you test to verify it is working as expected?

I haven't attempted to replicate the failure case (because it involves quite a lot of building...) but the idiom of EXTENDPKGV is used in every -dbg and -dev package.

Ross