tools lib traceevent: Use realpath for srctree and objtree
PATCH 1/1 tools lib traceevent: Use realpath for srctree and objtree
If BUILD_SRC or CURDIR contains tailing '/', the file names passed to gcc will contain '//'. It will be contained .o's in debuginfo, then confuse debugedit:
https://bugzilla.redhat.com/show_bug.cgi?id=304121
This patch uses realpath command to makesure potential tailing '/'s are removed.
--- tools/lib/traceevent/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/lib/traceevent/Makefile +2 -2
@@ -107,8 +107,8 @@ endif # BUILD_SRC # We process the rest of the Makefile if this is the final invocation of make ifeq ($(skip-makefile),) -srctree := $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)) -objtree := $(CURDIR) +srctree := $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))) +objtree := $(realpath $(CURDIR)) src := $(srctree) obj := $(objtree)
Signature · 1 line
1.8.4
Another email inbox clean up: BLAST FROM THE PAST
Quoted 6 lines · On Fri, 7 Feb 2014 12:22:33 +0800 Wang Nan <[email protected]> wrote:
If
BUILD_SRCor CURDIR contains tailing '/', the file names passed to gcc will contain '//'. It will be contained .o's in debuginfo, then confuse debugedit:https://bugzilla.redhat.com/show_bug.cgi?id=304121
This patch uses realpath command to makesure potential tailing '/'s are removed.
Is this still an issue? I know Jiri did a bunch of changes to the make process, but does this still confuse debugedit (whatever that is)?
-- Steve
Quoted 29 lines
Signed-off-by Wang Nan <[email protected]>Cc Arnaldo Carvalho de Melo <[email protected]>Cc Jiri Olsa <[email protected]>Cc Steven Rostedt <[email protected]>Cc Namhyung Kim <[email protected]>Cc Ingo Molnar <[email protected]>Cc Andrew Morton <[email protected]>Cc Geng Hui <[email protected]>--- tools/lib/traceevent/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/lib/traceevent/Makefile +2
-2@@ -107,8 +107,8 @@ endif # BUILD_SRC # We process the rest of the Makefile if this is the final invocation of make ifeq ($(skip-makefile),) -srctree := $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)) -objtree := $(CURDIR) +srctree := $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))) +objtree := $(realpath $(CURDIR)) src := $(srctree) obj := $(objtree)
Quoted 8 lines · Steven Rostedt
Another email inbox clean up: BLAST FROM THE PAST
Quoted 3 lines · On Fri, 7 Feb 2014 12:22:33 +0800 Wang Nan <[email protected]> wrote:
If
BUILD_SRCor CURDIR contains tailing '/', the file names passed to gcc will contain '//'. It will be contained .o's in debuginfo, then confuse debugedit:
Quoted 6 lines
Quoted 3 lines
https://bugzilla.redhat.com/show_bug.cgi?id=304121
This patch uses realpath command to makesure potential tailing '/'s are removed.
Is this still an issue? I know Jiri did a bunch of changes to the make process, but does this still confuse debugedit (whatever that is)?
this should no longer be an issue.. recent build changes take care of this
jirka