Skip to contentSkip to conversation

Some patches applied on Fedora that maybe should be considered for being applied upstream

DISCUSSION Pacho Ramos 2 participants 6 messages Feb 9, 2014 – Feb 16, 2014 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

Hello

I was looking at bluez package and found some patches that maybe could be upstreamed. Also, I would like to know the reasons for not accepting them to ensure they are safe to be applied downstream by us too :)

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch -> Does this cause any issues with systemd --user setups?

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-obex-Use-GLib-helper-function-to-manipulate-paths.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0002-autopair-Don-t-handle-the-iCade.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0004-agent-Assert-possible-infinite-loop.patch
-> Any reason for not applying it upstream too?

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-work-around-Logitech-diNovo-Edge-keyboard-firmware-i.patch
-> Taking care this looks to be a really old issue, maybe using the workaround would be the only option for now :/

Thanks a lot for your thoughts :)

#1 lore raw
Quoted 7 lines · Pacho Ramos

Hello

I was looking at bluez package and found some patches that maybe could be upstreamed. Also, I would like to know the reasons for not accepting them to ensure they are safe to be applied downstream by us too :)

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch -> Does this cause any issues with systemd --user setups?

Giovanni already posted this patch earlier. There's no distribution using systemd sessions, so this doesn't work yet.

Quoted 4 lines

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-obex-Use-GLib-helper-function-to-manipulate-paths.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0002-autopair-Don-t-handle-the-iCade.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0004-agent-Assert-possible-infinite-loop.patch
-> Any reason for not applying it upstream too?

I've posted those patches to the list as well.

Quoted 3 lines

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-work-around-Logitech-diNovo-Edge-keyboard-firmware-i.patch
-> Taking care this looks to be a really old issue, maybe using the workaround would be the only option for now :/

I have no hardware to test this on, I snatched it from Ubuntu's bluez 4 package.

Cheers

#2 lore raw
Quoted 12 lines · Bastien Nocera
Quoted 7 lines · Pacho Ramos

Hello

I was looking at bluez package and found some patches that maybe could be upstreamed. Also, I would like to know the reasons for not accepting them to ensure they are safe to be applied downstream by us too :)

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch -> Does this cause any issues with systemd --user setups?

Giovanni already posted this patch earlier. There's no distribution using systemd sessions, so this doesn't work yet.

Quoted 6 lines
Quoted 4 lines

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-obex-Use-GLib-helper-function-to-manipulate-paths.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0002-autopair-Don-t-handle-the-iCade.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0004-agent-Assert-possible-infinite-loop.patch
-> Any reason for not applying it upstream too?

I've posted those patches to the list as well.

And, do you know why they weren't accepted? (it's for trying to get them merged and not needing to carry them forever)

Quoted 9 lines
Quoted 4 lines

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-work-around-Logitech-diNovo-Edge-keyboard-firmware-i.patch
-> Taking care this looks to be a really old issue, maybe using the workaround would be the only option for now :/

I have no hardware to test this on, I snatched it from Ubuntu's bluez 4 package.

Cheers

OK, thanks :)

#3 lore raw
Quoted 18 lines · Pacho Ramos
Quoted 17 lines · Bastien Nocera
Quoted 7 lines · Pacho Ramos

Hello

I was looking at bluez package and found some patches that maybe could be upstreamed. Also, I would like to know the reasons for not accepting them to ensure they are safe to be applied downstream by us too :)

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch -> Does this cause any issues with systemd --user setups?

Giovanni already posted this patch earlier. There's no distribution using systemd sessions, so this doesn't work yet.

Quoted 4 lines

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-obex-Use-GLib-helper-function-to-manipulate-paths.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0002-autopair-Don-t-handle-the-iCade.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0004-agent-Assert-possible-infinite-loop.patch
-> Any reason for not applying it upstream too?

Quoted 4 lines
Quoted 1 line

I've posted those patches to the list as well.

And, do you know why they weren't accepted? (it's for trying to get them merged and not needing to carry them forever)

Read the threads for the various patches?

Mailing-lists, awful at tracking patches since forever...

#4 lore raw
Quoted 19 lines · Bastien Nocera
Quoted 18 lines · Pacho Ramos
Quoted 17 lines · Bastien Nocera
Quoted 7 lines · Pacho Ramos

Hello

I was looking at bluez package and found some patches that maybe could be upstreamed. Also, I would like to know the reasons for not accepting them to ensure they are safe to be applied downstream by us too :)

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch -> Does this cause any issues with systemd --user setups?

Giovanni already posted this patch earlier. There's no distribution using systemd sessions, so this doesn't work yet.

Quoted 4 lines

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-obex-Use-GLib-helper-function-to-manipulate-paths.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0002-autopair-Don-t-handle-the-iCade.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0004-agent-Assert-possible-infinite-loop.patch
-> Any reason for not applying it upstream too?

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

I've posted those patches to the list as well.

And, do you know why they weren't accepted? (it's for trying to get them merged and not needing to carry them forever)

Read the threads for the various patches?

Mailing-lists, awful at tracking patches since forever...

But, for example for the patch allowing to run without systemd --user:
http://marc.info/?t=138159296100001&r=1&w=2

What is the point in providing a "--disable-systemd" configure flag that needs this patches to be applied to be really working? Looks like "--enable-systemd" will be needed if we don't apply that patches downstream...

Also:
http://www.spinics.net/lists/linux-bluetooth/msg40136.html
http://www.spinics.net/lists/linux-bluetooth/msg41264.html

Look to have no reply at all

And for 0004-agent-Assert-possible-infinite-loop.patch I can't find the relevant thread :(

#5 lore raw
In reply to Pacho Ramos
Quoted 5 lines · Pacho Ramos

[...]

Quoted 4 lines
Quoted 3 lines

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-work-around-Logitech-diNovo-Edge-keyboard-firmware-i.patch
-> Taking care this looks to be a really old issue, maybe using the workaround would be the only option for now :/

Quoted 7 lines
Quoted 4 lines

I have no hardware to test this on, I snatched it from Ubuntu's bluez 4 package.

Cheers

OK, thanks :)

Looks to be still needed:
https://bugs.gentoo.org/show_bug.cgi?id=501120