Skip to contentSkip to conversation

kernel/trace: fix compiler warning

PATCH In review Qiaowei Ren 2 participants 2 messages Feb 11, 2014 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/trace: fix compiler warning

The patch fixes the following compiler warning:
CC kernel/trace/trace_events.o
kernel/trace/trace_events.c: In function 'event_enable_read' kernel/trace/trace_events.c:693: warning: 'flags' may be used \
uninitialized in this function

---
 kernel/trace/trace_events.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/trace/trace_events.c +1 -1
index e71ffd4..b7915f2 100644
@@ -690,7 +690,7 @@ event_enable_read(struct file *filp, char __user *ubuf, size_t cnt,
 		  loff_t *ppos)
 {
 	struct ftrace_event_file *file;
-	unsigned long flags;
+	unsigned long flags = 0;
 	char buf[4] = "0";
 
 	mutex_lock(&event_mutex);
Signature · 1 line
1.7.1
maintainer
#1 lore raw
Quoted 5 lines · On Tue, 11 Feb 2014 23:41:41 +0800 Qiaowei Ren <[email protected]> wrote:

The patch fixes the following compiler warning:
CC kernel/trace/trace_events.o
kernel/trace/trace_events.c: In function 'event_enable_read' kernel/trace/trace_events.c:693: warning: 'flags' may be used \
uninitialized in this function

You don't happen to have the branch profilers enabled?

Is CONFIG_TRACE_BRANCH_PROFILING set?

Quoted 11 lines
---
 kernel/trace/trace_events.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/trace/trace_events.c +0 -0
index e71ffd4..b7915f2 100644

kernel/trace/trace_events.c event_enable_read(struct file *filp, char __user *ubuf, size_t cnt, · line 696

Quoted 8 lines
kernel/trace/trace_events.c +1 -1
@@ -690,7 +690,7 @@ event_enable_read(struct file *filp, char __user *ubuf, size_t cnt,
 		  loff_t *ppos)
 {
 	struct ftrace_event_file *file;
-	unsigned long flags;
+	unsigned long flags = 0;
 	char buf[4] = "0";
 
 	mutex_lock(&event_mutex);

False warning, and most likely because the branch profilers screw up gcc's ability to figure these things out.

Here's the content of that function:

        mutex_lock(&event_mutex);
        file = event_file_data(filp);
        if (likely(file))
                flags = file->flags;
        mutex_unlock(&event_mutex);

        if (!file)
                return -ENODEV;

        if (flags & FTRACE_EVENT_FL_ENABLED &&

Pretty obvious that flags can not be used uninitialized. If you happen to have BRANCH profiling enabled, you must ignore all the gcc "might be used uninitialized" warnings. They are useless.

This is not a bug, sorry.

-- Steve