hfsplus: fix remount issue
Subsystems (2)
Vyacheslav Dubeyko
maintainerPATCH v3 6/15 hfsplus: fix remount issue
From: Vyacheslav Dubeyko <[email protected]>
Subject: [PATCH v3 06/15] hfsplus: fix remount issue
Current implementation of HFS+ driver has small issue with remount option. Namely, for example, you are unable to remount from RO mode into RW mode by means of command "mount -o remount,rw /dev/loop0 /mnt/hfsplus". Trying to execute sequence of commands is resulted with error message:
mount /dev/loop0 /mnt/hfsplus
mount -o remount,ro /dev/loop0 /mnt/hfsplus mount -o remount,rw /dev/loop0 /mnt/hfsplus
mount: you must specify the filesystem type
mount -t hfsplus -o remount,rw /dev/loop0 /mnt/hfsplus
mount: /mnt/hfsplus not mounted or bad option
The reason of such issue is failure of mount syscall:
mount("/dev/loop0", "/mnt/hfsplus", 0x2282a60, MS_MGC_VAL|MS_REMOUNT, NULL) = -1 EINVAL (Invalid argument)
Namely, hfsplus_parse_options_remount() method receives empty "input" argument and return false in such case. As a result, hfsplus_remount() returns -EINVAL error code.
This patch fixes the issue by means of return true for the case of empty "input" argument in hfsplus_parse_options_remount() method.
--- fs/hfsplus/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/hfsplus/options.c +1 -1
@@ -76,7 +76,7 @@ int hfsplus_parse_options_remount(char *input, struct hfsplus_sb_info *sbi)int token;if (!input) -return 0 ; +return 1 ;while ((p =strsep (&input,"," )) !=NULL ) {if (!*p)
Signature · 1 line
1.7.9.5