staging: r8188eu: Remove dead code
PATCH 1/1 staging: r8188eu: Remove dead code
There are a few lines in this driver that depend on a macro CONFIG_BT_COEXIST. But there's no Kconfig symbol of that name nor is there a preprocessor define for that string. So remove these lines.
---
Entirely untested.
Fun fact: two years ago, code depending on the same undefined macro was removed from rtl8192cu, see commit 9ef11f7b34c0 ("rtl8192cu: Remove dead code never selected"). I wonder where this macro originated.
drivers/staging/rtl8188eu/include/rtw_debug.h | 10 ---------- drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 4 ---- 2 files changed, 14 deletions(-)
drivers/staging/rtl8188eu/include/rtw_debug.h +0 -10
@@ -277,14 +277,4 @@ int proc_get_rssi_disp(char *page, char **start,int proc_set_rssi_disp (struct file *file,const char __user *buffer,unsigned long count,void *data); -#ifdef CONFIG_BT_COEXIST -int proc_get_btcoex_dbg (char *page,char **start, -off_t offset,int count, -int *eof,void *data); - -int proc_set_btcoex_dbg (struct file *file,const char *buffer, -signed long count,void *data); - -#endif /* CONFIG_BT_COEXIST */ -#endif /* __RTW_DEBUG_H__ */
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h +0 -4
@@ -206,10 +206,6 @@ struct pwrctrl_priv {u8 bInternalAutoSuspend;u8 bInSuspend; -#ifdef CONFIG_BT_COEXIST -u8 bAutoResume; -u8 autopm_cnt; -#endif u8 bSupportRemoteWakeup;struct timer_list pwr_state_check_timer;int pwr_state_check_interval;
Signature · 1 line
1.8.5.3
Greg Kroah-Hartman
maintainerQuoted 11 lines · Paul Bolle
There are a few lines in this driver that depend on a macro
CONFIG_BT_COEXIST. But there's noKconfigsymbol of that name nor is there a preprocessor define for that string. So remove these lines.Signed-off-by Paul Bolle <[email protected]>---
Entirely untested.Fun fact: two years ago, code depending on the same undefined macro was removed from rtl8192cu, see commit
9ef11f7b34c0("rtl8192cu: Remove dead code never selected"). I wonder where this macro originated.
It comes from the stand-alone version of this driver, and the config options that it "provides" when building. So expect it to constantly show up until this company stops relying on their internal tree...
thanks,
greg k-h