Revert "ACPI / video: Add HP EliteBook Revolve 810 to the blacklist"

This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e.

The referenced commit added HP EliteBook Revolve 810 to the ACPI video detected blacklist so that only the native Intel backlight interface was exported.

However, this turned to be wrong solution after all. The ACPI video interface works and as long as we only use that there are no problems. So we can revert this commit and stick to use the backlight interface provided by the ACPI video driver.

(Using Intel native interface will not work after resume since the ACPI video driver will restore it's state which takes control over the native one. That's a separate thing and should be addressed in the ACPI video driver, I suppose.)

References: https://bugzilla.kernel.org/show_bug.cgi?id=70231

Cc Aaron Lu <[email protected]>

Signed-off-by Mika Westerberg <[email protected]>

---
Rafael,

This turned out to be misunderstanding from my side. I should have investigated this further before submitting the original patch. Sorry about that.

Aaron,

Thanks for the investigation and pointing me to the right direction (e.g to use acpi_video0 over the native one).

At Fri, 14 Feb 2014 14:34:07 +0200,

Quoted 23 lines · Mika Westerberg

This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e.

The referenced commit added HP EliteBook Revolve 810 to the ACPI video detected blacklist so that only the native Intel backlight interface was exported.

However, this turned to be wrong solution after all. The ACPI video interface works and as long as we only use that there are no problems. So we can revert this commit and stick to use the backlight interface provided by the ACPI video driver.

(Using Intel native interface will not work after resume since the ACPI video driver will restore it's state which takes control over the native one. That's a separate thing and should be addressed in the ACPI video driver, I suppose.)

References: https://bugzilla.kernel.org/show_bug.cgi?id=70231

Cc Aaron Lu <[email protected]>

Signed-off-by Mika Westerberg <[email protected]>

---
Rafael,

Quoted 8 lines

This turned out to be misunderstanding from my side. I should have investigated this further before submitting the original patch. Sorry about that.

Aaron,

Thanks for the investigation and pointing me to the right direction (e.g to use acpi_video0 over the native one).

Could you check whether the ACPI video still really works even if you remove the recent acpi_osi blacklist entry below? It might be that BIOS changed its mind to behave more kindly as if handling for Win7.

Takashi

---

drivers/acpi/blacklist.c +1 -0

index 10e4964d051a..64d14406465d 100644
@@ -322,6 +322,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"),
 		},
 	},
+#if 0
 	{
 	.callback = dmi_disable_osi_win8,
 	.ident = "HP ProBook 2013 models",

Quoted 60 lines · Takashi Iwai

At Fri, 14 Feb 2014 14:34:07 +0200,

Quoted 23 lines · Mika Westerberg

This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e.

The referenced commit added HP EliteBook Revolve 810 to the ACPI video detected blacklist so that only the native Intel backlight interface was exported.

However, this turned to be wrong solution after all. The ACPI video interface works and as long as we only use that there are no problems. So we can revert this commit and stick to use the backlight interface provided by the ACPI video driver.

(Using Intel native interface will not work after resume since the ACPI video driver will restore it's state which takes control over the native one. That's a separate thing and should be addressed in the ACPI video driver, I suppose.)

References: https://bugzilla.kernel.org/show_bug.cgi?id=70231

Cc Aaron Lu <[email protected]>

Signed-off-by Mika Westerberg <[email protected]>

---
Rafael,

Quoted 8 lines

This turned out to be misunderstanding from my side. I should have investigated this further before submitting the original patch. Sorry about that.

Aaron,

Thanks for the investigation and pointing me to the right direction (e.g to use acpi_video0 over the native one).

Could you check whether the ACPI video still really works even if you remove the recent acpi_osi blacklist entry below? It might be that BIOS changed its mind to behave more kindly as if handling for Win7.

Takashi

---

drivers/acpi/blacklist.c +2 -0

index 10e4964d051a..64d14406465d 100644
@@ -322,6 +322,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"),
 		},
 	},
+#if 0
 	{
 	.callback = dmi_disable_osi_win8,
 	.ident = "HP ProBook 2013 models",

@@ -372,6 +373,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
 		},
 	},
+#endif
 

drivers/acpi/blacklist.c static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { · line 379

Quoted 2 lines

drivers/acpi/blacklist.c +0 -0

 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.

After this patch is applied, the ACPI backlight doesn't work anymore. The brightness stays the same, no matter what I do.

At Fri, 14 Feb 2014 16:03:16 +0200,

Quoted 62 lines · Mika Westerberg

Quoted 60 lines · Takashi Iwai

At Fri, 14 Feb 2014 14:34:07 +0200,

Quoted 23 lines · Mika Westerberg

This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e.

The referenced commit added HP EliteBook Revolve 810 to the ACPI video detected blacklist so that only the native Intel backlight interface was exported.

However, this turned to be wrong solution after all. The ACPI video interface works and as long as we only use that there are no problems. So we can revert this commit and stick to use the backlight interface provided by the ACPI video driver.

(Using Intel native interface will not work after resume since the ACPI video driver will restore it's state which takes control over the native one. That's a separate thing and should be addressed in the ACPI video driver, I suppose.)

References: https://bugzilla.kernel.org/show_bug.cgi?id=70231

Cc Aaron Lu <[email protected]>

Signed-off-by Mika Westerberg <[email protected]>

---
Rafael,

Quoted 8 lines

This turned out to be misunderstanding from my side. I should have investigated this further before submitting the original patch. Sorry about that.

Aaron,

Thanks for the investigation and pointing me to the right direction (e.g to use acpi_video0 over the native one).

Could you check whether the ACPI video still really works even if you remove the recent acpi_osi blacklist entry below? It might be that BIOS changed its mind to behave more kindly as if handling for Win7.

Takashi

---

drivers/acpi/blacklist.c +2 -0

index 10e4964d051a..64d14406465d 100644
@@ -322,6 +322,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"),
 		},
 	},
+#if 0
 	{
 	.callback = dmi_disable_osi_win8,
 	.ident = "HP ProBook 2013 models",

@@ -372,6 +373,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
 		},
 	},
+#endif
 

Quoted 5 lines

drivers/acpi/blacklist.c static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { · line 379

Quoted 2 lines

drivers/acpi/blacklist.c +0 -0

 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.

After this patch is applied, the ACPI backlight doesn't work anymore. The brightness stays the same, no matter what I do.

So, you need the video blacklist when acpi_osi blacklist doesn't exist, right?

Quoted 70 lines · Takashi Iwai

At Fri, 14 Feb 2014 16:03:16 +0200,

Quoted 67 lines · Mika Westerberg

Quoted 55 lines · Takashi Iwai

At Fri, 14 Feb 2014 14:34:07 +0200,

Quoted 23 lines · Mika Westerberg

This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e.

The referenced commit added HP EliteBook Revolve 810 to the ACPI video detected blacklist so that only the native Intel backlight interface was exported.

However, this turned to be wrong solution after all. The ACPI video interface works and as long as we only use that there are no problems. So we can revert this commit and stick to use the backlight interface provided by the ACPI video driver.

(Using Intel native interface will not work after resume since the ACPI video driver will restore it's state which takes control over the native one. That's a separate thing and should be addressed in the ACPI video driver, I suppose.)

References: https://bugzilla.kernel.org/show_bug.cgi?id=70231

Cc Aaron Lu <[email protected]>

Signed-off-by Mika Westerberg <[email protected]>

---
Rafael,

Quoted 8 lines

This turned out to be misunderstanding from my side. I should have investigated this further before submitting the original patch. Sorry about that.

Aaron,

Thanks for the investigation and pointing me to the right direction (e.g to use acpi_video0 over the native one).

Could you check whether the ACPI video still really works even if you remove the recent acpi_osi blacklist entry below? It might be that BIOS changed its mind to behave more kindly as if handling for Win7.

Takashi

---

drivers/acpi/blacklist.c +1 -0

index 10e4964d051a..64d14406465d 100644
@@ -322,6 +322,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"),
 		},
 	},
+#if 0
 	{
 	.callback = dmi_disable_osi_win8,
 	.ident = "HP ProBook 2013 models",

drivers/acpi/blacklist.c static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { · line 379

Quoted 7 lines

drivers/acpi/blacklist.c +1 -0

@@ -372,6 +373,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
 		},
 	},
+#endif
 
 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.

After this patch is applied, the ACPI backlight doesn't work anymore. The brightness stays the same, no matter what I do.

Quoted 2 lines

So, you need the video blacklist when acpi_osi blacklist doesn't exist, right?

In my case I don't actually need video blacklist if I use only ACPI video for backlight control. Then it works fine.

However, using intel_backlight will cause ACPI video to restore its settings over the Intel one on resume.

At Fri, 14 Feb 2014 16:16:52 +0200,

Quoted 75 lines · Mika Westerberg

Quoted 72 lines · Takashi Iwai

At Fri, 14 Feb 2014 16:03:16 +0200,

Quoted 62 lines · Mika Westerberg

Quoted 60 lines · Takashi Iwai

At Fri, 14 Feb 2014 14:34:07 +0200,

Quoted 23 lines · Mika Westerberg

This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e.

The referenced commit added HP EliteBook Revolve 810 to the ACPI video detected blacklist so that only the native Intel backlight interface was exported.

However, this turned to be wrong solution after all. The ACPI video interface works and as long as we only use that there are no problems. So we can revert this commit and stick to use the backlight interface provided by the ACPI video driver.

(Using Intel native interface will not work after resume since the ACPI video driver will restore it's state which takes control over the native one. That's a separate thing and should be addressed in the ACPI video driver, I suppose.)

References: https://bugzilla.kernel.org/show_bug.cgi?id=70231

Cc Aaron Lu <[email protected]>

Signed-off-by Mika Westerberg <[email protected]>

---
Rafael,

Quoted 8 lines

This turned out to be misunderstanding from my side. I should have investigated this further before submitting the original patch. Sorry about that.

Aaron,

Thanks for the investigation and pointing me to the right direction (e.g to use acpi_video0 over the native one).

Could you check whether the ACPI video still really works even if you remove the recent acpi_osi blacklist entry below? It might be that BIOS changed its mind to behave more kindly as if handling for Win7.

Takashi

---

drivers/acpi/blacklist.c +2 -0

index 10e4964d051a..64d14406465d 100644
@@ -322,6 +322,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"),
 		},
 	},
+#if 0
 	{
 	.callback = dmi_disable_osi_win8,
 	.ident = "HP ProBook 2013 models",

@@ -372,6 +373,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
 		},
 	},
+#endif
 

Quoted 5 lines

drivers/acpi/blacklist.c static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { · line 379

Quoted 2 lines

drivers/acpi/blacklist.c +0 -0

 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.

After this patch is applied, the ACPI backlight doesn't work anymore. The brightness stays the same, no matter what I do.

So, you need the video blacklist when acpi_osi blacklist doesn't exist, right?

Quoted 2 lines

In my case I don't actually need video blacklist if I use only ACPI video for backlight control. Then it works fine.

Hmm, after removing acpi_osi blacklist above, you loose the ACPI video backlight doesn't work, no? If so, you need the video blacklist. Am I missing anything obvious...?

Quoted 2 lines

However, using intel_backlight will cause ACPI video to restore its settings over the Intel one on resume.

I guess the very reason why ACPI video backlight doesn't work in Win8 BIOS mode -- ACPI video won't conflict the native backlight.

Quoted 80 lines · Takashi Iwai

At Fri, 14 Feb 2014 16:16:52 +0200,

Quoted 77 lines · Mika Westerberg

Quoted 64 lines · Takashi Iwai

At Fri, 14 Feb 2014 16:03:16 +0200,

Quoted 62 lines · Mika Westerberg

Quoted 60 lines · Takashi Iwai

At Fri, 14 Feb 2014 14:34:07 +0200,

Quoted 23 lines · Mika Westerberg

This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e.

The referenced commit added HP EliteBook Revolve 810 to the ACPI video detected blacklist so that only the native Intel backlight interface was exported.

However, this turned to be wrong solution after all. The ACPI video interface works and as long as we only use that there are no problems. So we can revert this commit and stick to use the backlight interface provided by the ACPI video driver.

(Using Intel native interface will not work after resume since the ACPI video driver will restore it's state which takes control over the native one. That's a separate thing and should be addressed in the ACPI video driver, I suppose.)

References: https://bugzilla.kernel.org/show_bug.cgi?id=70231

Cc Aaron Lu <[email protected]>

Signed-off-by Mika Westerberg <[email protected]>

---
Rafael,

Quoted 8 lines

This turned out to be misunderstanding from my side. I should have investigated this further before submitting the original patch. Sorry about that.

Aaron,

Thanks for the investigation and pointing me to the right direction (e.g to use acpi_video0 over the native one).

Could you check whether the ACPI video still really works even if you remove the recent acpi_osi blacklist entry below? It might be that BIOS changed its mind to behave more kindly as if handling for Win7.

Takashi

---

drivers/acpi/blacklist.c +2 -0

index 10e4964d051a..64d14406465d 100644
@@ -322,6 +322,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"),
 		},
 	},
+#if 0
 	{
 	.callback = dmi_disable_osi_win8,
 	.ident = "HP ProBook 2013 models",

@@ -372,6 +373,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
 		},
 	},
+#endif
 

Quoted 8 lines

Quoted 5 lines

drivers/acpi/blacklist.c static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { · line 379

Quoted 2 lines

drivers/acpi/blacklist.c +0 -0

 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.

After this patch is applied, the ACPI backlight doesn't work anymore. The brightness stays the same, no matter what I do.

So, you need the video blacklist when acpi_osi blacklist doesn't exist, right?

In my case I don't actually need video blacklist if I use only ACPI video for backlight control. Then it works fine.

Quoted 3 lines

Hmm, after removing acpi_osi blacklist above, you loose the ACPI video backlight doesn't work, no? If so, you need the video blacklist. Am I missing anything obvious...?

Yes, the machine needs to be in acpi_osi blacklist then the ACPI video works fine.

At Fri, 14 Feb 2014 16:45:24 +0200,

Quoted 82 lines · Mika Westerberg

Quoted 80 lines · Takashi Iwai

At Fri, 14 Feb 2014 16:16:52 +0200,

Quoted 77 lines · Mika Westerberg

Quoted 64 lines · Takashi Iwai

At Fri, 14 Feb 2014 16:03:16 +0200,

Quoted 62 lines · Mika Westerberg

Quoted 60 lines · Takashi Iwai

At Fri, 14 Feb 2014 14:34:07 +0200,

Quoted 23 lines · Mika Westerberg

This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e.

The referenced commit added HP EliteBook Revolve 810 to the ACPI video detected blacklist so that only the native Intel backlight interface was exported.

However, this turned to be wrong solution after all. The ACPI video interface works and as long as we only use that there are no problems. So we can revert this commit and stick to use the backlight interface provided by the ACPI video driver.

(Using Intel native interface will not work after resume since the ACPI video driver will restore it's state which takes control over the native one. That's a separate thing and should be addressed in the ACPI video driver, I suppose.)

References: https://bugzilla.kernel.org/show_bug.cgi?id=70231

Cc Aaron Lu <[email protected]>

Signed-off-by Mika Westerberg <[email protected]>

---
Rafael,

Quoted 8 lines

This turned out to be misunderstanding from my side. I should have investigated this further before submitting the original patch. Sorry about that.

Aaron,

Thanks for the investigation and pointing me to the right direction (e.g to use acpi_video0 over the native one).

Could you check whether the ACPI video still really works even if you remove the recent acpi_osi blacklist entry below? It might be that BIOS changed its mind to behave more kindly as if handling for Win7.

Takashi

---

drivers/acpi/blacklist.c +2 -0

index 10e4964d051a..64d14406465d 100644
@@ -322,6 +322,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"),
 		},
 	},
+#if 0
 	{
 	.callback = dmi_disable_osi_win8,
 	.ident = "HP ProBook 2013 models",

@@ -372,6 +373,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
 		},
 	},
+#endif
 

Quoted 8 lines

Quoted 5 lines

drivers/acpi/blacklist.c static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { · line 379

Quoted 2 lines

drivers/acpi/blacklist.c +0 -0

 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.

After this patch is applied, the ACPI backlight doesn't work anymore. The brightness stays the same, no matter what I do.

So, you need the video blacklist when acpi_osi blacklist doesn't exist, right?

In my case I don't actually need video blacklist if I use only ACPI video for backlight control. Then it works fine.

Quoted 6 lines

Quoted 3 lines

Hmm, after removing acpi_osi blacklist above, you loose the ACPI video backlight doesn't work, no? If so, you need the video blacklist. Am I missing anything obvious...?

Yes, the machine needs to be in acpi_osi blacklist then the ACPI video works fine.

The acpi_osi blacklist is just a workaround, and if we have better solutions, it should be removed. That's why I'm asking it.

So, after removing acpi_osi blacklist, and keeping your video blacklist patch, the backlight works? If yes, as mentioned, we should think of rather extending this video blacklist to more EliteBook G1 and ProBook G1 machines, and remove acpi_osi blacklist instead.

Now hp-wireless is there, so the rfkill part should work without acpi_osi blacklist, too.

Quoted 91 lines · Takashi Iwai

At Fri, 14 Feb 2014 16:45:24 +0200,

Quoted 82 lines · Mika Westerberg

Quoted 80 lines · Takashi Iwai

At Fri, 14 Feb 2014 16:16:52 +0200,

Quoted 77 lines · Mika Westerberg

Quoted 64 lines · Takashi Iwai

At Fri, 14 Feb 2014 16:03:16 +0200,

Quoted 62 lines · Mika Westerberg

Quoted 60 lines · Takashi Iwai

At Fri, 14 Feb 2014 14:34:07 +0200,

Quoted 23 lines · Mika Westerberg

This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e.

The referenced commit added HP EliteBook Revolve 810 to the ACPI video detected blacklist so that only the native Intel backlight interface was exported.

However, this turned to be wrong solution after all. The ACPI video interface works and as long as we only use that there are no problems. So we can revert this commit and stick to use the backlight interface provided by the ACPI video driver.

(Using Intel native interface will not work after resume since the ACPI video driver will restore it's state which takes control over the native one. That's a separate thing and should be addressed in the ACPI video driver, I suppose.)

References: https://bugzilla.kernel.org/show_bug.cgi?id=70231

Cc Aaron Lu <[email protected]>

Signed-off-by Mika Westerberg <[email protected]>

---
Rafael,

Quoted 8 lines

This turned out to be misunderstanding from my side. I should have investigated this further before submitting the original patch. Sorry about that.

Aaron,

Thanks for the investigation and pointing me to the right direction (e.g to use acpi_video0 over the native one).

Could you check whether the ACPI video still really works even if you remove the recent acpi_osi blacklist entry below? It might be that BIOS changed its mind to behave more kindly as if handling for Win7.

Takashi

---

drivers/acpi/blacklist.c +2 -0

index 10e4964d051a..64d14406465d 100644
@@ -322,6 +322,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"),
 		},
 	},
+#if 0
 	{
 	.callback = dmi_disable_osi_win8,
 	.ident = "HP ProBook 2013 models",

@@ -372,6 +373,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
 		},
 	},
+#endif
 

Quoted 8 lines

Quoted 5 lines

drivers/acpi/blacklist.c static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { · line 379

Quoted 2 lines

drivers/acpi/blacklist.c +0 -0

 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.

After this patch is applied, the ACPI backlight doesn't work anymore. The brightness stays the same, no matter what I do.

So, you need the video blacklist when acpi_osi blacklist doesn't exist, right?

In my case I don't actually need video blacklist if I use only ACPI video for backlight control. Then it works fine.

Quoted 6 lines

Quoted 3 lines

Hmm, after removing acpi_osi blacklist above, you loose the ACPI video backlight doesn't work, no? If so, you need the video blacklist. Am I missing anything obvious...?

Yes, the machine needs to be in acpi_osi blacklist then the ACPI video works fine.

Quoted 7 lines

The acpi_osi blacklist is just a workaround, and if we have better solutions, it should be removed. That's why I'm asking it.

So, after removing acpi_osi blacklist, and keeping your video blacklist patch, the backlight works? If yes, as mentioned, we should think of rather extending this video blacklist to more EliteBook G1 and ProBook G1 machines, and remove acpi_osi blacklist instead.

Agree.

Quoted 1 line

Quoted 2 lines

Now hp-wireless is there, so the rfkill part should work without acpi_osi blacklist, too.

Suppose we have some work around of making backlight work for them in Win8 mode, it seems the acpi_osi blacklist is ready to be removed now?

The acpi_osi blacklist is just a workaround, and if we have better solutions, it should be removed. That's why I'm asking it.

So, after removing acpi_osi blacklist, and keeping your video blacklist patch, the backlight works?

If yes, as mentioned, we should think of rather extending this video blacklist to more EliteBook G1 and ProBook G1 machines, and remove acpi_osi blacklist instead.

Quoted 5 lines · Takashi Iwai

The acpi_osi blacklist is just a workaround, and if we have better solutions, it should be removed. That's why I'm asking it.

So, after removing acpi_osi blacklist, and keeping your video blacklist patch, the backlight works?

Yes, the backlight works (there is only intel_backlight listed under /sys/class/backlight).

Quoted 3 lines

If yes, as mentioned, we should think of rather extending this video blacklist to more EliteBook G1 and ProBook G1 machines, and remove acpi_osi blacklist instead.

Makes sense to me. (Well, I'm fine as long as backlight on my machine works ;-))

Aaron, Rafael, any comments on this?

Quoted 14 lines · Mika Westerberg

Quoted 5 lines · Takashi Iwai

The acpi_osi blacklist is just a workaround, and if we have better solutions, it should be removed. That's why I'm asking it.

So, after removing acpi_osi blacklist, and keeping your video blacklist patch, the backlight works?

Yes, the backlight works (there is only intel_backlight listed under /sys/class/backlight).

Quoted 3 lines

If yes, as mentioned, we should think of rather extending this video blacklist to more EliteBook G1 and ProBook G1 machines, and remove acpi_osi blacklist instead.

Quoted 4 lines

Makes sense to me. (Well, I'm fine as long as backlight on my machine works ;-))

Aaron, Rafael, any comments on this?

I generally agree with Takashi, but I'm not sure what to do for 3.14.

Quoted 20 lines · Rafael J. Wysocki

Quoted 18 lines · Mika Westerberg

Quoted 5 lines · Takashi Iwai

The acpi_osi blacklist is just a workaround, and if we have better solutions, it should be removed. That's why I'm asking it.

So, after removing acpi_osi blacklist, and keeping your video blacklist patch, the backlight works?

Yes, the backlight works (there is only intel_backlight listed under /sys/class/backlight).

Quoted 3 lines

If yes, as mentioned, we should think of rather extending this video blacklist to more EliteBook G1 and ProBook G1 machines, and remove acpi_osi blacklist instead.

Makes sense to me. (Well, I'm fine as long as backlight on my machine works ;-))

Aaron, Rafael, any comments on this?

Quoted 1 line

I generally agree with Takashi, but I'm not sure what to do for 3.14.

I can re-base the previously sent patch titled:
[PATCH] ACPI / video: Add systems that should favor native backlight interface And put Mika's system into the DMI table that will use native backlight interface in video module and remove it from video_detect's DMI table at the same time. Does this sound OK?

Quoted 20 lines · Rafael J. Wysocki

Quoted 18 lines · Mika Westerberg

Quoted 5 lines · Takashi Iwai

The acpi_osi blacklist is just a workaround, and if we have better solutions, it should be removed. That's why I'm asking it.

So, after removing acpi_osi blacklist, and keeping your video blacklist patch, the backlight works?

Yes, the backlight works (there is only intel_backlight listed under /sys/class/backlight).

Quoted 3 lines

If yes, as mentioned, we should think of rather extending this video blacklist to more EliteBook G1 and ProBook G1 machines, and remove acpi_osi blacklist instead.

Makes sense to me. (Well, I'm fine as long as backlight on my machine works ;-))

Aaron, Rafael, any comments on this?

Quoted 1 line

I generally agree with Takashi, but I'm not sure what to do for 3.14.

I can re-base the previously sent patch titled:
[PATCH] ACPI / video: Add systems that should favor native backlight interface And put Mika's system into the DMI table that will use native backlight interface in video module and remove it from video_detect's DMI table at the same time. Does this sound OK?

At Mon, 17 Feb 2014 13:52:46 +0800,

Quoted 22 lines · Aaron Lu

Quoted 20 lines · Rafael J. Wysocki

Quoted 18 lines · Mika Westerberg

Quoted 5 lines · Takashi Iwai

The acpi_osi blacklist is just a workaround, and if we have better solutions, it should be removed. That's why I'm asking it.

So, after removing acpi_osi blacklist, and keeping your video blacklist patch, the backlight works?

Yes, the backlight works (there is only intel_backlight listed under /sys/class/backlight).

Quoted 3 lines

If yes, as mentioned, we should think of rather extending this video blacklist to more EliteBook G1 and ProBook G1 machines, and remove acpi_osi blacklist instead.

Makes sense to me. (Well, I'm fine as long as backlight on my machine works ;-))

Aaron, Rafael, any comments on this?

Quoted 7 lines

Quoted 1 line

I generally agree with Takashi, but I'm not sure what to do for 3.14.

I can re-base the previously sent patch titled:
[PATCH] ACPI / video: Add systems that should favor native backlight interface And put Mika's system into the DMI table that will use native backlight interface in video module and remove it from video_detect's DMI table at the same time. Does this sound OK?

Rather put more generic DMI entries for the recent HP ProBook and EliteBook machines as in acpi_osi blacklist:

	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP ProBook 2013 models",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook "),
		     DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
		},
	},
	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP EliteBook 2013 models",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
		     DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
		},
	},
	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP ZBook 14",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 14"),
		},
	},
	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP ZBook 15",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 15"),
		},
	},
	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP ZBook 17",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 17"),
		},
	},
	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP EliteBook 8780w",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
		},
	},

All these are known to have different behavior with Win8, including the broken ACPI backlight. Once after merging that patch, we can revert the commit 2d4054d84224.

I suppose it'd be OK for to do these for 3.14, since the acpi_osi commit was merged first in 3.14. Then we can continue fixing in a saner way.

thanks,

Takashi

At Fri, 14 Feb 2014 16:03:16 +0200,

Quoted 62 lines · Mika Westerberg

Quoted 60 lines · Takashi Iwai

At Fri, 14 Feb 2014 14:34:07 +0200,

Quoted 23 lines · Mika Westerberg

This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e.

The referenced commit added HP EliteBook Revolve 810 to the ACPI video detected blacklist so that only the native Intel backlight interface was exported.

However, this turned to be wrong solution after all. The ACPI video interface works and as long as we only use that there are no problems. So we can revert this commit and stick to use the backlight interface provided by the ACPI video driver.

(Using Intel native interface will not work after resume since the ACPI video driver will restore it's state which takes control over the native one. That's a separate thing and should be addressed in the ACPI video driver, I suppose.)

References: https://bugzilla.kernel.org/show_bug.cgi?id=70231

Cc Aaron Lu <[email protected]>

Signed-off-by Mika Westerberg <[email protected]>

---
Rafael,

Quoted 8 lines

This turned out to be misunderstanding from my side. I should have investigated this further before submitting the original patch. Sorry about that.

Aaron,

Thanks for the investigation and pointing me to the right direction (e.g to use acpi_video0 over the native one).

Could you check whether the ACPI video still really works even if you remove the recent acpi_osi blacklist entry below? It might be that BIOS changed its mind to behave more kindly as if handling for Win7.

Takashi

---

drivers/acpi/blacklist.c +2 -0

index 10e4964d051a..64d14406465d 100644
@@ -322,6 +322,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_VERSION, "2349D15"),
 		},
 	},
+#if 0
 	{
 	.callback = dmi_disable_osi_win8,
 	.ident = "HP ProBook 2013 models",

@@ -372,6 +373,7 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
 		},
 	},
+#endif
 

Quoted 5 lines

drivers/acpi/blacklist.c static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { · line 379

Quoted 2 lines

drivers/acpi/blacklist.c +0 -0

 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.

After this patch is applied, the ACPI backlight doesn't work anymore. The brightness stays the same, no matter what I do.

So, you need the video blacklist when acpi_osi blacklist doesn't exist, right?