arm: msm: remove MACH_MSM7X30_SURF
Subsystems (3)
PATCH 1/1 arm: msm: remove MACH_MSM7X30_SURF
The Kconfig symbol MACH_MSM7X30_SURF was added in v2.6.35. It has never been used. Setting it has no effect. There are no calls for machine_is_mach_msm7x30(). This symbol can safely be removed.
---
Tested only with "git grep".
arch/arm/mach-msm/Kconfig | 7 ------- 1 file changed, 7 deletions(-)
arch/arm/mach-msm/Kconfig +0 -7
@@ -62,7 +62,6 @@ config ARCH_MSM7X30 select ARCH_MSM_SCORPION select CPU_V7 select GPIO_MSM_V1 - select MACH_MSM7X30_SURF # if ! select MSM_GPIOMUX select MSM_PROC_COMM select MSM_SMD
@@ -115,12 +114,6 @@ config MACH_TROUT help Support for the HTC Dream, T-Mobile G1, Android ADP1 devices. -config MACH_MSM7X30_SURF - depends on ARCH_MSM7X30 - bool "MSM7x30 SURF" - help - Support for the Qualcomm MSM7x30 SURF eval board. - config MACH_QSD8X50_SURF depends on ARCH_QSD8X50 bool "QSD8x50 SURF"
Signature · 1 line
1.8.5.3
Quoted 24 lines · Paul Bolle
The
KconfigsymbolMACH_MSM7X30_SURFwas added in v2.6.35. It has never been used. Setting it has no effect. There are no calls formachine_is_mach_msm7x30(). This symbol can safely be removed.Signed-off-by Paul Bolle <[email protected]>---
Tested only with "git grep".arch/arm/mach-msm/Kconfig | 7 ------- 1 file changed, 7 deletions(-)arch/arm/mach-msm/Kconfig +0
-1@@ -62,7 +62,6 @@ config ARCH_MSM7X30 select ARCH_MSM_SCORPION select CPU_V7 select GPIO_MSM_V1 - select MACH_MSM7X30_SURF # if ! select MSM_GPIOMUX select MSM_PROC_COMM select MSM_SMD
arch/arm/mach-msm/Kconfig config MACH_TROUT · line 123
Quoted 9 lines
arch/arm/mach-msm/Kconfig +0
-6@@ -115,12 +114,6 @@ config MACH_TROUT help Support for the HTC Dream, T-Mobile G1, Android ADP1 devices. -config MACH_MSM7X30_SURF - depends on ARCH_MSM7X30 - bool "MSM7x30 SURF" - help - Support for the Qualcomm MSM7x30 SURF eval board. -
It's not really enough .. There are support files for this platform, if you remove it you need to remove those files also. You could also go the other way and connect the config option to those files.
Daniel
Daniel,
Quoted 28 lines · On Sun, 2014-02-16 at 23:14 +0000, dwalker at fifo99.com wrote:
Quoted 27 lines · Paul Bolle
The
KconfigsymbolMACH_MSM7X30_SURFwas added in v2.6.35. It has never been used. Setting it has no effect. There are no calls formachine_is_mach_msm7x30(). This symbol can safely be removed.Signed-off-by Paul Bolle <[email protected]>---
Tested only with "git grep".arch/arm/mach-msm/Kconfig | 7 ------- 1 file changed, 7 deletions(-)arch/arm/mach-msm/Kconfig +0
-1@@ -62,7 +62,6 @@ config ARCH_MSM7X30 select ARCH_MSM_SCORPION select CPU_V7 select GPIO_MSM_V1 - select MACH_MSM7X30_SURF # if ! select MSM_GPIOMUX select MSM_PROC_COMM select MSM_SMD@@ -115,12 +114,6 @@ config MACH_TROUT help Support for the HTC Dream, T-Mobile G1, Android ADP1 devices.
Quoted 10 lines
arch/arm/mach-msm/Kconfig config MACH_TROUT · line 123
Quoted 6 lines
arch/arm/mach-msm/Kconfig +0
-6-config MACH_MSM7X30_SURF - depends on ARCH_MSM7X30 - bool "MSM7x30 SURF" - help - Support for the Qualcomm MSM7x30 SURF eval board. -It's not really enough .. There are support files for this platform, if you remove it you need to remove those files also. You could also go the other way and connect the config option to those files.
What support files are you thinking about here?
(Note that I need to rethink this patch anyway. The discussion about the patch that removes MACH_MXLADS showed me that machine_is_mach_msm7x30() is used in a more subtle way than I remembered. I hope to revisit this and similar patches in a few days to review them myself.)
Thanks,
Paul Bolle