Skip to contentSkip to conversation

usb: host: remove USB_ARCH_HAS_?HCI

PATCH In review Paul Bolle 2 participants 3 messages Feb 16, 2014 USB

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/2 usb: host: remove USB_ARCH_HAS_?HCI

USB_ARCH_HAS_EHCI, USB_ARCH_HAS_OHCI, and USB_ARCH_HAS_XHCI were made obsolete in v3.11. They have not been used ever since. Setting them has no effect. They can safely be removed.

---
Tested with "git grep".

Note that the comment in this Kconfig file (that is also removed) suggests to first remove the select statements for these symbols and then the symbols themselves. But I think it makes more sense to first delete these three symbols and then remove the selects statements (as that is removing a second order effect). But it could just as well be done with just one patch, I'd say.

 drivers/usb/Kconfig | 10 ----------
 1 file changed, 10 deletions(-)
drivers/usb/Kconfig +0 -10
index 2e6b832..e0cad44 100644
@@ -2,10 +2,6 @@
 # USB device configuration
 #
 
-# These are unused now, remove them once they are no longer selected
-config USB_ARCH_HAS_OHCI
-	bool
-
 config USB_OHCI_BIG_ENDIAN_DESC
 	bool
 
@@ -17,18 +13,12 @@ config USB_OHCI_LITTLE_ENDIAN
 	default n if STB03xxx || PPC_MPC52xx
 	default y
 
-config USB_ARCH_HAS_EHCI
-	bool
-
 config USB_EHCI_BIG_ENDIAN_MMIO
 	bool
 
 config USB_EHCI_BIG_ENDIAN_DESC
 	bool
 
-config USB_ARCH_HAS_XHCI
-	bool
-
 menuconfig USB_SUPPORT
 	bool "USB support"
 	depends on HAS_IOMEM
Signature · 1 line
1.8.5.3
Acked-by on v1 1/2
#1 lore raw
Quoted 8 lines · Paul Bolle

USB_ARCH_HAS_EHCI, USB_ARCH_HAS_OHCI, and USB_ARCH_HAS_XHCI were made obsolete in v3.11. They have not been used ever since. Setting them has no effect. They can safely be removed.

---
Tested with "git grep".

Quoted 6 lines

Note that the comment in this Kconfig file (that is also removed) suggests to first remove the select statements for these symbols and then the symbols themselves. But I think it makes more sense to first delete these three symbols and then remove the selects statements (as that is removing a second order effect). But it could just as well be done with just one patch, I'd say.

There's a simple reason for not getting rid of the symbols first. Doing it that way, as you did, leaves a window in which it's possible to select a non-existent symbol. If that's not an error, it ought to be.

Regardless, for both patches:

Alan Stern

author
#2 lore raw
Quoted 8 lines · Alan Stern
Quoted 6 lines · Paul Bolle

Note that the comment in this Kconfig file (that is also removed) suggests to first remove the select statements for these symbols and then the symbols themselves. But I think it makes more sense to first delete these three symbols and then remove the selects statements (as that is removing a second order effect). But it could just as well be done with just one patch, I'd say.

Quoted 4 lines

There's a simple reason for not getting rid of the symbols first. Doing it that way, as you did, leaves a window in which it's possible to select a non-existent symbol. If that's not an error, it ought to be.

It is silently ignored. I've contemplated diving in the kconfig code to see whether doing that could be made to trigger an error or, perhaps better, a warning. I've not made up my mind yet.

It's trivial to merge these two patches, though. So feel free to ask me to do that.

Quoted 3 lines

Regardless, for both patches:

Thanks.

Paul Bolle