spi: dup: Remove spi_master_put in spi_qup_remove
Subsystems (2)
PATCH 1/2 spi: dup: Remove spi_master_put in spi_qup_remove
This driver uses devm_spi_register_master() so don't explicitly call spi_master_put() in spi_qup_remove().
--- drivers/spi/spi-qup.c | 1 - 1 file changed, 1 deletion(-)
drivers/spi/spi-qup.c +0 -1
@@ -802,7 +802,6 @@ static int spi_qup_remove(struct platform_device *pdev)pm_runtime_put_noidle (&pdev->dev);pm_runtime_disable (&pdev->dev); -spi_master_put (master);return 0 ; }
Signature · 8 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/2 spi: dup: Convert ot let spi core handle checking transfer speed
Set master->max_speed_hz then spi core will handle checking transfer speed. So we can remove the same checking in this driver.
Also remove checking spi->chip_select in spi_qup_setup(), the checking is done by spi core.
--- drivers/spi/spi-qup.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-)
drivers/spi/spi-qup.c +1 -14
@@ -134,7 +134,6 @@ struct spi_qup {struct clk *cclk;/* core clock */ struct clk *iclk;/* interface clock */ int irq; -u32 max_speed_hz;spinlock_t lock;int in_fifo_sz;
@@ -517,18 +516,6 @@ static int spi_qup_setup(struct spi_device *spi)struct spi_qup *controller =spi_master_get_devdata (spi->master);struct spi_qup_device *chip =spi_get_ctldata (spi); -if (spi->chip_select >= spi->master->num_chipselect) { -dev_err (controller->dev,"invalid chip_select %d\n" , - spi->chip_select); -return -EINVAL ; - } - -if (spi->max_speed_hz > controller->max_speed_hz) { -dev_err (controller->dev,"invalid max_speed_hz %d\n" , - spi->max_speed_hz); -return -EINVAL ; - } -if (!chip) {/* First setup */ chip =kzalloc (sizeof (*chip),GFP_KERNEL );
@@ -629,6 +616,7 @@ static int spi_qup_probe(struct platform_device *pdev) master->mode_bits =SPI_CPOL |SPI_CPHA |SPI_CS_HIGH |SPI_LOOP ; master->num_chipselect =SPI_NUM_CHIPSELECTS ; master->bits_per_word_mask =SPI_BPW_RANGE_MASK (4 ,32 ); + master->max_speed_hz = max_freq; master->setup = spi_qup_setup; master->cleanup = spi_qup_cleanup; master->set_cs = spi_qup_set_cs;
@@ -645,7 +633,6 @@ static int spi_qup_probe(struct platform_device *pdev) controller->iclk = iclk; controller->cclk = cclk; controller->irq = irq; - controller->max_speed_hz = max_freq;spin_lock_init (&controller->lock);init_completion (&controller->done);
Signature · 8 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Just found the subject line is wrong...
Should be spi:qup rather than spi:dup.
I'm going to resend this patch serial.
2014-02-21 9:11 GMT+08:00 Axel Lin <[email protected]>:
Quoted 21 lines
This driver uses
devm_spi_register_master()so don't explicitly callspi_master_put()inspi_qup_remove().Signed-off-by Axel Lin <[email protected]>--- drivers/spi/spi-qup.c | 1 - 1 file changed, 1 deletion(-)drivers/spi/spi-qup.c +0
-2@@ -802,7 +802,6 @@ static int spi_qup_remove(struct platform_device *pdev)pm_runtime_put_noidle (&pdev->dev);pm_runtime_disable (&pdev->dev); -spi_master_put (master);return 0 ; } --
Quoted 4 lines
1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 4 lines · Axel Lin
This driver uses
devm_spi_register_master()so don't explicitly callspi_master_put()inspi_qup_remove().Signed-off-by Axel Lin <[email protected]>
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] spi: dup: Convert ot let spi core handle checking transfer speed
In reply to Axel LinQuoted 7 lines · Axel Lin
Set
master->max_speed_hzthen spi core will handle checking transfer speed. So we can remove the same checking in this driver.Also remove checking
spi->chip_selectinspi_qup_setup(), the checking is done by spi core.Signed-off-by Axel Lin <[email protected]>
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html