Skip to contentSkip to conversation

x264: SPE is not compatible with Altivec

PATCH In review David Nyström 3 participants 6 messages Feb 21, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x264: SPE is not compatible with Altivec

---
 meta/recipes-multimedia/x264/x264_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-multimedia/x264/x264_git.bb +1 -0
index 5ebf885..782c26e 100644
@@ -23,6 +23,7 @@ inherit lib_package pkgconfig
 X264_DISABLE_ASM = ""
 X264_DISABLE_ASM_armv4 = "--disable-asm"
 X264_DISABLE_ASM_armv5 = "--disable-asm"
+X264_DISABLE_ASM_e500v2 = "--disable-asm"
 
 EXTRA_OECONF = '--prefix=${prefix} \
                 --host=${HOST_SYS} \
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 10 lines · David Nyström
---
  meta/recipes-multimedia/x264/x264_git.bb | 1 +
  1 file changed, 1 insertion(+)
meta/recipes-multimedia/x264/x264_git.bb +0 -0
index 5ebf885..782c26e 100644

meta/recipes-multimedia/x264/x264_git.bb inherit lib_package pkgconfig · line 27

Quoted 5 lines
meta/recipes-multimedia/x264/x264_git.bb +1 -0
@@ -23,6 +23,7 @@ inherit lib_package pkgconfig
  X264_DISABLE_ASM = ""
  X264_DISABLE_ASM_armv4 = "--disable-asm"
  X264_DISABLE_ASM_armv5 = "--disable-asm"
+X264_DISABLE_ASM_e500v2 = "--disable-asm"
 

I think that this change really belongs in the e500v2 BSP, it's not generic enough to include in core.

Thanks
Sau!

Quoted 3 lines
meta/recipes-multimedia/x264/x264_git.bb +0 -0
  EXTRA_OECONF = '--prefix=${prefix} \
                  --host=${HOST_SYS} \
#2 lore raw
Quoted 9 lines · Saul Wold

Review

Quoted 7 lines · David Nyström
---
  meta/recipes-multimedia/x264/x264_git.bb | 1 +
  1 file changed, 1 insertion(+)
(quoted diff) +0 -0

x264_git.bb

Quoted 10 lines

meta/recipes-multimedia/x264/x264_git.bb inherit lib_package pkgconfig · line 27

Quoted 9 lines

index 5ebf885..782c26e 100644

meta/recipes-multimedia/x264/x264_git.bb +1 -0
@@ -23,6 +23,7 @@ inherit lib_package pkgconfig
  X264_DISABLE_ASM = ""
  X264_DISABLE_ASM_armv4 = "--disable-asm"
  X264_DISABLE_ASM_armv5 = "--disable-asm"
+X264_DISABLE_ASM_e500v2 = "--disable-asm"
 

I think that this change really belongs in the e500v2 BSP, it's not

generic enough to include in core.

Perhaps you know this already, but e500v2 is a cpu arch, same as armv5.

For future reference, should all ppc related CPU-arch specific stuff be directed to the FSL bsp ?

Br,
David

Quoted 9 lines

Thanks
Sau!

Quoted 3 lines
meta/recipes-multimedia/x264/x264_git.bb +0 -0
  EXTRA_OECONF = '--prefix=${prefix} \
                  --host=${HOST_SYS} \
#3 lore raw
Quoted 2 lines · David Nystrom

Perhaps you know this already, but e500v2 is a cpu arch, same as armv5.

Is that really true? I thought e500v2 was an actual core and the equivalent architecture was Power v2.03 or something.

Quoted 2 lines

For future reference, should all ppc related CPU-arch specific stuff be directed to the FSL bsp ?

Since we do ship tune-ppce500.inc in oe-core, I think it makes sense to also include the overrides necessary to make compilation work with SPE enabled. It doesn't seem unreasonable that users would expect that the recipes in oe-core would work with a configuration that comes as standard.

However, adding overrides for e500v2 specifically does seem like a bad plan since we will then end up having to duplicate the thing for every other non-altivec configuration. Can you come up with some override that will apply to all SPE configurations, or failing that a patch for the configure script that will disable the altivec assembler if it notices that ${CC} is configured for SPE?

p.

#4 lore raw
Quoted 5 lines · Phil Blundell
Quoted 2 lines · David Nystrom

Perhaps you know this already, but e500v2 is a cpu arch, same as armv5.

Is that really true? I thought e500v2 was an actual core and the equivalent architecture was Power v2.03 or something.

Yes, good point.
I understand Sauls concern.

Quoted 9 lines
Quoted 3 lines

For future reference, should all ppc related CPU-arch specific stuff be directed to the FSL bsp ?

Since we do ship tune-ppce500.inc in oe-core, I think it makes sense to also include the overrides necessary to make compilation work with SPE enabled. It doesn't seem unreasonable that users would expect that the recipes in oe-core would work with a configuration that comes as standard.

Quoted 4 lines

However, adding overrides for e500v2 specifically does seem like a bad plan since we will then end up having to duplicate the thing for every other non-altivec configuration. Can you come up with some override that will apply to all SPE configurations,

Yep, will return with V2.

Quoted 7 lines

or failing that a patch for
the configure script that will disable the altivec assembler if it notices that ${CC} is configured for SPE?

p.

#5 lore raw

PATCH v2 1/1 x246: Disable Altivec asm when SPE is enabled.

In reply to David Nyström

asm code is written for Altivec, and should be disabled for powerpc SPE enabled targets.

---
 meta/recipes-multimedia/x264/x264_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-multimedia/x264/x264_git.bb +1 -0
index 5ebf885..0e305ea 100644
@@ -23,6 +23,7 @@ inherit lib_package pkgconfig
 X264_DISABLE_ASM = ""
 X264_DISABLE_ASM_armv4 = "--disable-asm"
 X264_DISABLE_ASM_armv5 = "--disable-asm"
+X264_DISABLE_ASM_powerpc = "${@bb.utils.contains("TUNE_FEATURES", "spe", "--disable-asm", "", d)}"
 
 EXTRA_OECONF = '--prefix=${prefix} \
                 --host=${HOST_SYS} \
Signature · 1 line
1.8.3.2